servo: Merge #3539 - Replace implementation of is in actor.rs (from jimberlage:fix/meaningful-is); r=jdm

This is intended to address #3488.  [AnyPrivate](http://doc.rust-lang.org/core/any/trait.AnyPrivate.html) is now in the Rust core, so we can leverage that instead of writing an implementation.

Source-Repo: https://github.com/servo/servo
Source-Revision: da6878a4e2925cefe9aa9368890d5791f965433e
This commit is contained in:
Jim Berlage 2014-10-01 14:03:27 -06:00
Родитель 166dee8d53
Коммит 68ad93214e
1 изменённых файлов: 7 добавлений и 9 удалений

Просмотреть файл

@ -4,9 +4,10 @@
/// General actor system infrastructure.
use std::any::{Any, AnyRefExt, AnyMutRefExt};
use std::any::{AnyPrivate, AnyRefExt, AnyMutRefExt};
use std::collections::hashmap::HashMap;
use std::cell::{Cell, RefCell};
use std::intrinsics::TypeId;
use std::io::TcpStream;
use std::mem::{transmute, transmute_copy, replace};
use std::raw::TraitObject;
@ -15,7 +16,7 @@ use serialize::json;
/// A common trait for all devtools actors that encompasses an immutable name
/// and the ability to process messages that are directed to particular actors.
/// TODO: ensure the name is immutable
pub trait Actor: Any {
pub trait Actor: AnyPrivate {
fn handle_message(&self,
registry: &ActorRegistry,
msg_type: &String,
@ -42,14 +43,11 @@ impl<'a> AnyMutRefExt<'a> for &'a mut Actor + 'a {
impl<'a> AnyRefExt<'a> for &'a Actor + 'a {
fn is<T: 'static>(self) -> bool {
//FIXME: This implementation is bogus since get_type_id is private now.
// However, this implementation is only needed so long as there's a Rust bug
// that prevents downcast_ref from giving realistic return values, and this is
// ok since we're careful with the types we pull out of the hashmap.
/*let t = TypeId::of::<T>();
// This implementation is only needed so long as there's a Rust bug that
// prevents downcast_ref from giving realistic return values.
let t = TypeId::of::<T>();
let boxed = self.get_type_id();
t == boxed*/
true
t == boxed
}
fn downcast_ref<T: 'static>(self) -> Option<&'a T> {