Fix for 129789, XBL form control selects need to leave space for scrollbars. r=bryner, sr=ben, a=brendan

layout/forms/resources/content/select.xml

@@ -146,7 +146,7 @@
             <children/>
           </xul:outlinerchildren>
         </xul:hbox>
-        <xul:scrollbar orient="vertical" class="outliner-scrollbar" collapsed="true"/>
+        <xul:scrollbar orient="vertical" class="select-scrollbar" disabled="true"/>
       </xul:outlinerrows>
     </content>
 
@@ -614,13 +614,13 @@
     <handlers>
       <handler event="underflow">
         <![CDATA[
-          this.childNodes[1].collapsed = true;
+          this.childNodes[1].setAttribute("disabled", true);
           event.preventBubble();
         ]]>
       </handler>
       <handler event="overflow">
         <![CDATA[
-          this.childNodes[1].collapsed = false;
+          this.childNodes[1].removeAttribute("disabled");
           event.preventBubble();
         ]]>
       </handler>

layout/forms/resources/content/xbl-forms.css

@@ -74,6 +74,9 @@ xul|*.select-outlinerbody {
   display: -moz-box;
 }
 
+xul|*.select-scrollbar[disabled="true"] {
+  visibility: hidden;
+}
 
 input[type="checkbox"] {
   -moz-binding: url("chrome://forms/content/checkbox.xml#checkbox");

layout/html/forms/resources/content/select.xml

@@ -146,7 +146,7 @@
             <children/>
           </xul:outlinerchildren>
         </xul:hbox>
-        <xul:scrollbar orient="vertical" class="outliner-scrollbar" collapsed="true"/>
+        <xul:scrollbar orient="vertical" class="select-scrollbar" disabled="true"/>
       </xul:outlinerrows>
     </content>
 
@@ -614,13 +614,13 @@
     <handlers>
       <handler event="underflow">
         <![CDATA[
-          this.childNodes[1].collapsed = true;
+          this.childNodes[1].setAttribute("disabled", true);
           event.preventBubble();
         ]]>
       </handler>
       <handler event="overflow">
         <![CDATA[
-          this.childNodes[1].collapsed = false;
+          this.childNodes[1].removeAttribute("disabled");
           event.preventBubble();
         ]]>
       </handler>

layout/html/forms/resources/content/xbl-forms.css

@@ -74,6 +74,9 @@ xul|*.select-outlinerbody {
   display: -moz-box;
 }
 
+xul|*.select-scrollbar[disabled="true"] {
+  visibility: hidden;
+}
 
 input[type="checkbox"] {
   -moz-binding: url("chrome://forms/content/checkbox.xml#checkbox");