Bug 1064481 - URLSearchParams should encode % values correcty. r=ehsan

2014-09-08 19:27:00 -04:00 · 2014-09-08 19:27:00 -04:00 · 697875e210
--- a/dom/base/URLSearchParams.cpp
+++ b/dom/base/URLSearchParams.cpp
@ -349,7 +349,7 @@ public:
                 (*p >= 0x61 && *p <= 0x7A)) {
        mValue.Append(*p);
      } else {
-        mValue.AppendPrintf("%%%X", *p);
+        mValue.AppendPrintf("%%%.2X", *p);
      }

      ++p;
--- a/dom/base/test/mochitest.ini
+++ b/dom/base/test/mochitest.ini
@ -25,6 +25,7 @@ skip-if = buildapp == 'mulet'
 [test_bug999456.html]
 [test_bug1022229.html]
 [test_bug1043106.html]
+[test_bug1064481.html]
 [test_clearTimeoutIntervalNoArg.html]
 [test_consoleEmptyStack.html]
 [test_constructor-assignment.html]
--- a/dom/base/test/test_bug1064481.html
+++ b/dom/base/test/test_bug1064481.html
@ -0,0 +1,24 @@
+<!DOCTYPE HTML>
+<html>
+<!--
+https://bugzilla.mozilla.org/show_bug.cgi?id=1064481
+-->
+<head>
+  <meta charset="utf-8">
+  <title>Test for Bug 1064481</title>
+  <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
+  <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
+</head>
+<body>
+  <a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1064481">Mozilla Bug 1064481</a>
+  <iframe id="iframe"></iframe>
+  <script type="application/javascript">
+
+var a = new URLSearchParams();
+
+a.set('foobar', 'a\nb');
+is(a.toString(), 'foobar=a%0Ab', "Bug fixed");
+
+  </script>
+</body>
+</html>