Bug 1523562 [wpt PR 14858] - Reland "Reland "Reland "[PE] Fix background-image on ::first-line""", a=testonly

Automatic update from web-platform-tests
Reland "Reland "Reland "[PE] Fix background-image on ::first-line"""

This reverts commit 36dab48068086f08eacf7f283293d6ce49493440.

Reason for revert: Reverting broke the compilation. A broken test is better than a non-compiling tree.

Original change's description:
> Revert "Reland "Reland "[PE] Fix background-image on ::first-line"""
>
> This reverts commit bd339720737e44c9d730bb8a71990f30f6dd4ccf.
>
> Reason for revert: test still failing, see crbug.com/920115
>
> Original change's description:
> > Reland "Reland "[PE] Fix background-image on ::first-line""
> >
> > This reverts commit 3edb3f1bbe315083871126bcbe4d422556b0d69f.
> >
> > Fix by moving UpdateFirstLineImageObservers() from
> > CachedFirstLineStyle() into GetCachedPseudoStyle() to ensure
> > we update image observers for the correct object.
> >
> > Original change's description:
> > > Revert "Reland "[PE] Fix background-image on ::first-line""
> > >
> > > This reverts commit f6facb87f009321e336fea1db249ad41f4116bb8.
> > >
> > > Reason for revert: Still can't ensure strictly paired AddClient/RemoveClient.
> > >
> > > Bug: 921337,921341
> > >
> > > Original change's description:
> > > > Reland "[PE] Fix background-image on ::first-line"
> > > >
> > > > This reverts commit 3b58524dfeb579392545998cbb64841138cc5a6e.
> > > >
> > > > The original patch failed to call RemoveClient for the background-image
> > > > in the first line style.
> > > >
> > > > Original change's description:
> > > > > Revert "[PE] Fix background-image on ::first-line"
> > > > >
> > > > > This reverts commit fe023954ad31e422d0deb4116d7867098e11b688.
> > > > >
> > > > > Reason for revert: crbug.com/920115
> > > > >
> > > > > Bug: 920115
> > > > >
> > > > > Original change's description:
> > > > > > [PE] Fix background-image on ::first-line
> > > > > >
> > > > > > This CL ensures correct handling of background-image on ::first-line
> > > > > > from style change to paint invalidation.
> > > > > >
> > > > > > Bug: 918881
> > > > > > Change-Id: I2e3a7bf60cb0f851b203fc7f5135c4186cc731a3
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1396154
> > > > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > > > > > Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> > > > > > Cr-Commit-Position: refs/heads/master@{#620921}
> > > > >
> > > > > TBR=wangxianzhu@chromium.org,futhark@chromium.org
> > > > >
> > > > > Change-Id: Iba8387598922eaccd35f44bcaceac1cff59ea83a
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: 918881
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1403315
> > > > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#621178}
> > > >
> > > > Bug: 920115, 918881
> > > > Change-Id: I3ea101ae09ad062de657a8917d77b1ec34e329e4
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1403316
> > > > Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#622298}
> > >
> > > TBR=wangxianzhu@chromium.org,futhark@chromium.org
> > >
> > > Change-Id: I6d31b858b2bf61bb123c6bdb09780f33e05b4878
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 920115, 918881
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1407974
> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#622325}
> >
> > Change-Id: I2509073937be3b1eb8f4bdc0d6f5151c93253851
> > Bug: 921337, 921341, 920115, 918881
> > Reviewed-on: https://chromium-review.googlesource.com/c/1408358
> > Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#622542}
>
> TBR=wangxianzhu@chromium.org,futhark@chromium.org
>
> Change-Id: I3f5aca68d9e5e739f262187171530fc718ff71a9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 921337, 921341, 920115, 918881
> Reviewed-on: https://chromium-review.googlesource.com/c/1411534
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Commit-Queue: Dominic Battré <battre@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622787}

TBR=wangxianzhu@chromium.org,battre@chromium.org,futhark@chromium.org

Change-Id: I46dca78e51fe16ff7091674028b184a6d7cc1b83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 921337, 921341, 920115, 918881
Reviewed-on: https://chromium-review.googlesource.com/c/1411595
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622796}

--

wpt-commits: 9b7ef11c54ca4ae4113c033aa1b0af2a44e4cc88
wpt-pr: 14858

testing/web-platform/tests/css/css-backgrounds/background-image-first-line.html

@@ -0,0 +1,19 @@
+<!DOCTYPE html>
+<title>CSS Test: background-image applicability to ::first-letter</title>
+<link rel="help" href="http://www.w3.org/TR/css3-background/">
+<link rel="help" href="http://www.w3.org/TR/CSS21/selector.html#first-line-pseudo">
+<link rel="match" href="reference/background-image-first-line-ref.html">
+<meta name="flags" content="ahem image">
+<meta name="assert" content="background-image applicability to ::first-line">
+<style type="text/css">
+#content {
+  color: transparent;
+  font: 100px Ahem;
+}
+#content::first-line {
+  background-image: url("support/cat.png");  /* 98 w. by 99px h. */
+  background-repeat: no-repeat;
+}
+</style>
+<p>Test passes if cat image is visible.</p>
+<div id="content">X</div>

testing/web-platform/tests/css/css-backgrounds/reference/background-image-first-line-ref.html

@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<meta name="flags" content="ahem image">
+<style type="text/css">
+#content {
+  color: transparent;
+  font: 100px Ahem;
+  background-image: url("../support/cat.png");  /* 98 w. by 99px h. */
+  background-repeat: no-repeat;
+}
+</style>
+<p>Test passes if cat image is visible.</p>
+<div id="content">X</div>