Bug 1470128 - Instrument inspector shadowdom support;r=pbro

MozReview-Commit-ID: JCknoaPiSlR

--HG--
extra : rebase_source : 2cc46308ab464b27da256ba9dd3473bd037ed1e6
This commit is contained in:
Julian Descottes 2018-06-25 14:33:21 +02:00
Родитель f5b2c7c8e6
Коммит 6c30b83d4b
3 изменённых файлов: 55 добавлений и 3 удалений

Просмотреть файл

@ -74,6 +74,10 @@ MarkupContainer.prototype = {
// Marking the node as shown or hidden
this.updateIsDisplayed();
if (node.isShadowRoot) {
this.markup.telemetry.scalarSet("devtools.shadowdom.shadow_root_displayed", true);
}
},
buildMarkup: function() {
@ -332,6 +336,10 @@ MarkupContainer.prototype = {
if (this.showExpander) {
this.tagLine.setAttribute("aria-expanded", this.expanded);
}
if (this.node.isShadowRoot) {
this.markup.telemetry.scalarSet("devtools.shadowdom.shadow_root_expanded", true);
}
},
/**

Просмотреть файл

@ -39,9 +39,9 @@ SlottedNodeContainer.prototype = extend(MarkupContainer.prototype, {
return;
}
this.markup.inspector.selection.setNodeFront(this.node, {
reason: "reveal-from-slot"
});
const reason = "reveal-from-slot";
this.markup.inspector.selection.setNodeFront(this.node, { reason });
this.markup.telemetry.scalarSet("devtools.shadowdom.reveal_link_clicked", true);
},
isDraggable: function() {

Просмотреть файл

@ -948,6 +948,50 @@ devtools.inspector:
record_in_processes:
- 'main'
devtools.shadowdom:
shadow_root_displayed:
bug_numbers:
- 1470128
description: >
Whether the markup view displayed any #shadow-root element in the UI.
expires: "66"
kind: boolean
notification_emails:
- dev-developer-tools@lists.mozilla.org
- jdescottes@mozilla.com
release_channel_collection: opt-out
record_in_processes:
- 'main'
shadow_root_expanded:
bug_numbers:
- 1470128
description: >
Whether the user expanded any #shadow-root element.
expires: "66"
kind: boolean
notification_emails:
- dev-developer-tools@lists.mozilla.org
- jdescottes@mozilla.com
release_channel_collection: opt-out
record_in_processes:
- 'main'
reveal_link_clicked:
bug_numbers:
- 1470128
description: >
Whether the user clicked on any "reveal" link. "reveal" links are displayed in
shadow dom trees in the markup view.
expires: "66"
kind: boolean
notification_emails:
- dev-developer-tools@lists.mozilla.org
- jdescottes@mozilla.com
release_channel_collection: opt-out
record_in_processes:
- 'main'
devtools:
current_theme:
bug_numbers: