Backed out changeset 461d5599aa8c (bug 977372) for bustage.

CLOSED TREE
This commit is contained in:
Ryan VanderMeulen 2014-02-28 15:20:32 -05:00
Родитель c79312959a
Коммит 6c3f8bad68
2 изменённых файлов: 1 добавлений и 9 удалений

Просмотреть файл

@ -757,11 +757,7 @@ nsDOMCameraControl::OnCreatedFileDescriptor(bool aSucceeded)
return; return;
} }
} }
// An error occured. We need to manually close the file descriptor since
// the FileDescriptor destructor doesn't close file handles which originate
// from other processes.
int fd = mDSFileDescriptor->mFileDescriptor.PlatformHandle();
ScopedClose autoClose(fd);
OnError(CameraControlListener::kInStartRecording, NS_LITERAL_STRING("FAILURE")); OnError(CameraControlListener::kInStartRecording, NS_LITERAL_STRING("FAILURE"));
} }

Просмотреть файл

@ -856,11 +856,7 @@ nsGonkCameraControl::StartRecordingImpl(DeviceStorageFileDescriptor* aFileDescri
} }
nsresult rv; nsresult rv;
// SetupRecording creates a dup of the file descriptor, and since it
// was created in the parent, the FileDescriptor destructor won't close
// it, so we go ahead and close it once we leave this function.
int fd = aFileDescriptor->mFileDescriptor.PlatformHandle(); int fd = aFileDescriptor->mFileDescriptor.PlatformHandle();
ScopedClose autoClose(fd);
if (aOptions) { if (aOptions) {
rv = SetupRecording(fd, aOptions->rotation, aOptions->maxFileSizeBytes, rv = SetupRecording(fd, aOptions->rotation, aOptions->maxFileSizeBytes,
aOptions->maxVideoLengthMs); aOptions->maxVideoLengthMs);