Bug 1698883 - Remove the panel-footer-menulike class. r=mhowell

We kept this class around so that we could toggle back and forth between the
Photon-era footer button style, and the Proton-era menuitem style for footer
buttons.

Now that v89 has shipped, we can remove that class and switch the markup and
styling over completely to the Proton styling.

Differential Revision: https://phabricator.services.mozilla.com/D117553

browser/components/controlcenter/content/identityPanel.inc.xhtml

@@ -94,10 +94,11 @@
 
       <!-- Clear Site Data Button -->
       <vbox hidden="true"
-            id="identity-popup-clear-sitedata-footer"
-            class="panel-footer panel-footer-menulike">
-        <button id="identity-popup-clear-sitedata-button"
+            id="identity-popup-clear-sitedata-footer">
+        <toolbarseparator />
+        <toolbarbutton id="identity-popup-clear-sitedata-button"
                 data-l10n-id="identity-clear-site-data"
+                class="subviewbutton panel-subview-footer-button"
                 oncommand="gIdentityHandler.clearSiteData(event);"/>
       </vbox>
     </panelview>
@@ -183,10 +184,12 @@
                 oncommand="gIdentityHandler.enableMixedContentProtection()"/>
       </vbox>
 
-      <vbox id="identity-popup-more-info-footer" class="panel-footer panel-footer-menulike">
+      <vbox id="identity-popup-more-info-footer">
         <!-- More Security Information -->
-        <button id="identity-popup-more-info"
+        <toolbarseparator />
+        <toolbarbutton id="identity-popup-more-info"
                 data-l10n-id="identity-more-info-link-text"
+                class="subviewbutton panel-subview-footer-button"
                 oncommand="gIdentityHandler.handleMoreInfoClick(event);"/>
       </vbox>
 

browser/components/controlcenter/content/protectionsPanel.inc.xhtml

@@ -234,11 +234,11 @@
         <toolbarseparator></toolbarseparator>
         <vbox id="protections-popup-trackersView-list" class="protections-popup-list">
         </vbox>
-        <vbox class="panel-footer panel-footer-menulike">
-          <button id="protections-popup-trackersView-settings-button"
-                  data-l10n-id="protections-panel-content-blocking-manage-settings"
-                  oncommand="gProtectionsHandler.openPreferences(); gProtectionsHandler.recordClick('subview_settings', 'trackers');"/>
-        </vbox>
+        <toolbarseparator></toolbarseparator>
+        <toolbarbutton id="protections-popup-trackersView-settings-button"
+                data-l10n-id="protections-panel-content-blocking-manage-settings"
+                class="subviewbutton panel-subview-footer-button"
+                oncommand="gProtectionsHandler.openPreferences(); gProtectionsHandler.recordClick('subview_settings', 'trackers');"/>
     </panelview>
 
     <!-- Social Block SubView -->
@@ -263,11 +263,11 @@
         <toolbarseparator></toolbarseparator>
         <vbox id="protections-popup-socialblockView-list" class="protections-popup-list">
         </vbox>
-        <vbox class="panel-footer panel-footer-menulike">
-          <button id="protections-popup-socialblockView-settings-button"
-                  data-l10n-id="protections-panel-content-blocking-manage-settings"
-                  oncommand="gProtectionsHandler.openPreferences(); gProtectionsHandler.recordClick('subview_settings', 'social');"/>
-        </vbox>
+        <toolbarseparator></toolbarseparator>
+        <toolbarbutton id="protections-popup-socialblockView-settings-button"
+                data-l10n-id="protections-panel-content-blocking-manage-settings"
+                class="subviewbutton panel-subview-footer-button"
+                oncommand="gProtectionsHandler.openPreferences(); gProtectionsHandler.recordClick('subview_settings', 'social');"/>
     </panelview>
 
     <!-- Cookies SubView -->
@@ -280,11 +280,11 @@
         <toolbarseparator></toolbarseparator>
         <vbox id="protections-popup-cookiesView-list" class="protections-popup-list">
         </vbox>
-        <vbox class="panel-footer panel-footer-menulike">
-          <button id="protections-popup-cookiesView-settings-button"
+        <toolbarseparator></toolbarseparator>
+        <toolbarbutton id="protections-popup-cookiesView-settings-button"
                   data-l10n-id="protections-panel-content-blocking-manage-settings"
+                  class="subviewbutton panel-subview-footer-button"
                   oncommand="gProtectionsHandler.openPreferences(); gProtectionsHandler.recordClick('subview_settings', 'cookies');"/>
-        </vbox>
     </panelview>
 
     <!-- Fingerprinters SubView -->
@@ -309,11 +309,11 @@
         <toolbarseparator></toolbarseparator>
         <vbox id="protections-popup-fingerprintersView-list" class="protections-popup-list">
         </vbox>
-        <vbox class="panel-footer panel-footer-menulike">
-          <button id="protections-popup-fingerprintersView-settings-button"
+        <toolbarseparator></toolbarseparator>
+        <toolbarbutton id="protections-popup-fingerprintersView-settings-button"
                   data-l10n-id="protections-panel-content-blocking-manage-settings"
+                  class="subviewbutton panel-subview-footer-button"
                   oncommand="gProtectionsHandler.openPreferences(); gProtectionsHandler.recordClick('subview_settings', 'fingerprinters');"/>
-        </vbox>
     </panelview>
 
     <!-- Cryptominers SubView -->
@@ -338,11 +338,11 @@
         <toolbarseparator></toolbarseparator>
         <vbox id="protections-popup-cryptominersView-list" class="protections-popup-list">
         </vbox>
-        <vbox class="panel-footer panel-footer-menulike">
-          <button id="protections-popup-cryptominersView-settings-button"
+        <toolbarseparator></toolbarseparator>
+        <toolbarbutton id="protections-popup-cryptominersView-settings-button"
                   data-l10n-id="protections-panel-content-blocking-manage-settings"
+                  class="subviewbutton panel-subview-footer-button"
                   oncommand="gProtectionsHandler.openPreferences(); gProtectionsHandler.recordClick('subview_settings', 'cryptominers');"/>
-        </vbox>
     </panelview>
 
     <!-- Send Report SubView -->

browser/components/downloads/content/downloads.css

@@ -95,11 +95,7 @@
   padding: 0.62em;
 }
 
+#downloadsHistory,
 #downloadsFooterButtons {
   margin: 0;
 }
-
-#downloadsHistory {
-  padding: 0.62em;
-  margin: 0.62em 0 0;
-}

browser/components/downloads/content/downloadsPanel.inc.xhtml

@@ -146,15 +146,15 @@
                            crop="end"/>
             </vbox>
           </hbox>
-          <hbox id="downloadsFooterButtons"
-                class="panel-footer panel-footer-menulike">
-            <button id="downloadsHistory"
+          <vbox id="downloadsFooterButtons">
+            <toolbarseparator />
+            <toolbarbutton id="downloadsHistory"
                     data-l10n-id="downloads-history"
-                    class="downloadsPanelFooterButton"
+                    class="downloadsPanelFooterButton subviewbutton panel-subview-footer-button"
                     flex="1"
                     oncommand="DownloadsPanel.showDownloadsHistory();"
                     pack="start"/>
-          </hbox>
+          </vbox>
         </stack>
       </vbox>
     </panelview>

browser/themes/shared/controlcenter/panel.inc.css

@@ -906,10 +906,6 @@ description#identity-popup-content-verifier,
 
 /* Protection popup footer categories */
 
-#protections-popup-footer {
-  padding: var(--vertical-section-padding) 0;
-}
-
 #protections-popup-trackers-blocked-counter-box {
   margin-inline-end: var(--horizontal-padding);
   visibility: hidden;

browser/themes/shared/customizableui/panelUI.inc.css

@@ -512,13 +512,6 @@ panelview[id^=PanelUI-webext-] {
   overflow: hidden;
 }
 
-panelview:not([mainview]) .toolbarbutton-text,
-.cui-widget-panel .toolbarbutton-text,
-#overflowMenu-customize-button > .toolbarbutton-text {
-  text-align: start;
-  display: -moz-box;
-}
-
 .cui-widget-panel,
 .cui-widget-panel::part(arrowcontent) {
   --arrowpanel-padding: 4px 0;
@@ -1537,6 +1530,11 @@ panelview .toolbarbutton-1,
   margin: 0;
 }
 
+.subviewbutton > .toolbarbutton-text {
+  text-align: start;
+  display: -moz-box;
+}
+
 .panel-subview-footer-button {
   margin-bottom: 6px;
 }
@@ -1820,9 +1818,10 @@ menuitem.panel-subview-footer@menuStateActive@,
 .PanelUI-subView toolbarseparator,
 #permission-popup-mainView > toolbarseparator,
 #protections-popup-multiView toolbarseparator,
-#identity-popup-mainView > toolbarseparator,
+#identity-popup-mainView toolbarseparator,
 #identity-popup-securityView > toolbarseparator,
 #editBookmarkPanel toolbarseparator,
+#downloadsPanel-mainView toolbarseparator,
 .cui-widget-panelview menuseparator,
 .cui-widget-panel toolbarseparator {
   appearance: none;

toolkit/themes/shared/popupnotification.inc.css

@@ -111,12 +111,6 @@ popupnotification {
   margin: 8px 16px 16px;
 }
 
-.panel-footer.panel-footer-menulike {
-  margin-inline: 8px;
-  margin-bottom: 6px;
-  border-top: 1px solid var(--panel-separator-color);
-}
-
 .panel-footer > button {
   appearance: none;
   border: 0;
@@ -127,29 +121,6 @@ popupnotification {
   margin-inline: 8px 0;
 }
 
-.panel-footer.panel-footer-menulike > button {
-  font-weight: unset;
-  padding: 8px;
-  margin: 4px 0 0;
-}
-
-.panel-footer.panel-footer-menulike > button:focus-visible {
-  box-shadow: var(--panelview-toolbarbutton-focus-box-shadow);
-}
-
-.panel-footer.panel-footer-menulike > button:hover:active {
-  color: inherit;
-}
-
-.panel-footer.panel-footer-menulike > button > .button-box {
-  padding: 0;
-  display: inline;
-}
-
-.panel-footer.panel-footer-menulike > button > .button-box > .button-text {
-  margin-inline: 0;
-}
-
 .panel-footer > .popup-notification-dropmarker {
   margin-inline-start: 0;
   border-start-start-radius: 0;
@@ -165,15 +136,15 @@ popupnotification {
   color: var(--button-color, inherit);
 }
 
-.panel-footer:not(.panel-footer-menulike) > button {
+.panel-footer > button {
   background-color: var(--button-bgcolor, color-mix(in srgb, currentColor 13%, transparent));
 }
 
-.panel-footer:not(.panel-footer-menulike) > button[disabled] {
+.panel-footer > button[disabled] {
   opacity: 0.4;
 }
 
-.panel-footer:not(.panel-footer-menulike) > button:focus-visible {
+.panel-footer > button:focus-visible {
   outline: 2px solid var(--focus-outline-color);
   outline-offset: var(--focus-outline-offset, 2px);
 }
@@ -199,7 +170,7 @@ popupnotification {
   background-color: var(--button-primary-active-bgcolor);
 }
 
-.panel-footer:not(.panel-footer-menulike) > button > .button-box {
+.panel-footer > button > .button-box {
   padding: 0;
 }