Bug 1677893 - CONFIG["CXX_TYPE"] is not a thing r=firefox-build-system-reviewers,andi,mhentges

Due to lack of `CXX_TYPE`, clang-cl builds were accidentally taking the `else` branch where the `-O0` was ignored/unrecognized. This went unnoticed for a long time until it busted the landing of bug 1677726.

While here, fix the intent of SmokeDMD: `-Og-` is a silent no-op in clang-cl, so it's not actually disabling anything.

Differential Revision: https://phabricator.services.mozilla.com/D97387
This commit is contained in:
David Major 2020-11-18 16:01:23 +00:00
Родитель aa45e3a48d
Коммит 6e260b8d5a
2 изменённых файлов: 3 добавлений и 3 удалений

Просмотреть файл

@ -67,7 +67,7 @@ if CONFIG["MOZ_DEBUG"]:
# Because we don't actually link this code anywhere, we don't care about
# their optimization level, so don't waste time on optimization.
if CONFIG["CXX_TYPE"] == "clang-cl":
if CONFIG["CC_TYPE"] == "clang-cl":
CXXFLAGS += ["-Od"]
else:
CXXFLAGS += ["-O0"]

Просмотреть файл

@ -12,8 +12,8 @@ GeckoSimplePrograms(
)
# See the comment at the top of SmokeDMD.cpp:RunTests().
if CONFIG["CXX_TYPE"] == "clang-cl":
CXXFLAGS += ["-Og-"]
if CONFIG["CC_TYPE"] == "clang-cl":
CXXFLAGS += ["-Od"]
else:
CXXFLAGS += ["-O0"]