From 6f845e97f4e551e3a0b5edd5d2bd155d1109f518 Mon Sep 17 00:00:00 2001
From: Tooru Fujisawa <arai_a@mac.com>
Date: Mon, 30 May 2022 15:19:36 +0000
Subject: [PATCH] Bug 1610653 - Part 3: Do not use global this property
 assignment to define global variable in browser/modules. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D144110
---
 browser/modules/BrowserWindowTracker.jsm | 2 +-
 browser/modules/EveryWindow.jsm          | 2 +-
 browser/modules/OpenInTabsUtils.jsm      | 4 ++--
 browser/modules/PingCentre.jsm           | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/browser/modules/BrowserWindowTracker.jsm b/browser/modules/BrowserWindowTracker.jsm
index 4a36ee91b7df..904169cdb753 100644
--- a/browser/modules/BrowserWindowTracker.jsm
+++ b/browser/modules/BrowserWindowTracker.jsm
@@ -147,7 +147,7 @@ var WindowHelper = {
   },
 };
 
-this.BrowserWindowTracker = {
+const BrowserWindowTracker = {
   /**
    * Get the most recent browser window.
    *
diff --git a/browser/modules/EveryWindow.jsm b/browser/modules/EveryWindow.jsm
index c8fe666a8066..052ae2322166 100644
--- a/browser/modules/EveryWindow.jsm
+++ b/browser/modules/EveryWindow.jsm
@@ -42,7 +42,7 @@ function callForEveryWindow(callback) {
   }
 }
 
-this.EveryWindow = {
+const EveryWindow = {
   /**
    * Registers init and uninit functions to be called on every window.
    *
diff --git a/browser/modules/OpenInTabsUtils.jsm b/browser/modules/OpenInTabsUtils.jsm
index a299d9e0d848..e50264e46eb8 100644
--- a/browser/modules/OpenInTabsUtils.jsm
+++ b/browser/modules/OpenInTabsUtils.jsm
@@ -4,7 +4,7 @@
 
 "use strict";
 
-this.EXPORTED_SYMBOLS = ["OpenInTabsUtils"];
+const EXPORTED_SYMBOLS = ["OpenInTabsUtils"];
 
 const { XPCOMUtils } = ChromeUtils.import(
   "resource://gre/modules/XPCOMUtils.jsm"
@@ -21,7 +21,7 @@ XPCOMUtils.defineLazyGetter(this, "bundle", function() {
  * Utility functions that can be used when opening multiple tabs, that can be
  * called without any tabbrowser instance.
  */
-this.OpenInTabsUtils = {
+const OpenInTabsUtils = {
   getString(key) {
     return bundle.GetStringFromName(key);
   },
diff --git a/browser/modules/PingCentre.jsm b/browser/modules/PingCentre.jsm
index b37bbf2f6e63..473828f2a1d8 100644
--- a/browser/modules/PingCentre.jsm
+++ b/browser/modules/PingCentre.jsm
@@ -159,7 +159,7 @@ class PingCentre {
 }
 
 this.PingCentre = PingCentre;
-this.PingCentreConstants = {
+const PingCentreConstants = {
   FHR_UPLOAD_ENABLED_PREF,
   TELEMETRY_PREF,
   LOGGING_PREF,