From 6fbf6cf8f6def2e2e45df4ebe098083a6224f4fd Mon Sep 17 00:00:00 2001 From: Bobby Holley Date: Fri, 16 Dec 2011 14:32:39 -0800 Subject: [PATCH] Bug 711288 - Unconditionally use the new value of JSPROP_READONLY in accessor -> data transformations. r=Waldo --- js/src/jsobj.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/js/src/jsobj.cpp b/js/src/jsobj.cpp index 8e2e88358612..8b912e7dd6c6 100644 --- a/js/src/jsobj.cpp +++ b/js/src/jsobj.cpp @@ -2331,7 +2331,8 @@ DefinePropertyOnObject(JSContext *cx, JSObject *obj, const jsid &id, const PropD unchanged |= JSPROP_PERMANENT; if (!desc.hasEnumerable) unchanged |= JSPROP_ENUMERATE; - if (!desc.hasWritable) + /* Watch out for accessor -> data transformations here. */ + if (!desc.hasWritable && shape->isDataDescriptor()) unchanged |= JSPROP_READONLY; if (desc.hasValue)