Bug 1661475 - Add a "Manage devices" item to the Send Tab menu. r=markh

Differential Revision: https://phabricator.services.mozilla.com/D88420

browser/base/content/browser-sync.js

@@ -1041,8 +1041,8 @@ var gSync = {
       addTargetDevice(target.id, target.name, type, lastModified);
     }
 
-    // "Send to All Devices" menu item
     if (targets.length > 1) {
+      // "Send to All Devices" menu item
       const separator = createDeviceNodeFn();
       separator.classList.add("sync-menuitem");
       fragment.appendChild(separator);
@@ -1050,6 +1050,27 @@ var gSync = {
         "sendToAllDevices.menuitem"
       );
       addTargetDevice("", allDevicesLabel, "");
+
+      // "Manage devices" menu item
+      const manageDevicesLabel = this.fxaStrings.GetStringFromName(
+        "manageDevices.menuitem"
+      );
+      // We piggyback on the createDeviceNodeFn implementation,
+      // it's a big disgusting.
+      const targetDevice = createDeviceNodeFn(
+        null,
+        manageDevicesLabel,
+        null,
+        null
+      );
+      targetDevice.addEventListener(
+        "command",
+        () => gSync.openDevicesManagementPage("sendtab"),
+        true
+      );
+      targetDevice.classList.add("sync-menuitem", "sendtab-target");
+      targetDevice.setAttribute("label", manageDevicesLabel);
+      fragment.appendChild(targetDevice);
     }
   },
 

browser/base/content/test/pageActions/browser_page_action_menu.js

@@ -508,6 +508,11 @@ add_task(async function sendToDevice_syncNotReady_configured() {
             label: "Send to All Devices",
           },
         });
+        expectedItems.push(null, {
+          attrs: {
+            label: "Manage Devices...",
+          },
+        });
         checkSendToDeviceItems(expectedItems);
       } else {
         ok(false, "This should never happen");
@@ -739,6 +744,11 @@ add_task(async function sendToDevice_devices() {
           label: "Send to All Devices",
         },
       },
+      {
+        attrs: {
+          label: "Manage Devices...",
+        },
+      },
     ];
     checkSendToDeviceItems(expectedItems);
 
@@ -1014,6 +1024,11 @@ add_task(async function sendToDevice_inUrlbar() {
           label: "Send to All Devices",
         },
       },
+      {
+        attrs: {
+          label: "Manage Devices...",
+        },
+      },
     ];
     checkSendToDeviceItems(expectedItems, true);
 

browser/base/content/test/sync/browser_contextmenu_sendpage.js

@@ -47,6 +47,7 @@ add_task(async function test_page_contextmenu() {
     { label: "Foo" },
     "----",
     { label: "Send to All Devices" },
+    { label: "Manage Devices..." },
   ]);
   await hideContentContextMenu();
 

browser/locales/en-US/chrome/browser/accounts.properties

@@ -41,6 +41,10 @@ thisDeviceDisconnectedBody = This computer has been disconnected.
 # Displayed in the Send Tab/Page/Link to Device context menu when right clicking a tab, a page or a link.
 sendToAllDevices.menuitem = Send to All Devices
 
+# LOCALIZATION NOTE (manageDevices.menuitem)
+# Displayed in the Send Tab/Page/Link to Device context menu when right clicking a tab, a page or a link.
+manageDevices.menuitem = Manage Devices…
+
 # LOCALIZATION NOTE (sendTabToDevice.unconfigured, sendTabToDevice.unconfigured.label2)
 # Displayed in the Send Tabs context menu when right clicking a tab, a page or a link
 # and the Sync account is unconfigured. Redirects to a marketing page.