Bug 201630 javascript strict warnings in nsPolicyViewer.js and pageInfoOverlay.js

r=neil sr=bz

extensions/p3p/resources/content/nsPolicyViewer.js

@@ -284,7 +284,8 @@ nsPolicyViewer.prototype =
               this.mLinkedURI.spec = node.href;
             }
             // Yay!, we have found the policy location no need to search the other link tags.
-            return this.handleURI(this.mLinkedURI, this.mFlag = nsIPolicyReference.IS_LINKED_URI);
+            this.handleURI(this.mLinkedURI, this.mFlag = nsIPolicyReference.IS_LINKED_URI);
+            return;
           }
           catch (ex) {
             // fall through to report error.
@@ -358,7 +359,8 @@ nsPolicyViewer.prototype =
             if (discuri) {
               discuri = this.mPolicyURL.resolve(discuri);
               if (discuri.match(/^\s*https?:/i)) {
-                return window.open(discuri); 
+                window.open(discuri); 
+                return;
               }
             }
             break;
@@ -441,7 +443,8 @@ nsPolicyViewer.prototype =
             if (opturi) {
               opturi = this.mPolicyURL.resolve(opturi);
               if (opturi.match(/^\s*https?:/i)) {
-                return window.open(opturi); 
+                window.open(opturi); 
+                return;
               }
             }
             break;              

extensions/p3p/resources/content/pageInfoOverlay.js

@@ -117,12 +117,12 @@ function makeURLAbsolute(url, base)
 
 function getLinksFor(aTagName, aAttrName, aWin, aDoc)
 {
-  var i, frame, list = new Array;
+  var i, frame, length, list = new Array;
 
   // cycle through frames
-  if (aWin && aWin.frames.length > 0)
+  if (aWin)
   {
-    var length = aWin.frames.length;
+    length = aWin.frames.length;
     for (i = 0; i < length; ++i)
     {
       frame = aWin.frames[i];
@@ -133,7 +133,7 @@ function getLinksFor(aTagName, aAttrName, aWin, aDoc)
 
   // now look for tags in the leaf document
   var elts = aDoc.getElementsByTagName(aTagName);
-  var length = elts.length;
+  length = elts.length;
   for (i = 0; i < length; ++i)
   {
     var url = elts[i][aAttrName];