Bug 1374674 - Enable more ESLint rules across the tree to help developers where we're already passing them (no-class-assign, no-const-assign, no-dupe-class-members). r=mossop

MozReview-Commit-ID: 6jJPhH08Ae7

--HG--
extra : rebase_source : 64efb6660fdd1a0d4390e8f9e4842199249ca54f

security/.eslintrc.js

@@ -36,21 +36,12 @@ module.exports = {
     // case/default clauses.
     "no-case-declarations": "error",
 
-    // Disallow modifying variables of class declarations.
-    "no-class-assign": "error",
-
     // Disallow use of the console API.
     "no-console": "error",
 
-    // Disallow modifying variables that are declared using const.
-    "no-const-assign": "error",
-
     // Disallow constant expressions in conditions (except for loops).
     "no-constant-condition": ["error", { "checkLoops": false }],
 
-    // Disallow duplicate class members.
-    "no-dupe-class-members": "error",
-
     // Disallow extending of native objects.
     "no-extend-native": "error",
 

tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js

@@ -150,9 +150,15 @@ module.exports = {
     // Use [] instead of Array()
     "no-array-constructor": "error",
 
+    // Disallow modifying variables of class declarations.
+    "no-class-assign": "error",
+
     // Disallow assignment operators in conditional statements
     "no-cond-assign": "error",
 
+    // Disallow modifying variables that are declared using const.
+    "no-const-assign": "error",
+
     // Disallow control characters in regular expressions.
     "no-control-regex": "error",
 
@@ -165,6 +171,9 @@ module.exports = {
     // No duplicate arguments in function declarations
     "no-dupe-args": "error",
 
+    // Disallow duplicate class members.
+    "no-dupe-class-members": "error",
+
     // No duplicate keys in object declarations
     "no-dupe-keys": "error",