From 709d56796c01be4c99eac66502a824d278244828 Mon Sep 17 00:00:00 2001 From: Ray Kraesig Date: Thu, 25 Aug 2022 19:35:32 +0000 Subject: [PATCH] Bug 1785162 - Always stall on OOM on Windows in Nightly r=gsvelto It's suspected that this may induce performance regressions. Do it anyway, just to find out how bad it is. (But only on Nightly, for now.) For simplicity's sake, this does not include any additional telemetry; the decision of whether and what any additional telemetry is needed will be deferred until we have some feedback from what we've already got. Differential Revision: https://phabricator.services.mozilla.com/D155301 --- memory/build/mozjemalloc.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/memory/build/mozjemalloc.cpp b/memory/build/mozjemalloc.cpp index 5a1a0d1bb7d2..c53f0d2fd18b 100644 --- a/memory/build/mozjemalloc.cpp +++ b/memory/build/mozjemalloc.cpp @@ -1389,6 +1389,9 @@ static inline bool ShouldStallAndRetry() { // on Windows mostly skips this in favor of directly calling ::VirtualAlloc(), // though, so it's probably not going to matter whether we stall here or not.) return true; +# elif defined(NIGHTLY_BUILD) + // On Nightly, always stall, for experiment's sake (bug 1785162). + return true; # else // In the main process, always stall. if (GetGeckoProcessType() == GeckoProcessType::GeckoProcessType_Default) {