зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1313626 - Clean up more issues found by eslint no-undef rule. r=mossop
MozReview-Commit-ID: HGiOmpyN5zV --HG-- extra : rebase_source : f09a308b4c34b3cd3c28e170440bd1012176ef08
This commit is contained in:
Mark Banner
Родитель
bd39b95a9f
Коммит
709dd68567
|
|
@ -845,7 +845,7 @@ var BookmarksEventHandler = {
|
|||
// If this event bubbled up from a menu or menuitem, close the menus.
|
||||
// Do this before opening tabs, to avoid hiding the open tabs confirm-dialog.
|
||||
if (target.localName == "menu" || target.localName == "menuitem") {
|
||||
for (node = target.parentNode; node; node = node.parentNode) {
|
||||
for (let node = target.parentNode; node; node = node.parentNode) {
|
||||
if (node.localName == "menupopup")
|
||||
node.hidePopup();
|
||||
else if (node.localName != "menu" &&
|
||||
|
|
@ -2001,4 +2001,3 @@ var AutoShowBookmarksToolbar = {
|
|||
setToolbarVisibility(toolbar, true);
|
||||
}
|
||||
};
|
||||
|
||||
|
|
|
|||
|
|
@ -29,7 +29,6 @@ support-files =
|
|||
contextmenu_common.js
|
||||
ctxmenu-image.png
|
||||
discovery.html
|
||||
domplate_test.js
|
||||
download_page.html
|
||||
dummy_page.html
|
||||
feed_tab.html
|
||||
|
|
|
|||
|
|
@ -8,10 +8,10 @@ XPCOMUtils.defineLazyModuleGetter(this, "FormHistory",
|
|||
add_task(function* test() {
|
||||
// This test relies on the form history being empty to start with delete
|
||||
// all the items first.
|
||||
yield new Promise(resolve => {
|
||||
yield new Promise((resolve, reject) => {
|
||||
FormHistory.update({ op: "remove" },
|
||||
{ handleError(error) {
|
||||
do_throw("Error occurred updating form history: " + error);
|
||||
reject(error);
|
||||
},
|
||||
handleCompletion(reason) {
|
||||
if (!reason) {
|
||||
|
|
|
|||
|
|
@ -148,11 +148,11 @@ function waitForInstallDialog() {
|
|||
|
||||
info("Waiting for install dialog");
|
||||
|
||||
yield new Promise(resolve => {
|
||||
let window = yield new Promise(resolve => {
|
||||
Services.wm.addListener({
|
||||
onOpenWindow: function(aXULWindow) {
|
||||
Services.wm.removeListener(this);
|
||||
resolve();
|
||||
resolve(aXULWindow);
|
||||
},
|
||||
onCloseWindow: function(aXULWindow) {
|
||||
},
|
||||
|
|
@ -162,8 +162,8 @@ function waitForInstallDialog() {
|
|||
});
|
||||
info("Install dialog opened, waiting for focus");
|
||||
|
||||
let domwindow = aXULWindow.QueryInterface(Ci.nsIInterfaceRequestor)
|
||||
.getInterface(Ci.nsIDOMWindow);
|
||||
let domwindow = window.QueryInterface(Ci.nsIInterfaceRequestor)
|
||||
.getInterface(Ci.nsIDOMWindow);
|
||||
yield new Promise(resolve => {
|
||||
waitForFocus(function() {
|
||||
resolve();
|
||||
|
|
@ -748,7 +748,6 @@ function test_localFile() {
|
|||
|
||||
yield removeTab();
|
||||
});
|
||||
path = CHROMEROOT + "corrupt.xpi";
|
||||
},
|
||||
|
||||
function test_tabClose() {
|
||||
|
|
|
|||
|
|
@ -59,7 +59,7 @@ function countEntries(name, message, check) {
|
|||
let count;
|
||||
FormHistory.count(obj, { handleResult: result => count = result,
|
||||
handleError: function (error) {
|
||||
do_throw("Error occurred searching form history: " + error);
|
||||
throw new Error("Error occurred searching form history: " + error);
|
||||
deferred.reject(error)
|
||||
},
|
||||
handleCompletion: function (reason) {
|
||||
|
|
@ -494,7 +494,7 @@ function* setupFormHistory() {
|
|||
let results = [];
|
||||
FormHistory.search(terms, params, { handleResult: result => results.push(result),
|
||||
handleError: function (error) {
|
||||
do_throw("Error occurred searching form history: " + error);
|
||||
throw new Error("Error occurred searching form history: " + error);
|
||||
deferred.reject(error);
|
||||
},
|
||||
handleCompletion: function (reason) { deferred.resolve(results); }
|
||||
|
|
@ -506,7 +506,7 @@ function* setupFormHistory() {
|
|||
{
|
||||
let deferred = Promise.defer();
|
||||
FormHistory.update(changes, { handleError: function (error) {
|
||||
do_throw("Error occurred searching form history: " + error);
|
||||
throw new Error("Error occurred searching form history: " + error);
|
||||
deferred.reject(error);
|
||||
},
|
||||
handleCompletion: function (reason) { deferred.resolve(); }
|
||||
|
|
|
|||
|
|
@ -902,7 +902,7 @@ function promiseAddFormEntryWithMinutesAgo(aMinutesAgo) {
|
|||
return new Promise((resolve, reject) =>
|
||||
FormHistory.update({ op: "add", fieldname: name, value: "dummy", firstUsed: timestamp },
|
||||
{ handleError: function (error) {
|
||||
do_throw("Error occurred updating form history: " + error);
|
||||
throw new Error("Error occurred updating form history: " + error);
|
||||
reject();
|
||||
},
|
||||
handleCompletion: function (reason) {
|
||||
|
|
@ -922,7 +922,7 @@ function formNameExists(name)
|
|||
FormHistory.count({ fieldname: name },
|
||||
{ handleResult: result => count = result,
|
||||
handleError: function (error) {
|
||||
do_throw("Error occurred searching form history: " + error);
|
||||
throw new Error("Error occurred searching form history: " + error);
|
||||
reject(error);
|
||||
},
|
||||
handleCompletion: function (reason) {
|
||||
|
|
@ -953,7 +953,7 @@ function* blankSlate() {
|
|||
}
|
||||
},
|
||||
handleError(error) {
|
||||
do_throw("Error occurred updating form history: " + error);
|
||||
throw new Error("Error occurred updating form history: " + error);
|
||||
reject(error);
|
||||
}
|
||||
});
|
||||
|
|
|
|||
|
|
@ -1,51 +0,0 @@
|
|||
/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
|
||||
/* vim: set ts=2 et sw=2 tw=80: */
|
||||
/* This Source Code Form is subject to the terms of the Mozilla Public
|
||||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
||||
|
||||
var doc;
|
||||
var div;
|
||||
var plate;
|
||||
|
||||
Components.utils.import("resource://gre/modules/XPCOMUtils.jsm");
|
||||
Components.utils.import("resource:///modules/domplate.jsm");
|
||||
|
||||
function createDocument()
|
||||
{
|
||||
doc.body.innerHTML = '<div id="first">no</div>';
|
||||
doc.title = "Domplate Test";
|
||||
setupDomplateTests();
|
||||
}
|
||||
|
||||
function setupDomplateTests()
|
||||
{
|
||||
ok(domplate, "domplate is defined");
|
||||
plate = domplate({tag: domplate.DIV("Hello!")});
|
||||
ok(plate, "template is defined");
|
||||
div = doc.getElementById("first");
|
||||
ok(div, "we have our div");
|
||||
plate.tag.replace({}, div, template);
|
||||
is(div.innerText, "Hello!", "Is the div's innerText replaced?");
|
||||
finishUp();
|
||||
}
|
||||
|
||||
function finishUp()
|
||||
{
|
||||
gBrowser.removeCurrentTab();
|
||||
finish();
|
||||
}
|
||||
|
||||
function test()
|
||||
{
|
||||
waitForExplicitFinish();
|
||||
gBrowser.selectedTab = gBrowser.addTab();
|
||||
gBrowser.selectedBrowser.addEventListener("load", function() {
|
||||
gBrowser.selectedBrowser.removeEventListener("load", arguments.callee, true);
|
||||
doc = content.document;
|
||||
waitForFocus(createDocument, content);
|
||||
}, true);
|
||||
|
||||
content.location = "data:text/html;charset=utf-8,domplate_test.js";
|
||||
}
|
||||
|
||||
|
|
@ -0,0 +1,7 @@
|
|||
"use strict";
|
||||
|
||||
module.exports = {
|
||||
"extends": [
|
||||
"../../../../../testing/mochitest/browser.eslintrc.js"
|
||||
]
|
||||
};
|
||||
|
|
@ -0,0 +1,7 @@
|
|||
"use strict";
|
||||
|
||||
module.exports = {
|
||||
"extends": [
|
||||
"../../../../../testing/mochitest/browser.eslintrc.js"
|
||||
]
|
||||
};
|
||||
|
|
@ -0,0 +1,7 @@
|
|||
"use strict";
|
||||
|
||||
module.exports = {
|
||||
"extends": [
|
||||
"../../../../../testing/mochitest/browser.eslintrc.js"
|
||||
]
|
||||
};
|
||||
|
|
@ -0,0 +1,7 @@
|
|||
"use strict";
|
||||
|
||||
module.exports = {
|
||||
"extends": [
|
||||
"../../../../../testing/mochitest/browser.eslintrc.js"
|
||||
]
|
||||
};
|
||||
|
|
@ -980,7 +980,7 @@ this.PlacesUIUtils = {
|
|||
|
||||
PlacesUtils.livemarks.getLivemark({id: aNode.itemId})
|
||||
.then(aLivemark => {
|
||||
urlsToOpen = [];
|
||||
let urlsToOpen = [];
|
||||
|
||||
let nodes = aLivemark.getNodesForContainer(aNode);
|
||||
for (let node of nodes) {
|
||||
|
|
|
|||
|
|
@ -238,7 +238,7 @@ var gTranslationExceptions = {
|
|||
this.onSiteDeleted();
|
||||
},
|
||||
|
||||
onLanguageKeyPress: function() {
|
||||
onLanguageKeyPress: function(aEvent) {
|
||||
if (aEvent.keyCode == KeyEvent.DOM_VK_DELETE)
|
||||
this.onLanguageDeleted();
|
||||
},
|
||||
|
|
|
|||
|
|
@ -7,6 +7,7 @@ Cu.import("resource://gre/modules/Promise.jsm");
|
|||
|
||||
// Load mocking/stubbing library, sinon
|
||||
// docs: http://sinonjs.org/docs/
|
||||
/* global sinon */
|
||||
let loader = Cc["@mozilla.org/moz/jssubscript-loader;1"].getService(Ci.mozIJSSubScriptLoader);
|
||||
loader.loadSubScript("resource://testing-common/sinon-1.16.1.js");
|
||||
|
||||
|
|
|
|||
|
|
@ -24,6 +24,6 @@ let self = window;
|
|||
|
||||
// Load mocking/stubbing library, sinon
|
||||
// docs: http://sinonjs.org/docs/
|
||||
/* global sinon */
|
||||
let loader = Cc["@mozilla.org/moz/jssubscript-loader;1"].getService(Ci.mozIJSSubScriptLoader);
|
||||
loader.loadSubScript("resource://testing-common/sinon-1.16.1.js");
|
||||
|
||||
|
|
|
|||
|
|
@ -510,7 +510,7 @@ this.SocialService = {
|
|||
}
|
||||
// force/fixup origin
|
||||
let URI = Services.io.newURI(installOrigin, null, null);
|
||||
principal = Services.scriptSecurityManager.createCodebasePrincipal(URI, {});
|
||||
let principal = Services.scriptSecurityManager.createCodebasePrincipal(URI, {});
|
||||
data.origin = principal.origin;
|
||||
|
||||
// iconURL and name are required
|
||||
|
|
|
|||
|
|
@ -12,6 +12,7 @@ module.exports = {
|
|||
"deepEqual": false,
|
||||
"do_check_eq": false,
|
||||
"do_check_false": false,
|
||||
"do_check_matches": false,
|
||||
"do_check_neq": false,
|
||||
"do_check_null": false,
|
||||
"do_check_true": false,
|
||||
|
|
@ -21,6 +22,7 @@ module.exports = {
|
|||
"do_get_idle": false,
|
||||
"do_get_profile": false,
|
||||
"do_get_tempdir": false,
|
||||
"do_load_manifest": false,
|
||||
"do_load_module": false,
|
||||
"do_parse_document": false,
|
||||
"do_print": false,
|
||||
|
|
|
|||
Загрузка…
Ссылка в новой задаче