From 71396dced19e1e8d1d44af7ea065c5dcbb6ef0f6 Mon Sep 17 00:00:00 2001 From: Jon Coppeard Date: Fri, 22 May 2020 18:38:30 +0000 Subject: [PATCH] Bug 1636419 - Enable main GC timing telemetry on geckoview r=sfink This adds data for the time taking by the different phases plus slice time. Differential Revision: https://phabricator.services.mozilla.com/D76341 --- toolkit/components/telemetry/Histograms.json | 14 +-- .../geckoview/streaming/metrics.yaml | 107 +++++++++++++++++- 2 files changed, 113 insertions(+), 8 deletions(-) diff --git a/toolkit/components/telemetry/Histograms.json b/toolkit/components/telemetry/Histograms.json index 01f63a4a4a83..a770da0a987c 100644 --- a/toolkit/components/telemetry/Histograms.json +++ b/toolkit/components/telemetry/Histograms.json @@ -725,7 +725,7 @@ }, "GC_PREPARE_MS": { "record_in_processes": ["main", "content"], - "products": ["firefox"], + "products": ["firefox", "geckoview_streaming"], "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org", "jcoppeard@mozilla.com"], "expires_in_version": "never", "releaseChannelCollection": "opt-out", @@ -747,7 +747,7 @@ }, "GC_SWEEP_MS": { "record_in_processes": ["main", "content"], - "products": ["firefox", "fennec", "geckoview"], + "products": ["firefox", "fennec", "geckoview", "geckoview_streaming"], "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"], "expires_in_version": "never", "kind": "exponential", @@ -757,7 +757,7 @@ }, "GC_COMPACT_MS": { "record_in_processes": ["main", "content"], - "products": ["firefox", "fennec", "geckoview"], + "products": ["firefox", "fennec", "geckoview", "geckoview_streaming"], "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"], "expires_in_version": "never", "kind": "exponential", @@ -767,7 +767,7 @@ }, "GC_MARK_ROOTS_MS": { "record_in_processes": ["main", "content"], - "products": ["firefox", "fennec", "geckoview"], + "products": ["firefox", "fennec", "geckoview", "geckoview_streaming"], "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"], "expires_in_version": "81", "kind": "linear", @@ -777,7 +777,7 @@ }, "GC_MARK_ROOTS_US": { "record_in_processes": ["main", "content"], - "products": ["firefox"], + "products": ["firefox", "geckoview_streaming"], "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org", "jcoppeard@mozilla.com"], "expires_in_version": "never", "releaseChannelCollection": "opt-out", @@ -823,7 +823,7 @@ }, "GC_SLICE_MS": { "record_in_processes": ["main", "content"], - "products": ["firefox", "fennec", "geckoview"], + "products": ["firefox", "fennec", "geckoview", "geckoview_streaming"], "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"], "expires_in_version": "never", "kind": "exponential", @@ -916,7 +916,7 @@ }, "GC_MINOR_US": { "record_in_processes": ["main", "content"], - "products": ["firefox", "fennec", "geckoview"], + "products": ["firefox", "fennec", "geckoview", "geckoview_streaming"], "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"], "expires_in_version": "never", "kind": "exponential", diff --git a/toolkit/components/telemetry/geckoview/streaming/metrics.yaml b/toolkit/components/telemetry/geckoview/streaming/metrics.yaml index cd9f11ba9652..3e4bf9b06543 100644 --- a/toolkit/components/telemetry/geckoview/streaming/metrics.yaml +++ b/toolkit/components/telemetry/geckoview/streaming/metrics.yaml @@ -1102,7 +1102,7 @@ javascript.gc: time_unit: millisecond gecko_datapoint: GC_MS description: > - The total time taken by a collection. + The total time taken by a major collection. bugs: - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419 data_reviews: @@ -1111,3 +1111,108 @@ javascript.gc: - dev-telemetry-gc-alerts@mozilla.org - jcoppeard@mozilla.com expires: never + + minor_time: + type: timing_distribution + time_unit: millisecond + gecko_datapoint: GC_MINOR_US + description: > + The time taked by a minor (nursery) collection. + bugs: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419 + data_reviews: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419#c17 + notification_emails: + - dev-telemetry-gc-alerts@mozilla.org + - jcoppeard@mozilla.com + expires: never + + prepare_time: + type: timing_distribution + time_unit: millisecond + gecko_datapoint: GC_PREPARE_MS + description: > + The time spent in the preparation phase. + bugs: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419 + data_reviews: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419#c17 + notification_emails: + - dev-telemetry-gc-alerts@mozilla.org + - jcoppeard@mozilla.com + expires: never + + mark_roots_time: + type: timing_distribution + time_unit: microsecond + gecko_datapoint: GC_MARK_ROOTS_US + description: > + The time spent marking GC roots. + bugs: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419 + data_reviews: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419#c17 + notification_emails: + - dev-telemetry-gc-alerts@mozilla.org + - jcoppeard@mozilla.com + expires: never + + mark_time: + type: timing_distribution + time_unit: millisecond + gecko_datapoint: GC_MARK_MS + description: > + The time spent in the mark phase. + bugs: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419 + data_reviews: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419#c17 + notification_emails: + - dev-telemetry-gc-alerts@mozilla.org + - jcoppeard@mozilla.com + expires: never + + sweep_time: + type: timing_distribution + time_unit: millisecond + gecko_datapoint: GC_SWEEP_MS + description: > + The time spent in the sweep phase. + bugs: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419 + data_reviews: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419#c17 + notification_emails: + - dev-telemetry-gc-alerts@mozilla.org + - jcoppeard@mozilla.com + expires: never + + compact_time: + type: timing_distribution + time_unit: millisecond + gecko_datapoint: GC_COMPACT_MS + description: > + The time spent in the compact phase. + bugs: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419 + data_reviews: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419#c17 + notification_emails: + - dev-telemetry-gc-alerts@mozilla.org + - jcoppeard@mozilla.com + expires: never + + slice_time: + type: timing_distribution + time_unit: millisecond + gecko_datapoint: GC_SLICE_MS + description: > + The time spent running a GC slice. + bugs: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419 + data_reviews: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1636419#c17 + notification_emails: + - dev-telemetry-gc-alerts@mozilla.org + - jcoppeard@mozilla.com + expires: never