From 7159137f7056990fad2aab137004c43b8ed7d1d6 Mon Sep 17 00:00:00 2001 From: Nicolas Chevobbe Date: Fri, 30 Jul 2021 14:41:27 +0000 Subject: [PATCH] Bug 1723133 - [devtools] Rename browser_target_list_* tests into browser_target_command_* . r=jdescottes. Differential Revision: https://phabricator.services.mozilla.com/D121378 --- devtools/shared/commands/commands-factory.js | 2 +- .../legacy-serviceworkers-watcher.js | 2 +- .../shared/commands/target/tests/browser.ini | 28 +++++++++---------- ...e.js => browser_target_command_bfcache.js} | 0 ...browser_target_command_browser_workers.js} | 0 ...es.js => browser_target_command_frames.js} | 0 ...> browser_target_command_getAllTargets.js} | 0 ...owser_target_command_invalid_api_usage.js} | 0 ...s => browser_target_command_preffedoff.js} | 0 ...js => browser_target_command_processes.js} | 0 ...browser_target_command_service_workers.js} | 0 ...get_command_service_workers_navigation.js} | 0 ... browser_target_command_switchToTarget.js} | 0 ... => browser_target_command_tab_workers.js} | 0 ...command_tab_workers_bfcache_navigation.js} | 0 ...ser_target_command_various_descriptors.js} | 0 ...=> browser_target_command_watchTargets.js} | 0 17 files changed, 16 insertions(+), 16 deletions(-) rename devtools/shared/commands/target/tests/{browser_target_list_bfcache.js => browser_target_command_bfcache.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_browser_workers.js => browser_target_command_browser_workers.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_frames.js => browser_target_command_frames.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_getAllTargets.js => browser_target_command_getAllTargets.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_invalid_api_usage.js => browser_target_command_invalid_api_usage.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_preffedoff.js => browser_target_command_preffedoff.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_processes.js => browser_target_command_processes.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_service_workers.js => browser_target_command_service_workers.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_service_workers_navigation.js => browser_target_command_service_workers_navigation.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_switchToTarget.js => browser_target_command_switchToTarget.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_tab_workers.js => browser_target_command_tab_workers.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_tab_workers_bfcache_navigation.js => browser_target_command_tab_workers_bfcache_navigation.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_various_descriptors.js => browser_target_command_various_descriptors.js} (100%) rename devtools/shared/commands/target/tests/{browser_target_list_watchTargets.js => browser_target_command_watchTargets.js} (100%) diff --git a/devtools/shared/commands/commands-factory.js b/devtools/shared/commands/commands-factory.js index b0afcb2ac422..8008d45079d3 100644 --- a/devtools/shared/commands/commands-factory.js +++ b/devtools/shared/commands/commands-factory.js @@ -71,7 +71,7 @@ exports.CommandsFactory = { }, /** - * For now, this method is only used by browser_target_list_various_descriptors.js + * For now, this method is only used by browser_target_command_various_descriptors.js * in order to cover about:debugging codepath, where we connect to remote tabs via * their current outerWindowID. * But: diff --git a/devtools/shared/commands/target/legacy-target-watchers/legacy-serviceworkers-watcher.js b/devtools/shared/commands/target/legacy-target-watchers/legacy-serviceworkers-watcher.js index 661bae0b2bb7..74e5e7ba9970 100644 --- a/devtools/shared/commands/target/legacy-target-watchers/legacy-serviceworkers-watcher.js +++ b/devtools/shared/commands/target/legacy-target-watchers/legacy-serviceworkers-watcher.js @@ -179,7 +179,7 @@ class LegacyServiceWorkersWatcher extends LegacyWorkersWatcher { // has cleaned up its reducers, which happens on "will-navigate". // On the other end, "dom-complete", which is a better mapping of "navigate", is // happening too late (because of resources being throttled), and would cause failures - // in test (like browser_target_list_service_workers_navigation.js), as the new worker + // in test (like browser_target_command_service_workers_navigation.js), as the new worker // target would already be registered at this point, and seen as something that would // need to be destroyed. if (resource.name === "dom-loading") { diff --git a/devtools/shared/commands/target/tests/browser.ini b/devtools/shared/commands/target/tests/browser.ini index 1cb9c121aa9d..aee243ba9786 100644 --- a/devtools/shared/commands/target/tests/browser.ini +++ b/devtools/shared/commands/target/tests/browser.ini @@ -15,22 +15,22 @@ support-files = test_sw_page_worker.js test_worker.js +[browser_target_command_bfcache.js] +[browser_target_command_browser_workers.js] +[browser_target_command_frames.js] +[browser_target_command_getAllTargets.js] +[browser_target_command_invalid_api_usage.js] +[browser_target_command_preffedoff.js] +[browser_target_command_processes.js] [browser_target_command_reload.js] -[browser_target_invalid_api_usage.js] -[browser_target_list_bfcache.js] -[browser_target_list_browser_workers.js] -[browser_target_list_frames.js] -[browser_target_list_getAllTargets.js] -[browser_target_list_preffedoff.js] -[browser_target_list_processes.js] -[browser_target_list_service_workers.js] -[browser_target_list_service_workers_navigation.js] -[browser_target_list_switchToTarget.js] -[browser_target_list_tab_workers.js] -[browser_target_list_tab_workers_bfcache_navigation.js] +[browser_target_command_service_workers.js] +[browser_target_command_service_workers_navigation.js] +[browser_target_command_switchToTarget.js] +[browser_target_command_tab_workers.js] +[browser_target_command_tab_workers_bfcache_navigation.js] skip-if = debug # Bug 1721859 -[browser_target_list_various_descriptors.js] +[browser_target_command_various_descriptors.js] skip-if = os == "linux" && bits == 64 && !debug #Bug 1701056 -[browser_target_list_watchTargets.js] +[browser_target_command_watchTargets.js] [browser_watcher_actor_getter_caching.js] diff --git a/devtools/shared/commands/target/tests/browser_target_list_bfcache.js b/devtools/shared/commands/target/tests/browser_target_command_bfcache.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_bfcache.js rename to devtools/shared/commands/target/tests/browser_target_command_bfcache.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_browser_workers.js b/devtools/shared/commands/target/tests/browser_target_command_browser_workers.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_browser_workers.js rename to devtools/shared/commands/target/tests/browser_target_command_browser_workers.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_frames.js b/devtools/shared/commands/target/tests/browser_target_command_frames.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_frames.js rename to devtools/shared/commands/target/tests/browser_target_command_frames.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_getAllTargets.js b/devtools/shared/commands/target/tests/browser_target_command_getAllTargets.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_getAllTargets.js rename to devtools/shared/commands/target/tests/browser_target_command_getAllTargets.js diff --git a/devtools/shared/commands/target/tests/browser_target_invalid_api_usage.js b/devtools/shared/commands/target/tests/browser_target_command_invalid_api_usage.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_invalid_api_usage.js rename to devtools/shared/commands/target/tests/browser_target_command_invalid_api_usage.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_preffedoff.js b/devtools/shared/commands/target/tests/browser_target_command_preffedoff.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_preffedoff.js rename to devtools/shared/commands/target/tests/browser_target_command_preffedoff.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_processes.js b/devtools/shared/commands/target/tests/browser_target_command_processes.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_processes.js rename to devtools/shared/commands/target/tests/browser_target_command_processes.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_service_workers.js b/devtools/shared/commands/target/tests/browser_target_command_service_workers.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_service_workers.js rename to devtools/shared/commands/target/tests/browser_target_command_service_workers.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_service_workers_navigation.js b/devtools/shared/commands/target/tests/browser_target_command_service_workers_navigation.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_service_workers_navigation.js rename to devtools/shared/commands/target/tests/browser_target_command_service_workers_navigation.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_switchToTarget.js b/devtools/shared/commands/target/tests/browser_target_command_switchToTarget.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_switchToTarget.js rename to devtools/shared/commands/target/tests/browser_target_command_switchToTarget.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_tab_workers.js b/devtools/shared/commands/target/tests/browser_target_command_tab_workers.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_tab_workers.js rename to devtools/shared/commands/target/tests/browser_target_command_tab_workers.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_tab_workers_bfcache_navigation.js b/devtools/shared/commands/target/tests/browser_target_command_tab_workers_bfcache_navigation.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_tab_workers_bfcache_navigation.js rename to devtools/shared/commands/target/tests/browser_target_command_tab_workers_bfcache_navigation.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_various_descriptors.js b/devtools/shared/commands/target/tests/browser_target_command_various_descriptors.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_various_descriptors.js rename to devtools/shared/commands/target/tests/browser_target_command_various_descriptors.js diff --git a/devtools/shared/commands/target/tests/browser_target_list_watchTargets.js b/devtools/shared/commands/target/tests/browser_target_command_watchTargets.js similarity index 100% rename from devtools/shared/commands/target/tests/browser_target_list_watchTargets.js rename to devtools/shared/commands/target/tests/browser_target_command_watchTargets.js