removed bug from deque, and added replaceChar call to string

base/src/nsDeque.cpp

@@ -67,7 +67,9 @@ PRInt32 nsDeque::GetSize(void) const {
  * @return
  */
 nsDeque& nsDeque::Empty() {
-  nsCRT::zero(mData,mCapacity*sizeof(mData));
+  if((0<mCapacity) && (mData)) {
+    nsCRT::zero(mData,mCapacity*sizeof(mData));
+  }
   mSize=0;
   mOrigin=0;
   return *this;

base/src/nsString.cpp

@@ -1400,6 +1400,28 @@ nsString& nsString::StripWhitespace()
   return StripChars("\r\t\n");
 }
 
+/**
+ *  This method is used to replace all occurances of the
+ *  given source char with the given dest char
+ *  
+ *  @param  
+ *  @return *this 
+ */
+nsString& nsString::ReplaceChar(PRUnichar aSourceChar, PRUnichar aDestChar) {
+  PRUnichar* from = mStr;
+  PRUnichar* end = mStr + mLength;
+
+  while (from < end) {
+    PRUnichar ch = *from;
+    if(ch==aSourceChar) {
+      *from = aDestChar;
+    }
+    from++;
+  }
+
+  return *this;
+}
+
 /**
  *  Search for given character within this string.
  *  This method does so by using a binary search,

base/src/nsString.h

@@ -499,6 +499,15 @@ nsString& Cut(PRInt32 anOffset,PRInt32 aCount);
  */
 nsString& StripChars(const char* aSet);
 
+/**
+ *  This method is used to replace all occurances of the
+ *  given source char with the given dest char
+ *  
+ *  @param  
+ *  @return *this 
+ */
+nsString& ReplaceChar(PRUnichar aSourceChar, PRUnichar aDestChar);
+
 /**
  *  This method strips whitespace throughout the string
  *  

string/obsolete/nsString.cpp

@@ -1400,6 +1400,28 @@ nsString& nsString::StripWhitespace()
   return StripChars("\r\t\n");
 }
 
+/**
+ *  This method is used to replace all occurances of the
+ *  given source char with the given dest char
+ *  
+ *  @param  
+ *  @return *this 
+ */
+nsString& nsString::ReplaceChar(PRUnichar aSourceChar, PRUnichar aDestChar) {
+  PRUnichar* from = mStr;
+  PRUnichar* end = mStr + mLength;
+
+  while (from < end) {
+    PRUnichar ch = *from;
+    if(ch==aSourceChar) {
+      *from = aDestChar;
+    }
+    from++;
+  }
+
+  return *this;
+}
+
 /**
  *  Search for given character within this string.
  *  This method does so by using a binary search,

string/obsolete/nsString.h

@@ -499,6 +499,15 @@ nsString& Cut(PRInt32 anOffset,PRInt32 aCount);
  */
 nsString& StripChars(const char* aSet);
 
+/**
+ *  This method is used to replace all occurances of the
+ *  given source char with the given dest char
+ *  
+ *  @param  
+ *  @return *this 
+ */
+nsString& ReplaceChar(PRUnichar aSourceChar, PRUnichar aDestChar);
+
 /**
  *  This method strips whitespace throughout the string
  *  

xpcom/ds/nsDeque.cpp

@@ -67,7 +67,9 @@ PRInt32 nsDeque::GetSize(void) const {
  * @return
  */
 nsDeque& nsDeque::Empty() {
-  nsCRT::zero(mData,mCapacity*sizeof(mData));
+  if((0<mCapacity) && (mData)) {
+    nsCRT::zero(mData,mCapacity*sizeof(mData));
+  }
   mSize=0;
   mOrigin=0;
   return *this;

xpcom/ds/nsString.cpp

@@ -1400,6 +1400,28 @@ nsString& nsString::StripWhitespace()
   return StripChars("\r\t\n");
 }
 
+/**
+ *  This method is used to replace all occurances of the
+ *  given source char with the given dest char
+ *  
+ *  @param  
+ *  @return *this 
+ */
+nsString& nsString::ReplaceChar(PRUnichar aSourceChar, PRUnichar aDestChar) {
+  PRUnichar* from = mStr;
+  PRUnichar* end = mStr + mLength;
+
+  while (from < end) {
+    PRUnichar ch = *from;
+    if(ch==aSourceChar) {
+      *from = aDestChar;
+    }
+    from++;
+  }
+
+  return *this;
+}
+
 /**
  *  Search for given character within this string.
  *  This method does so by using a binary search,

xpcom/ds/nsString.h

@@ -499,6 +499,15 @@ nsString& Cut(PRInt32 anOffset,PRInt32 aCount);
  */
 nsString& StripChars(const char* aSet);
 
+/**
+ *  This method is used to replace all occurances of the
+ *  given source char with the given dest char
+ *  
+ *  @param  
+ *  @return *this 
+ */
+nsString& ReplaceChar(PRUnichar aSourceChar, PRUnichar aDestChar);
+
 /**
  *  This method strips whitespace throughout the string
  *  

xpcom/string/obsolete/nsString.cpp

@@ -1400,6 +1400,28 @@ nsString& nsString::StripWhitespace()
   return StripChars("\r\t\n");
 }
 
+/**
+ *  This method is used to replace all occurances of the
+ *  given source char with the given dest char
+ *  
+ *  @param  
+ *  @return *this 
+ */
+nsString& nsString::ReplaceChar(PRUnichar aSourceChar, PRUnichar aDestChar) {
+  PRUnichar* from = mStr;
+  PRUnichar* end = mStr + mLength;
+
+  while (from < end) {
+    PRUnichar ch = *from;
+    if(ch==aSourceChar) {
+      *from = aDestChar;
+    }
+    from++;
+  }
+
+  return *this;
+}
+
 /**
  *  Search for given character within this string.
  *  This method does so by using a binary search,

xpcom/string/obsolete/nsString.h

@@ -499,6 +499,15 @@ nsString& Cut(PRInt32 anOffset,PRInt32 aCount);
  */
 nsString& StripChars(const char* aSet);
 
+/**
+ *  This method is used to replace all occurances of the
+ *  given source char with the given dest char
+ *  
+ *  @param  
+ *  @return *this 
+ */
+nsString& ReplaceChar(PRUnichar aSourceChar, PRUnichar aDestChar);
+
 /**
  *  This method strips whitespace throughout the string
  *