Bug 1448306: Update checks for BinScope 2014. r=froydnj

build/win32/autobinscope.py

@@ -44,12 +44,36 @@ except KeyError:
   sys.exit(0)
   
 try:    
-  proc = subprocess.Popen([binscope_path, "/target", binary_path,
-    "/output", log_file_path, "/sympath", symbol_path,
-    "/c", "ATLVersionCheck", "/c", "ATLVulnCheck", "/c", "SharedSectionCheck", "/c", "APTCACheck", "/c", "NXCheck",
-    "/c", "GSCheck", "/c", "GSFriendlyInitCheck",
-    "/c", "CompilerVersionCheck", "/c", "SafeSEHCheck", "/c", "SNCheck",
-    "/c", "DBCheck"], stdout=subprocess.PIPE)
+  proc = subprocess.Popen([
+    binscope_path,
+    "/Target", binary_path,
+    "/Output", log_file_path,
+    "/SymPath", symbol_path,
+    "/Checks", "ATLVersionCheck",
+    "/Checks", "ATLVulnCheck",
+    # We do not ship in the Windows Store
+    "/SkippedChecks", "AppContainerCheck",
+    # The CompilerVersionCheck doesn't like clang-cl (we would need to set MinimumCompilerVersion)
+    # But we check the compiler in our build system anyway, so this doesn't seem useful
+    "/SkippedChecks", "CompilerVersionCheck",
+    "/Checks", "DBCheck",
+    "/Checks", "DefaultGSCookieCheck",
+    "/Checks", "ExecutableImportsCheck",
+    # FunctonPointersCheck is disabled per bug 1014002
+    "/SkippedChecks", "FunctionPointersCheck",
+    # GSCheck doesn't know how to deal with Rust libs
+    "/SkippedChecks", "GSCheck",
+    "/Checks", "GSFriendlyInitCheck",
+    # We are not safebuffers-clean, bug 1449951
+    "/SkippedChecks", "GSFunctionSafeBuffersCheck",
+    "/Checks", "HighEntropyVACheck",
+    "/Checks", "NXCheck",
+    "/Checks", "RSA32Check",
+    "/Checks", "SafeSEHCheck",
+    "/Checks", "SharedSectionCheck",
+    "/Checks", "VB6Check",
+    "/Checks", "WXCheck"
+    ], stdout=subprocess.PIPE)
 
 except WindowsError, (errno, strerror): 
   if errno != 2 and errno != 3: