зеркало из https://github.com/mozilla/gecko-dev.git
Bug 391514 - Login Manager gets confused with password/PIN on usaa.com. r=gavin
This commit is contained in:
Родитель
1359bb6e2c
Коммит
7383100143
|
@ -913,10 +913,11 @@ LoginManager.prototype = {
|
|||
// Only the actionOrigin might be changing, so if it's the same
|
||||
// as the last form on the page we can reuse the same logins.
|
||||
if (actionOrigin != previousActionOrigin) {
|
||||
var logins =
|
||||
var foundLogins =
|
||||
this.findLogins({}, formOrigin, actionOrigin, null);
|
||||
|
||||
this.log("form[" + i + "]: got " + logins.length + " logins.");
|
||||
this.log("form[" + i + "]: got " +
|
||||
foundLogins.length + " logins.");
|
||||
|
||||
previousActionOrigin = actionOrigin;
|
||||
} else {
|
||||
|
@ -924,6 +925,29 @@ LoginManager.prototype = {
|
|||
}
|
||||
|
||||
|
||||
// Discard logins which have username/password values that don't
|
||||
// fit into the fields (as specified by the maxlength attribute).
|
||||
// The user couldn't enter these values anyway, and it helps
|
||||
// with sites that have an extra PIN to be entered (bug 391514)
|
||||
var maxUsernameLen = Number.MAX_VALUE;
|
||||
var maxPasswordLen = Number.MAX_VALUE;
|
||||
|
||||
// If attribute wasn't set, default is -1.
|
||||
if (usernameField && usernameField.maxLength >= 0)
|
||||
maxUsernameLen = usernameField.maxLength;
|
||||
if (passwordField.maxLength >= 0)
|
||||
maxPasswordLen = passwordField.maxLength;
|
||||
|
||||
logins = foundLogins.filter(function (l) {
|
||||
var fit = (l.username.length <= maxUsernameLen &&
|
||||
l.password.length <= maxPasswordLen);
|
||||
if (!fit)
|
||||
this.log("Ignored " + l.username + " login: won't fit");
|
||||
|
||||
return fit;
|
||||
}, this);
|
||||
|
||||
|
||||
// Nothing to do if we have no matching logins available.
|
||||
if (logins.length == 0)
|
||||
continue;
|
||||
|
@ -943,13 +967,13 @@ LoginManager.prototype = {
|
|||
if (usernameField && usernameField.value) {
|
||||
var username = usernameField.value;
|
||||
|
||||
var foundLogin;
|
||||
var matchingLogin;
|
||||
var found = logins.some(function(l) {
|
||||
foundLogin = l;
|
||||
matchingLogin = l;
|
||||
return (l.username == username);
|
||||
});
|
||||
if (found)
|
||||
passwordField.value = foundLogin.password;
|
||||
passwordField.value = matchingLogin.password;
|
||||
|
||||
} else if (logins.length == 1) {
|
||||
if (usernameField)
|
||||
|
|
|
@ -61,6 +61,7 @@ MOCHI_TESTS = \
|
|||
test_bug_242956.html \
|
||||
test_bug_360493_1.html \
|
||||
test_bug_360493_2.html \
|
||||
test_bug_391514.html \
|
||||
$(NULL)
|
||||
|
||||
XPCSHELL_TESTS = unit
|
||||
|
|
|
@ -0,0 +1,139 @@
|
|||
<!DOCTYPE HTML>
|
||||
<html>
|
||||
<head>
|
||||
<title>Test for Login Manager</title>
|
||||
<script type="text/javascript" src="/MochiKit/MochiKit.js"></script>
|
||||
<script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
|
||||
<script type="text/javascript" src="pwmgr_common.js"></script>
|
||||
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
|
||||
</head>
|
||||
<body>
|
||||
Login Manager test: 391514
|
||||
<p id="display"></p>
|
||||
<div id="content" style="display: none">
|
||||
<!-- normal form. -->
|
||||
<form id="form1" action="formtest.js">
|
||||
<input type="text" name="uname">
|
||||
<input type="password" name="pword">
|
||||
|
||||
<button type="submit">Submit</button>
|
||||
<button type="reset"> Reset </button>
|
||||
</form>
|
||||
|
||||
<!-- limited username -->
|
||||
<form id="form2" action="formtest.js">
|
||||
<input type="text" name="uname" maxlength="4">
|
||||
<input type="password" name="pword">
|
||||
</form>
|
||||
|
||||
<!-- limited password -->
|
||||
<form id="form3" action="formtest.js">
|
||||
<input type="text" name="uname">
|
||||
<input type="password" name="pword" maxlength="4">
|
||||
</form>
|
||||
|
||||
<!-- limited username and password -->
|
||||
<form id="form4" action="formtest.js">
|
||||
<input type="text" name="uname" maxlength="4">
|
||||
<input type="password" name="pword" maxlength="4">
|
||||
</form>
|
||||
|
||||
|
||||
<!-- limited username -->
|
||||
<form id="form5" action="formtest.js">
|
||||
<input type="text" name="uname" maxlength="0">
|
||||
<input type="password" name="pword">
|
||||
</form>
|
||||
|
||||
<!-- limited password -->
|
||||
<form id="form6" action="formtest.js">
|
||||
<input type="text" name="uname">
|
||||
<input type="password" name="pword" maxlength="0">
|
||||
</form>
|
||||
|
||||
<!-- limited username and password -->
|
||||
<form id="form7" action="formtest.js">
|
||||
<input type="text" name="uname" maxlength="0">
|
||||
<input type="password" name="pword" maxlength="0">
|
||||
</form>
|
||||
|
||||
|
||||
<!-- limited, but ok, username -->
|
||||
<form id="form8" action="formtest.js">
|
||||
<input type="text" name="uname" maxlength="999">
|
||||
<input type="password" name="pword">
|
||||
</form>
|
||||
|
||||
<!-- limited, but ok, password -->
|
||||
<form id="form9" action="formtest.js">
|
||||
<input type="text" name="uname">
|
||||
<input type="password" name="pword" maxlength="999">
|
||||
</form>
|
||||
|
||||
<!-- limited, but ok, username and password -->
|
||||
<form id="form10" action="formtest.js">
|
||||
<input type="text" name="uname" maxlength="999">
|
||||
<input type="password" name="pword" maxlength="999">
|
||||
</form>
|
||||
|
||||
|
||||
<!-- limited, but ok, username -->
|
||||
<!-- (note that filled values are exactly 8 characters) -->
|
||||
<form id="form11" action="formtest.js">
|
||||
<input type="text" name="uname" maxlength="8">
|
||||
<input type="password" name="pword">
|
||||
</form>
|
||||
|
||||
<!-- limited, but ok, password -->
|
||||
<!-- (note that filled values are exactly 8 characters) -->
|
||||
<form id="form12" action="formtest.js">
|
||||
<input type="text" name="uname">
|
||||
<input type="password" name="pword" maxlength="8">
|
||||
</form>
|
||||
|
||||
<!-- limited, but ok, username and password -->
|
||||
<!-- (note that filled values are exactly 8 characters) -->
|
||||
<form id="form13" action="formtest.js">
|
||||
<input type="text" name="uname" maxlength="8">
|
||||
<input type="password" name="pword" maxlength="8">
|
||||
</form>
|
||||
|
||||
</div>
|
||||
<pre id="test">
|
||||
<script class="testbody" type="text/javascript">
|
||||
|
||||
/* Test for Login Manager: 391514 (Login Manager gets confused with
|
||||
* password/PIN on usaa.com)
|
||||
*/
|
||||
|
||||
function startTest() {
|
||||
var i;
|
||||
|
||||
is($_(1, "uname").value, "testuser", "Checking for filled username 1");
|
||||
is($_(1, "pword").value, "testpass", "Checking for filled password 1");
|
||||
|
||||
for (i = 2; i < 8; i++) {
|
||||
is($_(i, "uname").value, "", "Checking for unfilled username " + i);
|
||||
is($_(i, "pword").value, "", "Checking for unfilled password " + i);
|
||||
}
|
||||
|
||||
for (i = 8; i < 14; i++) {
|
||||
is($_(i, "uname").value, "testuser", "Checking for filled username " + i);
|
||||
is($_(i, "pword").value, "testpass", "Checking for filled password " + i);
|
||||
}
|
||||
|
||||
// Note that tests 11-13 are limited to exactly the expected value.
|
||||
// Assert this lest someone change the login we're testing with.
|
||||
is($_(11, "uname").value.length, 8, "asserting test assumption is valid.");
|
||||
|
||||
SimpleTest.finish();
|
||||
}
|
||||
|
||||
window.onload = startTest;
|
||||
|
||||
SimpleTest.waitForExplicitFinish();
|
||||
|
||||
</script>
|
||||
</pre>
|
||||
</body>
|
||||
</html>
|
Загрузка…
Ссылка в новой задаче