Bug 972405 - Make the bookmarks panel look like all the other sub-panels. ui-r=shorlander, r=dao

browser/base/content/browser.xul

@@ -776,7 +776,7 @@
                        cui-areatype="toolbar"
                        oncommand="BookmarkingUI.onCommand(event);">
           <menupopup id="BMB_bookmarksPopup"
-                     class="cui-widget-panel cui-widget-panelview cui-widget-panelWithFooter"
+                     class="cui-widget-panel cui-widget-panelview cui-widget-panelWithFooter PanelUI-subView"
                      placespopup="true"
                      context="placesContext"
                      openInTabs="children"

browser/themes/osx/customizableui/panelUIOverlay.css

@@ -89,3 +89,8 @@
 .cui-widget-panelview menuseparator {
   padding: 0 !important;
 }
+
+.PanelUI-subView menuitem[checked="true"]::before,
+.PanelUI-subView toolbarbutton[checked="true"]::before {
+  margin: 0 5px;
+}

browser/themes/shared/customizableui/panelUIOverlay.inc.css

@@ -84,6 +84,7 @@
 
 .cui-widget-panelview .subviewbutton.panel-subview-footer {
   margin: 4px 0 0;
+  -moz-box-pack: center;
 }
 
 #PanelUI-mainView {
@@ -549,7 +550,8 @@ panelview .toolbarbutton-1,
 .subviewbutton.panel-subview-footer > .toolbarbutton-text,
 .subviewbutton.panel-subview-footer > .menu-text {
   -moz-padding-start: 0;
-  text-align: center;
+  -moz-padding-end: 12px;
+  -moz-box-flex: 0;
 }
 
 .subviewbutton:not(.panel-subview-footer) {

browser/themes/windows/customizableui/panelUIOverlay.css

@@ -35,6 +35,11 @@
   padding: 0 6px;
 }
 
+#BMB_bookmarksPopup menuitem[checked="true"]::before,
+#BMB_bookmarksPopup toolbarbutton[checked="true"]::before {
+  margin: 0 9px;
+}
+
 %ifdef WINDOWS_AERO
 /* Win8 and beyond. */
 @media not all and (-moz-os-version: windows-vista) {

toolkit/content/widgets/menu.xml

@@ -169,7 +169,7 @@
   <binding id="menu"
            extends="chrome://global/content/bindings/menu.xml#menu-base">
     <content>
-      <xul:label class="menu-text" flex="1" xbl:inherits="value=label,accesskey,crop" crop="right"/>
+      <xul:label class="menu-text" xbl:inherits="value=label,accesskey,crop" crop="right"/>
       <xul:hbox class="menu-accel-container" anonid="accel">
         <xul:label class="menu-accel" xbl:inherits="value=acceltext"/>
       </xul:hbox>
@@ -182,7 +182,7 @@
 
   <binding id="menuitem" extends="chrome://global/content/bindings/menu.xml#menuitem-base">
     <content>
-      <xul:label class="menu-text" flex="1" xbl:inherits="value=label,accesskey,crop" crop="right"/>
+      <xul:label class="menu-text" xbl:inherits="value=label,accesskey,crop" crop="right"/>
       <xul:hbox class="menu-accel-container" anonid="accel">
         <xul:label class="menu-accel" xbl:inherits="value=acceltext"/>
       </xul:hbox>

toolkit/content/xul.css

@@ -369,6 +369,10 @@ menuitem.menuitem-non-iconic {
   -moz-binding: url("chrome://global/content/bindings/menu.xml#menubutton-item");
 }
 
+.menu-text {
+  -moz-box-flex: 1;
+}
+
 %ifdef MOZ_WIDGET_GTK
 /********* detection of system setting to use icons in menus ***********/
 @media not all and (-moz-images-in-menus) {