Add null checks to some DOM methods. Bug 234331, r+sr=jst

content/base/src/nsDocument.cpp

@@ -2376,7 +2376,7 @@ nsDocument::ImportNode(nsIDOMNode* aImportedNode,
                        nsIDOMNode** aReturn)
 {
   NS_ENSURE_ARG(aImportedNode);
-  NS_ENSURE_ARG_POINTER(aReturn);
+  NS_PRECONDITION(aReturn, "Null out param!");
 
   nsresult rv = nsContentUtils::CheckSameOrigin(this, aImportedNode);
   if (NS_FAILED(rv)) {
@@ -2389,6 +2389,8 @@ nsDocument::ImportNode(nsIDOMNode* aImportedNode,
 NS_IMETHODIMP
 nsDocument::AddBinding(nsIDOMElement* aContent, const nsAString& aURI)
 {
+  NS_ENSURE_ARG(aContent);
+  
   nsresult rv = nsContentUtils::CheckSameOrigin(this, aContent);
   if (NS_FAILED(rv)) {
     return rv;
@@ -2404,6 +2406,8 @@ nsDocument::AddBinding(nsIDOMElement* aContent, const nsAString& aURI)
 NS_IMETHODIMP
 nsDocument::RemoveBinding(nsIDOMElement* aContent, const nsAString& aURI)
 {
+  NS_ENSURE_ARG(aContent);
+
   nsresult rv = nsContentUtils::CheckSameOrigin(this, aContent);
   if (NS_FAILED(rv)) {
     return rv;
@@ -2662,6 +2666,8 @@ nsDocument::SetTitle(const nsAString& aTitle)
 NS_IMETHODIMP
 nsDocument::GetBoxObjectFor(nsIDOMElement* aElement, nsIBoxObject** aResult)
 {
+  NS_ENSURE_ARG(aElement);
+  
   nsresult rv;
 
   *aResult = nsnull;

content/xul/document/src/nsXULDocument.cpp

@@ -866,6 +866,8 @@ nsXULDocument::AddBroadcastListenerFor(nsIDOMElement* aBroadcaster,
                                        nsIDOMElement* aListener,
                                        const nsAString& aAttr)
 {
+    NS_ENSURE_ARG(aBroadcaster && aListener);
+    
     nsresult rv =
         nsContentUtils::CheckSameOrigin(NS_STATIC_CAST(nsDocument *, this),
                                         aBroadcaster);