Bug 1309796 - add eslint support for netmonitor; r=Honza

MozReview-Commit-ID: DdAl3HgzhxM

--HG--
extra : rebase_source : a99e7c19aff48454a86ec6dce87a5084583b8f5d

devtools/client/netmonitor/.eslintrc

@@ -0,0 +1,12 @@
+{
+  // Extend from the devtools eslintrc.
+  "extends": "../../.eslintrc",
+
+  "rules": {
+    // The netmonitor is being migrated to HTML and cleaned of
+    // chrome-privileged code, so this rule disallows requiring chrome
+    // code. Some files in the netmonitor disable this rule still. The
+    // goal is to enable the rule globally on all files.
+    "mozilla/reject-some-requires": [2, "^(chrome|chrome:.*|resource:.*|devtools/server/.*|.*\\.jsm|devtools/shared/platform/(chome|content)/.*)$"],
+  },
+}

devtools/client/netmonitor/har/har-automation.js

@@ -2,7 +2,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 "use strict";
-
+/* eslint-disable mozilla/reject-some-requires */
 const { Ci } = require("chrome");
 const { Class } = require("sdk/core/heritage");
 const { resolve } = require("promise");

devtools/client/netmonitor/har/har-exporter.js

@@ -3,9 +3,10 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 "use strict";
-
+/* eslint-disable mozilla/reject-some-requires */
 const { Cc, Ci } = require("chrome");
 const Services = require("Services");
+/* eslint-disable mozilla/reject-some-requires */
 const { XPCOMUtils } = require("resource://gre/modules/XPCOMUtils.jsm");
 const { resolve } = require("promise");
 const { HarUtils } = require("./har-utils.js");

devtools/client/netmonitor/har/har-utils.js

@@ -3,8 +3,9 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 "use strict";
-
+/* eslint-disable mozilla/reject-some-requires */
 const { Ci, Cc, CC } = require("chrome");
+/* eslint-disable mozilla/reject-some-requires */
 const { XPCOMUtils } = require("resource://gre/modules/XPCOMUtils.jsm");
 
 XPCOMUtils.defineLazyGetter(this, "dirService", function () {

devtools/client/netmonitor/netmonitor-controller.js

@@ -35,6 +35,7 @@ var { loader, require } = BrowserLoaderModule.BrowserLoader({
 
 const promise = require("promise");
 const Services = require("Services");
+/* eslint-disable mozilla/reject-some-requires */
 const {XPCOMUtils} = require("resource://gre/modules/XPCOMUtils.jsm");
 const EventEmitter = require("devtools/shared/event-emitter");
 const Editor = require("devtools/client/sourceeditor/editor");

devtools/client/netmonitor/netmonitor-view.js

@@ -12,7 +12,9 @@ XPCOMUtils.defineLazyGetter(this, "NetworkHelper", function () {
   return require("devtools/shared/webconsole/network-helper");
 });
 
+/* eslint-disable mozilla/reject-some-requires */
 const {VariablesView} = require("resource://devtools/client/shared/widgets/VariablesView.jsm");
+/* eslint-disable mozilla/reject-some-requires */
 const {VariablesViewController} = require("resource://devtools/client/shared/widgets/VariablesViewController.jsm");
 const {ToolSidebar} = require("devtools/client/framework/sidebar");
 const {testing: isTesting} = require("devtools/shared/flags");

devtools/client/netmonitor/request-utils.js

@@ -1,5 +1,5 @@
 "use strict";
-
+/* eslint-disable mozilla/reject-some-requires */
 const { Ci } = require("chrome");
 const { KeyCodes } = require("devtools/client/shared/keycodes");
 const { Task } = require("devtools/shared/task");

devtools/client/netmonitor/requests-menu-view.js

@@ -1,11 +1,12 @@
 /* globals document, window, dumpn, $, $all, gNetwork, EVENTS, Prefs,
            NetMonitorController, NetMonitorView */
 "use strict";
-
+/* eslint-disable mozilla/reject-some-requires */
 const { Cc, Ci, Cu } = require("chrome");
 const Services = require("Services");
 const {Task} = require("devtools/shared/task");
 const {DeferredTask} = Cu.import("resource://gre/modules/DeferredTask.jsm", {});
+/* eslint-disable mozilla/reject-some-requires */
 const {SideMenuWidget} = require("resource://devtools/client/shared/widgets/SideMenuWidget.jsm");
 const {HTMLTooltip} = require("devtools/client/shared/widgets/tooltip/HTMLTooltip");
 const {setImageTooltip, getImageDimensions} =