Backed out changeset 6f10ab027992 (bug 1737498) for causing failures at browser_library_open_all_with_separator.js. CLOSED TREE

browser/components/places/content/placesContextMenu.inc.xhtml

@@ -21,7 +21,7 @@
             oncommand="PlacesUIUtils.openSelectionInTabs(event);"
             data-l10n-id="places-open-all-bookmarks"
             selection-type="multiple"
-            node-type="link_bookmark|separator"/>
+            node-type="link_bookmark"/>
   <menuitem id="placesContext_open:newtab"
             command="placesCmd_open:tab"
             data-l10n-id="places-open-in-tab"

browser/components/places/tests/browser/browser.ini

@@ -105,7 +105,6 @@ skip-if = os == "linux" && (tsan || asan) # Bug 1714384
 [browser_library_new_bookmark.js]
 [browser_library_open_leak.js]
 [browser_library_openFlatContainer.js]
-[browser_library_open_all_with_separator.js]
 [browser_library_open_all.js]
 [browser_library_open_bookmark.js]
 [browser_library_panel_leak.js]

browser/components/places/tests/browser/browser_library_open_all_with_separator.js

@@ -1,61 +0,0 @@
-/* Any copyright is dedicated to the Public Domain.
- * http://creativecommons.org/publicdomain/zero/1.0/
- */
-
-add_task(async function setup() {
-  await PlacesUtils.bookmarks.eraseEverything();
-
-  await PlacesUtils.bookmarks.insertTree({
-    guid: PlacesUtils.bookmarks.toolbarGuid,
-    children: [
-      {
-        title: "Google",
-        url: "https://www.google.com/",
-      },
-      {
-        type: PlacesUtils.bookmarks.TYPE_SEPARATOR,
-      },
-      {
-        title: "Yandex",
-        url: "https://www.yandex.com/",
-      },
-    ],
-  });
-
-  registerCleanupFunction(async function() {
-    await PlacesUtils.bookmarks.eraseEverything();
-  });
-});
-
-add_task(async function test_open_all_without_separator() {
-  let gLibrary = await promiseLibrary("AllBookmarks");
-  gLibrary.PlacesOrganizer.selectLeftPaneBuiltIn("BookmarksToolbar");
-  gLibrary.ContentTree.view.selectAll();
-
-  let placesContext = gLibrary.document.getElementById("placesContext");
-  let promiseContextMenu = BrowserTestUtils.waitForEvent(
-    placesContext,
-    "popupshown"
-  );
-  synthesizeClickOnSelectedTreeCell(gLibrary.ContentTree.view, {
-    button: 2,
-    type: "contextmenu",
-  });
-  await promiseContextMenu;
-
-  let openTabs = gLibrary.document.getElementById(
-    "placesContext_openBookmarkLinks:tabs"
-  );
-  let promiseWaitForWindow = BrowserTestUtils.waitForNewWindow();
-  placesContext.activateItem(openTabs, { shiftKey: true });
-  let newWindow = await promiseWaitForWindow;
-
-  Assert.equal(
-    newWindow.browserDOMWindow.tabCount,
-    2,
-    "Expected number of tabs opened in new window"
-  );
-
-  await BrowserTestUtils.closeWindow(newWindow);
-  await promiseLibraryClosed(gLibrary);
-});