bug 829288 - fix some toolkit/ warnings r=ehsan

toolkit/components/commandlines/nsCommandLine.cpp

@@ -445,7 +445,6 @@ NS_IMETHODIMP
 nsCommandLine::Init(int32_t argc, const char* const* argv, nsIFile* aWorkingDir,
                     uint32_t aState)
 {
-  NS_ENSURE_ARG_MIN(aState, 0);
   NS_ENSURE_ARG_MAX(aState, 2);
 
   int32_t i;

toolkit/components/ctypes/ctypes.cpp

@@ -120,7 +120,6 @@ Module::Call(nsIXPConnectWrappedNative* wrapper,
              jsval* vp,
              bool* _retval)
 {
-  bool reusingGlobal = Preferences::GetBool("jsloader.reuseGlobal");
   JSObject* targetObj = nullptr;
 
   mozJSComponentLoader* loader = mozJSComponentLoader::Get();

toolkit/components/telemetry/Telemetry.cpp

@@ -140,7 +140,7 @@ CombinedStacks::AddStack(const Telemetry::ProcessedStack& aStack) {
   CombinedStacks::Stack& adjustedStack = mStacks.back();
 
   size_t stackSize = aStack.GetStackSize();
-  for (int i = 0; i < stackSize; ++i) {
+  for (size_t i = 0; i < stackSize; ++i) {
     const Telemetry::ProcessedStack::Frame& frame = aStack.GetFrame(i);
     uint16_t modIndex;
     if (frame.mModIndex == std::numeric_limits<uint16_t>::max()) {

toolkit/system/windowsproxy/nsWindowsSystemProxySettings.cpp

@@ -7,6 +7,7 @@
 #include <ras.h>
 #include <wininet.h>
 
+#include "mozilla/Attributes.h"
 #include "mozilla/Util.h"
 #include "nsISystemProxySettings.h"
 #include "nsIServiceManager.h"
@@ -16,7 +17,7 @@
 #include "nsISupportsPrimitives.h"
 #include "nsIURI.h"
 
-class nsWindowsSystemProxySettings : public nsISystemProxySettings
+class nsWindowsSystemProxySettings MOZ_FINAL : public nsISystemProxySettings
 {
 public:
     NS_DECL_ISUPPORTS

toolkit/xre/nsNativeAppSupportWin.cpp

@@ -49,6 +49,8 @@
 #include <direct.h>
 #include <fcntl.h>
 
+using namespace mozilla;
+
 static HWND hwndForDOMWindow( nsISupports * );
 
 static
@@ -1473,7 +1475,7 @@ SafeJSContext::SafeJSContext() : mContext(nullptr) {
 
 SafeJSContext::~SafeJSContext() {
   JSContext *cx;
-  nsresult   rv;
+  DebugOnly<nsresult> rv;
 
   if(mContext) {
     rv = mService->Pop(&cx);