Bug 269927 Tooltip appears after closing tab (even after switching windows) (and doesn't go away easily)

patch by martijn.martijn@gmail.com r=bryner sr=bz a=bsmedberg

layout/xul/base/src/nsXULTooltipListener.cpp

@@ -109,6 +109,14 @@ nsXULTooltipListener::MouseDown(nsIDOMEvent* aMouseEvent)
   return NS_OK;
 }
 
+NS_IMETHODIMP
+nsXULTooltipListener::MouseUp(nsIDOMEvent* aMouseEvent)
+{
+  HideTooltip();
+
+  return NS_OK;
+}
+
 NS_IMETHODIMP
 nsXULTooltipListener::MouseOut(nsIDOMEvent* aMouseEvent)
 {
@@ -416,7 +424,7 @@ nsXULTooltipListener::ShowTooltip()
       evtTarget->AddEventListener(NS_LITERAL_STRING("popuphiding"), 
                                   (nsIDOMMouseListener*)this, PR_FALSE);
 
-      // listen for mousedown,keydown, and DOMMouseScroll events at document level
+      // listen for mousedown, mouseup, keydown, and DOMMouseScroll events at document level
       nsIDocument* doc = mSourceNode->GetDocument();
       if (doc) {
         evtTarget = do_QueryInterface(doc);
@@ -424,6 +432,8 @@ nsXULTooltipListener::ShowTooltip()
                                     (nsIDOMMouseListener*)this, PR_TRUE);
         evtTarget->AddEventListener(NS_LITERAL_STRING("mousedown"), 
                                     (nsIDOMMouseListener*)this, PR_TRUE);
+        evtTarget->AddEventListener(NS_LITERAL_STRING("mouseup"), 
+                                    (nsIDOMMouseListener*)this, PR_TRUE);                                    
         evtTarget->AddEventListener(NS_LITERAL_STRING("keydown"), 
                                     (nsIDOMMouseListener*)this, PR_TRUE);
       }
@@ -646,6 +656,7 @@ nsXULTooltipListener::DestroyTooltip()
       nsCOMPtr<nsIDOMEventTarget> evtTarget(do_QueryInterface(doc));
       evtTarget->RemoveEventListener(NS_LITERAL_STRING("DOMMouseScroll"), (nsIDOMMouseListener*)this, PR_TRUE);
       evtTarget->RemoveEventListener(NS_LITERAL_STRING("mousedown"), (nsIDOMMouseListener*)this, PR_TRUE);
+      evtTarget->RemoveEventListener(NS_LITERAL_STRING("mouseup"), (nsIDOMMouseListener*)this, PR_TRUE);
       evtTarget->RemoveEventListener(NS_LITERAL_STRING("keydown"), (nsIDOMMouseListener*)this, PR_TRUE);
     }
 

layout/xul/base/src/nsXULTooltipListener.h

@@ -69,7 +69,7 @@ public:
 
   // nsIDOMMouseListener
   NS_IMETHOD MouseDown(nsIDOMEvent* aMouseEvent);
-  NS_IMETHOD MouseUp(nsIDOMEvent* aMouseEvent) { return NS_OK; };
+  NS_IMETHOD MouseUp(nsIDOMEvent* aMouseEvent);
   NS_IMETHOD MouseClick(nsIDOMEvent* aMouseEvent) { return NS_OK; };
   NS_IMETHOD MouseDblClick(nsIDOMEvent* aMouseEvent) { return NS_OK; };
   NS_IMETHOD MouseOver(nsIDOMEvent* aMouseEvent) { return NS_OK; };