mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1559069 [wpt PR 17310] - Remove expansion of backdrop-filter input for pixel-moving filters, a=testonly 

Automatic update from web-platform-tests
Remove expansion of backdrop-filter input for pixel-moving filters

See [1] for the PR for the spec change. Essentially, with this CL,
the input to the filter will be the bounding box of the element
with backdrop-filter. The bounds will not be expanded for pixel-
moving filters, and will not include extra border for children.

Note that the rebaselined layout tests are all for very small
single-pixel errors, except for backdrop_filter_blur_outsets.png
and backdrop-filter-boundary-expected.png, which change because
of this new behavior.

This needs a (small) spec change, but it will be beneficial in
these four ways:
 - It agrees more closely with existing Safari behavior.
 - It improves performance, by filtering fewer pixels in the
   case of pixel-moving filters.
 - Developers have been disappointed with the existing behavior
   of bringing in pixels from outside the bounds of the
   element, and have requested a way to turn this behavior off.
   See the discussion starting at [2].
 - It eliminates the problem of crbug.com/972173, where content
   outside the renderer viewport can get dragged into the filter.

[1] https://github.com/w3c/fxtf-drafts/pull/342
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=497522#c196

Bug: 972173,497522
Change-Id: I18cc6d08cf9fde263b9e166b5e96ea57a1c41973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650418
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668894}

--

wpt-commits: b90e70c4557b94ca735e6c8b20958c77ef02306e
wpt-pr: 17310
This commit is contained in:
Mason Freed 2019-07-19 11:37:39 +00:00 коммит произвёл James Graham
Родитель d8040d8276
Коммит 76639adadf
1 изменённых файлов: 62 добавлений и 0 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

62
testing/web-platform/tests/css/filter-effects/backdrop-filter-edge-clipping.html Normal file
Просмотреть файл

@ -0,0 +1,62 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>backdrop-filter: Filter input is at element bounds</title>
<link rel="author" title="Mason Freed" href="mailto:masonfreed@chromium.org">
<link rel="help" href="https://drafts.fxtf.org/filter-effects-2/#BackdropFilterProperty">
<link rel="match" href="backdrop-filter-paint-order-ref.html">
<div>
<p>Expected: A pure white box with a blue border, surrounded by green.<br>
No green should be observed within the white box.<br>
No dark/black should be observed within the white box either.</p>
</div>
<div class="greenbox top"></div>
<div class="greenbox right"></div>
<div class="greenbox bottom"></div>
<div class="filterbox">
<div class="children" style="top:-31px;left:35px;"></div>
<div class="children" style="top:101px;left:35px;"></div>
<div class="children" style="top:35px;left:101px;"></div>
<div class="children" style="top:35px;left:-31px;"></div>
</div>
<style>
.filterbox {
position: absolute;
width: 100px;
height: 100px;
top: 150px;
left: 0px;
border: 1px solid blue;
backdrop-filter: blur(20px);
}
.greenbox {
position:absolute;
width: 150px;
height: 50px;
background: green;
}
.top {
top:100px;
left: 10px;
}
.right {
top:130px;
left: 102px;
width: 58px;
height: 150px;
}
.bottom {
top:252px;
left: 10px;
}
.children {
position: absolute;
width: 30px;
height: 30px;
top: 0px;
left: 0px;
background: green;
}
</style>