Bug 1440333 - Part 2 - Rename the "current" attribute to "visible". r=Gijs

MozReview-Commit-ID: EazXDT6JC3M

--HG--
extra : rebase_source : 5cca4cd0cf565ffbdf75a9777dfc15b359dcda57
This commit is contained in:
Paolo Amadini 2018-02-23 15:54:08 +00:00
Родитель 337d163883
Коммит 76ef799b86
6 изменённых файлов: 9 добавлений и 9 удалений

Просмотреть файл

@ -87,7 +87,7 @@ panelview {
-moz-box-orient: vertical;
}
panelview:not([current]) {
panelview:not([visible]) {
visibility: collapse;
}

Просмотреть файл

@ -1171,9 +1171,9 @@ var PanelView = class extends this.AssociatedToNode {
set visible(value) {
if (value) {
this.node.setAttribute("current", true);
this.node.setAttribute("visible", true);
} else {
this.node.removeAttribute("current");
this.node.removeAttribute("visible");
}
}

Просмотреть файл

@ -28,7 +28,7 @@ add_task(async function() {
let promise = BrowserTestUtils.waitForEvent(historyPanel, "ViewShown");
historyButton.click();
await promise;
ok(historyPanel.getAttribute("current"), "History Panel is in view");
ok(historyPanel.getAttribute("visible"), "History Panel is in view");
let browserLoaded = BrowserTestUtils.browserLoaded(tab.linkedBrowser);
let panelHiddenPromise = promiseOverflowHidden(window);

Просмотреть файл

@ -37,7 +37,7 @@ add_task(async function() {
charEncodingButton.click();
await subviewShownPromise;
ok(characterEncodingView.hasAttribute("current"), "The Character encoding panel is displayed");
ok(characterEncodingView.hasAttribute("visible"), "The Character encoding panel is displayed");
let pinnedEncodings = document.getElementById("PanelUI-characterEncodingView-pinned");
let charsetsList = document.getElementById("PanelUI-characterEncodingView-charsets");

Просмотреть файл

@ -38,7 +38,7 @@ add_task(async function testSyncRemoteTabsButtonFunctionality() {
// click the button - the panel should open.
syncRemoteTabsBtn.click();
await viewShown;
ok(remoteTabsPanel.getAttribute("current"), "Sync Panel is in view");
ok(remoteTabsPanel.getAttribute("visible"), "Sync Panel is in view");
// Find and click the "setup" button.
let syncNowButton = document.getElementById("PanelUI-remotetabs-syncnow");

Просмотреть файл

@ -86,7 +86,7 @@ async function openPrefsFromMenuPanel(expectedPanelId, entryPoint) {
let viewShownPromise = BrowserTestUtils.waitForEvent(syncPanel, "ViewShown");
syncButton.click();
await Promise.all([tabsUpdatedPromise, viewShownPromise]);
ok(syncPanel.getAttribute("current"), "Sync Panel is in view");
ok(syncPanel.getAttribute("visible"), "Sync Panel is in view");
// Sync is not configured - verify that state is reflected.
let subpanel = document.getElementById(expectedPanelId);
@ -187,7 +187,7 @@ add_task(async function() {
let syncButton = document.getElementById("sync-button");
syncButton.click();
await Promise.all([tabsUpdatedPromise, viewShownPromise]);
ok(syncPanel.getAttribute("current"), "Sync Panel is in view");
ok(syncPanel.getAttribute("visible"), "Sync Panel is in view");
let subpanel = document.getElementById("PanelUI-remotetabs-main");
ok(!subpanel.hidden, "main pane is visible");
@ -352,7 +352,7 @@ add_task(async function() {
await Promise.all([tabsUpdatedPromise, viewShownPromise]);
// Check pre-conditions
ok(syncPanel.getAttribute("current"), "Sync Panel is in view");
ok(syncPanel.getAttribute("visible"), "Sync Panel is in view");
let subpanel = document.getElementById("PanelUI-remotetabs-main");
ok(!subpanel.hidden, "main pane is visible");
let deck = document.getElementById("PanelUI-remotetabs-deck");