Bug 1669446 - Move clang-tidy-external into its own yml configs r=marco,andi

Differential Revision: https://phabricator.services.mozilla.com/D92760

taskcluster/ci/fetch/kind.yml

@@ -14,6 +14,7 @@ jobs-from:
     - benchmarks.yml
     - browsertime.yml
     - toolchains.yml
+    - toolchain-clang-tidy-external.yml
     - chromium-fetch.yml
     - visual-metrics.yml
     - resource-monitor.yml

taskcluster/ci/fetch/toolchain-clang-tidy-external.yml

@@ -0,0 +1,13 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+---
+civet-source:
+    description: Repository for external static analysis checks
+    artifact-prefix: project/civet
+    fetch:
+        type: git
+        repo: git@github.com:mozilla-services/civet.git
+        revision: 1a7a27f0a3bede8f94ac1e7c73f400de797296b5
+        ssh-key: project/civet/github-deploy-key
+        artifact-name: civet-source.tar.zst

taskcluster/ci/fetch/toolchains.yml

@@ -431,16 +431,6 @@ clang-11:
         repo: https://github.com/llvm/llvm-project
         revision: 8aca41f39c207b6f9efe2e448986d109892072ad
 
-civet-source:
-    description: Repository for external static analysis checks
-    artifact-prefix: project/civet
-    fetch:
-        type: git
-        repo: git@github.com:mozilla-services/civet.git
-        revision: 1a7a27f0a3bede8f94ac1e7c73f400de797296b5
-        ssh-key: project/civet/github-deploy-key
-        artifact-name: civet-source.tar.zst
-
 wasi-sdk:
     description: wasi-sdk source code
     fetch:

taskcluster/ci/toolchain/clang-tidy-external.yml

@@ -0,0 +1,53 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+---
+job-defaults:
+    description: "Clang-tidy build"
+    attributes:
+        local-toolchain: true
+    index:
+        product: static-analysis
+    worker-type: b-linux-large
+    worker:
+        max-run-time: 3600
+    run:
+        toolchain-artifact: public/build/clang-tidy.tar.zst
+        resources:
+            - 'build/clang-plugin/**/*.cpp'
+            - 'build/clang-plugin/**/*.h'
+            - 'build/clang-plugin/*.inc'
+            - 'build/clang-plugin/*.py'
+            - 'build/clang-plugin/moz.build'
+            - 'build/clang-plugin/Makefile.in'
+            - 'build/build-clang/build-clang.py'
+    fetches:
+        fetch:
+            - clang-10
+
+linux-clang-tidy-external:
+    attributes:
+        local-toolchain: false
+    index:
+        job-name: linux-clang-tidy-external
+    treeherder:
+        symbol: TL(linux-clang-tidy-external)
+    worker:
+        artifacts:
+            - name: project/civet/clang-tidy.tar.zst
+              path: /builds/worker/private-artifacts/clang-tidy.tar.zst
+              type: file
+    run:
+        toolchain-artifact: project/civet/clang-tidy.tar.zst
+        script: build-clang-tidy-external.sh
+        arguments:
+            - 'build/build-clang/clang-tidy-external-linux64.json'
+        resources:
+            - 'build/build-clang/clang-tidy-external-linux64.json'
+    run-on-projects: []
+    fetches:
+        fetch:
+            - civet-source
+        toolchain:
+            - linux64-binutils
+            - linux64-gcc-7

taskcluster/ci/toolchain/clang-tidy.yml

@@ -96,30 +96,3 @@ win64-clang-tidy:
         fetch:
             - cmake
             - ninja
-
-linux-clang-tidy-external:
-    attributes:
-        local-toolchain: false
-    index:
-        job-name: linux-clang-tidy-external
-    treeherder:
-        symbol: TL(linux-clang-tidy-external)
-    worker:
-        artifacts:
-            - name: project/civet/clang-tidy.tar.zst
-              path: /builds/worker/private-artifacts/clang-tidy.tar.zst
-              type: file
-    run:
-        toolchain-artifact: project/civet/clang-tidy.tar.zst
-        script: build-clang-tidy-external.sh
-        arguments:
-            - 'build/build-clang/clang-tidy-external-linux64.json'
-        resources:
-            - 'build/build-clang/clang-tidy-external-linux64.json'
-    run-on-projects: []
-    fetches:
-        fetch:
-            - civet-source
-        toolchain:
-            - linux64-binutils
-            - linux64-gcc-7

taskcluster/ci/toolchain/kind.yml

@@ -27,6 +27,7 @@ jobs-from:
     - cbindgen.yml
     - cctools-port.yml
     - clang-tidy.yml
+    - clang-tidy-external.yml
     - clang.yml
     - dump-syms.yml
     - fix-stacks.yml