replace nsAutoCString with more efficient nsAutoString.

mailnews/news/src/nsNNTPNewsgroupList.cpp

@@ -228,7 +228,7 @@ nsNNTPNewsgroupList::GetRangeOfArtsToDownload(
 			rv = m_newsDB->GetDBFolderInfo(&newsGroupInfo);
 			if (NS_SUCCEEDED(rv) && newsGroupInfo)
 			{
-				nsString knownArtsString;
+				nsAutoString knownArtsString (eOneByte);
                 nsMsgKey mark;
 				newsGroupInfo->GetKnownArtsSet(knownArtsString);
                 
@@ -241,7 +241,7 @@ nsNNTPNewsgroupList::GetRangeOfArtsToDownload(
 				if (m_knownArts.set) {
 					delete m_knownArts.set;
 				}
-				m_knownArts.set = nsMsgKeySet::Create(nsAutoCString(knownArtsString));
+				m_knownArts.set = nsMsgKeySet::Create(knownArtsString.GetBuffer());
 			}
 			else
 			{	

mailnews/news/src/nsNewsFolder.cpp

@@ -374,14 +374,14 @@ nsresult nsMsgNewsFolder::AddSubfolder(nsAutoString name, nsIMsgFolder **child)
 	if(NS_FAILED(rv))
 		return rv;
 
-	nsAutoString uri;
+	nsAutoString uri (eOneByte);
 	uri.Append(mURI);
 	uri.Append('/');
 
 	uri.Append(name);
 
 	nsIRDFResource* res;
-	rv = rdf->GetResource(nsAutoCString(uri), &res);
+	rv = rdf->GetResource(uri.GetBuffer(), &res);
 	if (NS_FAILED(rv))
 		return rv;
 
@@ -631,8 +631,8 @@ NS_IMETHODIMP nsMsgNewsFolder::BuildFolderURL(char **url)
   nsresult rv = GetPath(path);
   if (NS_FAILED(rv)) return rv;
 #if defined(XP_MAC)
-  nsAutoString tmpPath((nsFilePath)path);	//ducarroz: please don't cast a nsFilePath to char* on Mac
-  *url = PR_smprintf("%s%s", urlScheme, nsAutoCString(tmpPath));
+  nsAutoString tmpPath((nsFilePath)path, eOneByte);	//ducarroz: please don't cast a nsFilePath to char* on Mac
+  *url = PR_smprintf("%s%s", urlScheme, tmpPath.GetBuffer());
 #else
   const char *pathName = path;
   *url = PR_smprintf("%s%s", urlScheme, pathName);

mailnews/news/src/nsNewsMessage.cpp

@@ -72,7 +72,7 @@ nsresult nsNewsMessage::GetFolderFromURI(nsIMsgFolder **folder)
 		nsString messageFolderURIStr;
 		nsMsgKey key;
 		nsParseNewsMessageURI(uri, messageFolderURIStr, &key);
-		nsString folderOnly, folderURIStr;
+		nsAutoString folderOnly, folderURIStr (eOneByte);
 
 		if (messageFolderURIStr.Find(kNewsMessageRootURI) != ((PRInt32)-1))			{
 			messageFolderURIStr.Right(folderOnly, messageFolderURIStr.Length() - kNewsMessageRootURILen);
@@ -83,7 +83,7 @@ nsresult nsNewsMessage::GetFolderFromURI(nsIMsgFolder **folder)
 			NS_WITH_SERVICE(nsIRDFService, rdfService, kRDFServiceCID, &rv); 
 			if (NS_SUCCEEDED(rv))   // always check this before proceeding 
 			{
-				rv = rdfService->GetResource(nsAutoCString(folderURIStr), &folderResource);
+				rv = rdfService->GetResource(folderURIStr.GetBuffer(), &folderResource);
 				if(NS_SUCCEEDED(rv))
 				{
 					rv = NS_SUCCEEDED(folderResource->QueryInterface(nsIMsgFolder::GetIID(), (void**)folder));

mailnews/news/src/nsNewsUtils.cpp

@@ -144,13 +144,13 @@ nsNewsURI2Path(const char* rootURI, const char* uriStr, nsFileSpec& pathResult)
   while (uri[hostStart]=='/') hostStart++;
   
   // cut news://hostname/newsgroup -> hostname/newsgroup
-  nsAutoString hostname;
+  nsAutoString hostname (eOneByte);
   uri.Right(hostname, uri.Length() - hostStart);
 
   PRInt32 hostEnd = hostname.Find('/');
 
   // newsgroup comes after the hostname, after the '/'
-  nsAutoString newsgroup = "";
+  nsAutoString newsgroup (eOneByte);
  
   if (hostEnd != -1) {
     hostname.Right(newsgroup, hostname.Length() - hostEnd - 1);
@@ -162,7 +162,7 @@ nsNewsURI2Path(const char* rootURI, const char* uriStr, nsFileSpec& pathResult)
     hostname.Truncate(hostEnd);
   }
 
-  rv = nsGetNewsRoot(nsAutoCString(hostname), pathResult);
+  rv = nsGetNewsRoot(hostname.GetBuffer(), pathResult);
 
   if (NS_FAILED(rv)) {
     pathResult = nsnull;
@@ -178,7 +178,7 @@ nsNewsURI2Path(const char* rootURI, const char* uriStr, nsFileSpec& pathResult)
   if (!pathResult.Exists())
     pathResult.CreateDir();
               
-  nsAutoString alteredHost = "host-";
+  nsAutoString alteredHost ((const char *) "host-", eOneByte);
   alteredHost += hostname;
   
   // can't do pathResult += "host-"; pathresult += hostname; 
@@ -198,8 +198,8 @@ nsNewsURI2Path(const char* rootURI, const char* uriStr, nsFileSpec& pathResult)
 
 #ifdef DEBUG_NEWS
   printf("nsGetNewsRoot(%s) = %s\n\tnewsgroup = %s\n",
-         (const char *)nsAutoCString(hostname), (const char*)pathResult,
-         (const char *)nsAutoCString(newsgroup));
+         hostname.GetBuffer(), (const char*)pathResult,
+         newsgroup.GetBuffer();
 #endif
 
   return NS_OK;
@@ -248,13 +248,13 @@ nsresult nsBuildNewsMessageURI(const char *baseURI, PRUint32 key, char** uri)
 		return NS_ERROR_NULL_POINTER;
   // need to convert news://hostname/.. to news_message://hostname/..
 
-  nsAutoString tailURI(baseURI);
+  nsAutoString tailURI(baseURI, eOneByte);
 
   // chop off news:/
   if (tailURI.Find(kNewsRootURI) == 0)
     tailURI.Cut(0, kNewsRootURILen);
   
-	*uri = PR_smprintf("%s%s#%d", kNewsMessageRootURI, (const char *)nsAutoCString(tailURI), key);
+	*uri = PR_smprintf("%s%s#%d", kNewsMessageRootURI, tailURI.GetBuffer(), key);
   
 	return NS_OK;
 }