From 79420d3af8411dd05a6a86b7fe42929c94aa7b9f Mon Sep 17 00:00:00 2001
From: Julian Descottes <jdescottes@mozilla.com>
Date: Mon, 24 Sep 2018 09:43:54 +0000
Subject: [PATCH] Bug 1489426 - Add i18n for TemporaryExtensionInstaller
 component;

Differential Revision: https://phabricator.services.mozilla.com/D6605

--HG--
extra : moz-landing-system : lando
---
 .../src/actions/debug-targets.js              |  3 +--
 .../TemporaryExtensionInstaller.js            | 25 +++++++++++++------
 .../tmp-locale/en-US/aboutdebugging.notftl    | 10 ++++++++
 3 files changed, 29 insertions(+), 9 deletions(-)

diff --git a/devtools/client/aboutdebugging-new/src/actions/debug-targets.js b/devtools/client/aboutdebugging-new/src/actions/debug-targets.js
index 9860b685c19e..d82755f20dbd 100644
--- a/devtools/client/aboutdebugging-new/src/actions/debug-targets.js
+++ b/devtools/client/aboutdebugging-new/src/actions/debug-targets.js
@@ -75,9 +75,8 @@ function inspectDebugTarget(type, id) {
   };
 }
 
-function installTemporaryExtension() {
+function installTemporaryExtension(message) {
   return async (dispatch, getState) => {
-    const message = "Select Manifest File or Package (.xpi)";
     const file = await openTemporaryExtension(window, message);
     try {
       await AddonManager.installTemporaryAddon(file);
diff --git a/devtools/client/aboutdebugging-new/src/components/debugtarget/TemporaryExtensionInstaller.js b/devtools/client/aboutdebugging-new/src/components/debugtarget/TemporaryExtensionInstaller.js
index 4dd032ef43cd..aa1e2d640dc1 100644
--- a/devtools/client/aboutdebugging-new/src/components/debugtarget/TemporaryExtensionInstaller.js
+++ b/devtools/client/aboutdebugging-new/src/components/debugtarget/TemporaryExtensionInstaller.js
@@ -4,10 +4,13 @@
 
 "use strict";
 
-const { PureComponent } = require("devtools/client/shared/vendor/react");
+const { createFactory, PureComponent } = require("devtools/client/shared/vendor/react");
 const dom = require("devtools/client/shared/vendor/react-dom-factories");
 const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
 
+const FluentReact = require("devtools/client/shared/vendor/fluent-react");
+const Localized = createFactory(FluentReact.Localized);
+
 const Actions = require("../../actions/index");
 
 /**
@@ -17,22 +20,30 @@ class TemporaryExtensionInstaller extends PureComponent {
   static get propTypes() {
     return {
       dispatch: PropTypes.func.isRequired,
+      // Provided by wrapping the component with FluentReact.withLocalization.
+      getString: PropTypes.func.isRequired,
     };
   }
 
   install() {
-    this.props.dispatch(Actions.installTemporaryExtension());
+    const message = this.props.getString("about-debugging-tmp-extension-install-message");
+    this.props.dispatch(Actions.installTemporaryExtension(message));
   }
 
   render() {
-    return dom.button(
+    return Localized(
       {
-        className: "aboutdebugging-button",
-        onClick: e => this.install()
+        id: "about-debugging-tmp-extension-install-button"
       },
-      "Load Temporary Add-on…"
+      dom.button(
+        {
+          className: "aboutdebugging-button",
+          onClick: e => this.install()
+        },
+        "Load Temporary Add-on…"
+      )
     );
   }
 }
 
-module.exports = TemporaryExtensionInstaller;
+module.exports = FluentReact.withLocalization(TemporaryExtensionInstaller);
diff --git a/devtools/client/aboutdebugging-new/tmp-locale/en-US/aboutdebugging.notftl b/devtools/client/aboutdebugging-new/tmp-locale/en-US/aboutdebugging.notftl
index 9a179a9d5735..a8e931bd94e4 100644
--- a/devtools/client/aboutdebugging-new/tmp-locale/en-US/aboutdebugging.notftl
+++ b/devtools/client/aboutdebugging-new/tmp-locale/en-US/aboutdebugging.notftl
@@ -30,3 +30,13 @@ about-debugging-runtime-service-workers = Service Workers
 about-debugging-runtime-shared-workers = Shared Workers
 # Title of the other workers category.
 about-debugging-runtime-other-workers = Other Workers
+
+# Text of a button displayed in the "This Firefox" page, in the Temporary Extension
+# section. Clicking on the button will open a file picker to load a temporary extension
+about-debugging-tmp-extension-install-button = Load Temporary Add-on…
+
+# Message displayed in the file picker that opens to select a temporary extension to load
+# (triggered by the button using "about-debugging-tmp-extension-install-button")
+# manifest.json .xpi and .zip should not be localized.
+# Note: this message is only displayed in Windows and Linux platforms.
+about-debugging-tmp-extension-install-message = Select manifest.json file or .xpi/.zip archive