From 7956ba872264c15b0d3a2e2a7dfc860a6de49c99 Mon Sep 17 00:00:00 2001 From: Panos Astithas Date: Thu, 8 May 2014 18:26:28 +0300 Subject: [PATCH] Add a debugger test for inspection of optimized out variables (bug 1002456). r=vporof --- browser/devtools/debugger/test/browser.ini | 2 + .../test/browser_dbg_optimized-out-vars.js | 48 +++++++++++++++++++ .../test/doc_closure-optimized-out.html | 34 +++++++++++++ 3 files changed, 84 insertions(+) create mode 100644 browser/devtools/debugger/test/browser_dbg_optimized-out-vars.js create mode 100644 browser/devtools/debugger/test/doc_closure-optimized-out.html diff --git a/browser/devtools/debugger/test/browser.ini b/browser/devtools/debugger/test/browser.ini index 7ea72c01f4b6..57ad2324cec1 100644 --- a/browser/devtools/debugger/test/browser.ini +++ b/browser/devtools/debugger/test/browser.ini @@ -42,6 +42,7 @@ support-files = doc_blackboxing.html doc_breakpoints-break-on-last-line-of-script-on-reload.html doc_closures.html + doc_closure-optimized-out.html doc_cmd-break.html doc_cmd-dbg.html doc_conditional-breakpoints.html @@ -161,6 +162,7 @@ skip-if = true # Bug 933950 (leaky test) [browser_dbg_navigation.js] [browser_dbg_no-page-sources.js] [browser_dbg_on-pause-highlight.js] +[browser_dbg_optimized-out-vars.js] [browser_dbg_panel-size.js] [browser_dbg_parser-01.js] [browser_dbg_parser-02.js] diff --git a/browser/devtools/debugger/test/browser_dbg_optimized-out-vars.js b/browser/devtools/debugger/test/browser_dbg_optimized-out-vars.js new file mode 100644 index 000000000000..e53cacf99a1d --- /dev/null +++ b/browser/devtools/debugger/test/browser_dbg_optimized-out-vars.js @@ -0,0 +1,48 @@ +/* Any copyright is dedicated to the Public Domain. + http://creativecommons.org/publicdomain/zero/1.0/ */ + +// Test that optimized out variables aren't present in the variables view. + +function test() { + Task.spawn(function* () { + const TAB_URL = EXAMPLE_URL + "doc_closure-optimized-out.html"; + let panel, debuggee, gDebugger, sources; + + let [, debuggee, panel] = yield initDebugger(TAB_URL); + gDebugger = panel.panelWin; + sources = gDebugger.DebuggerView.Sources; + + yield waitForSourceShown(panel, ".html"); + yield panel.addBreakpoint({ url: sources.values[0], line: 18 }); + yield ensureThreadClientState(panel, "resumed"); + + // Spin the event loop before causing the debuggee to pause, to allow + // this function to return first. + executeSoon(() => { + EventUtils.sendMouseEvent({ type: "click" }, + debuggee.document.querySelector("button"), + debuggee); + }); + + yield waitForDebuggerEvents(panel, gDebugger.EVENTS.FETCHED_SCOPES); + let gVars = gDebugger.DebuggerView.Variables; + let outerScope = gVars.getScopeAtIndex(1); + outerScope.expand(); + + let upvarVar = outerScope.get("upvar"); + ok(!upvarVar, "upvar was optimized out."); + if (upvarVar) { + ok(false, "upvar = " + upvarVar.target.querySelector(".value").getAttribute("value")); + } + + let argVar = outerScope.get("arg"); + is(argVar.target.querySelector(".name").getAttribute("value"), "arg", + "Should have the right property name for |arg|."); + is(argVar.target.querySelector(".value").getAttribute("value"), 42, + "Should have the right property value for |arg|."); + + yield resumeDebuggerThenCloseAndFinish(panel); + }).then(null, aError => { + ok(false, "Got an error: " + aError.message + "\n" + aError.stack); + }); +} diff --git a/browser/devtools/debugger/test/doc_closure-optimized-out.html b/browser/devtools/debugger/test/doc_closure-optimized-out.html new file mode 100644 index 000000000000..3ad4e8fc0a07 --- /dev/null +++ b/browser/devtools/debugger/test/doc_closure-optimized-out.html @@ -0,0 +1,34 @@ + + + + + Debugger Test for Inspecting Optimized-Out Variables + + + + + + + +