From 7a31cb37faecce6342b4e6cb37851607472497ad Mon Sep 17 00:00:00 2001
From: Asaf Romano <mano@mozilla.com>
Date: Thu, 17 Dec 2009 22:28:10 +0100
Subject: [PATCH] Bug 529062 - [Mac] Bookmarks menu entries don't update
 correctly, r=mak

---
 browser/components/places/content/menu.xml | 25 ++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/browser/components/places/content/menu.xml b/browser/components/places/content/menu.xml
index 3a64d2013caa..f3d0a017db95 100644
--- a/browser/components/places/content/menu.xml
+++ b/browser/components/places/content/menu.xml
@@ -624,8 +624,7 @@
         <parameter name="aParentPopup"/>
         <parameter name="aBefore"/>
         <body><![CDATA[
-          var element = PlacesUIUtils.createMenuItemForNode(aChild);
-
+          let element = PlacesUIUtils.createMenuItemForNode(aChild);
           if (aBefore)
             aParentPopup.insertBefore(element, aBefore);
           else {
@@ -642,6 +641,28 @@
 
           if (aParentPopup._endMarker != -1)
             aParentPopup._endMarker++;
+
+#ifdef XP_MACOSX
+          // Bug 529062:
+          // We rely on the menu* bindings, but those aren't never applied
+          // in native mac menus, for elements which are added to the document
+          // through appendChild / insertBefore.
+          if (this.parentNode.parentNode.localName != "menubar")
+            return;
+
+          function applyBinding(elm) {
+            // getPropertyCSSValue is semi-deprecared, but there's no
+            // alternative for parsing css_uri values reliably.
+            let elmBindingURI = window.getComputedStyle(element, "")
+                                      .getPropertyCSSValue("-moz-binding");
+            if (elmBindingURI.primitiveType == CSSPrimitiveValue.CSS_URI)
+              document.addBinding(elm, elmBindingURI.getStringValue());
+          }
+
+          applyBinding(element);
+          if (element.localName == "menu")
+            applyBinding(element.firstChild);
+#endif
         ]]></body>
       </method>
 
