From 7a66ccf8ea58c80ad12f141661f70620b4f22204 Mon Sep 17 00:00:00 2001 From: Nika Layzell Date: Mon, 14 Oct 2019 21:08:16 +0000 Subject: [PATCH] Bug 1578507 - Remove browser_cross_process_redirect test r=valentin This test was originally written to test HTTPResponseProcessSelection before it was hooked up into the process switch machinery. It hooks into some parts of the process switch process which should probably be removed in the future (such as overriding the child listener component registration), and is broken under fission anyway. Differential Revision: https://phabricator.services.mozilla.com/D47313 --HG-- extra : moz-landing-system : lando --- netwerk/test/browser/browser.ini | 2 - .../browser/browser_cross_process_redirect.js | 292 ------------------ 2 files changed, 294 deletions(-) delete mode 100644 netwerk/test/browser/browser_cross_process_redirect.js diff --git a/netwerk/test/browser/browser.ini b/netwerk/test/browser/browser.ini index 7af3f3decdeb..04375ace39a4 100644 --- a/netwerk/test/browser/browser.ini +++ b/netwerk/test/browser/browser.ini @@ -15,8 +15,6 @@ skip-if = e10s # protocol handler and channel does not work in content process [browser_resource_navigation.js] [browser_test_io_activity.js] [browser_cookie_sync_across_tabs.js] -[browser_cross_process_redirect.js] -fail-if = fission [browser_test_favicon.js] skip-if = (verify && (os == 'linux' || os == 'mac')) support-files = diff --git a/netwerk/test/browser/browser_cross_process_redirect.js b/netwerk/test/browser/browser_cross_process_redirect.js deleted file mode 100644 index 993d9314996d..000000000000 --- a/netwerk/test/browser/browser_cross_process_redirect.js +++ /dev/null @@ -1,292 +0,0 @@ -/* - * Any copyright is dedicated to the Public Domain. - * http://creativecommons.org/publicdomain/zero/1.0/ - */ - -"use strict"; - -const gRegistrar = Components.manager.QueryInterface(Ci.nsIComponentRegistrar); - -let gLoadedInProcess2Promise = null; - -function _createProcessChooser(remoteTab, from, to, rejectPromise = false) { - let processChooser = new ProcessChooser( - remoteTab, - "example.com", - "example.org", - rejectPromise - ); - registerCleanupFunction(function() { - processChooser.unregister(); - }); -} - -function ProcessChooser(remoteTab, from, to, rejectPromise = false) { - this.remoteTab = remoteTab; - this.fromDomain = from; - this.toDomain = to; - this.rejectPromise = rejectPromise; - - this.registered = true; - Services.obs.addObserver(this, "http-on-may-change-process"); -} - -ProcessChooser.prototype = { - unregister() { - if (!this.registered) { - return; - } - this.registered = false; - Services.obs.removeObserver(this, "http-on-may-change-process"); - }, - - examine(aRequestor) { - const channel = aRequestor.channel; - - if (this.channel && this.channel != channel) { - // Hack: this is just so we don't get redirected multiple times. - info("same channel. give null"); - return; - } - - if (channel.URI.host != this.toDomain) { - info("wrong host for channel " + channel.URI.host); - return; - } - - let redirects = channel.loadInfo.redirectChain; - if (redirects[redirects.length - 1].principal.URI.host != this.fromDomain) { - info("didn't find redirect"); - return; - } - - info("setting channel"); - this.channel = channel; - let self = this; - - info("unregistering"); - this.unregister(); - - let identifier = 42; - let tabPromise = new Promise((resolve, reject) => { - if (self.rejectPromise) { - info("rejecting"); - reject(Cr.NS_ERROR_NOT_AVAILABLE); - return; - } - // Can asyncly create a tab, or can resolve with a tab that was - // previously created. - info("resolving"); - resolve(self.remoteTab.contentProcessId); - }); - - info("calling switchprocessto"); - aRequestor.switchProcessTo(tabPromise, identifier); - }, - - observe(aSubject, aTopic, aData) { - switch (aTopic) { - case "http-on-may-change-process": - this.examine(aSubject.QueryInterface(Ci.nsIProcessSwitchRequestor)); - break; - default: - ok(false, "Unexpected topic observed!"); - break; - } - }, - - // nsISupports - QueryInterface: ChromeUtils.generateQI([Ci.nsIObserver]), -}; - -add_task(async function() { - info( - "Check that a redirect in process A may be correctly handled in process B" - ); - - const kRoot1 = getRootDirectory(gTestPath).replace( - "chrome://mochitests/content/", - "https://example.com/" - ); - const kRoot2 = getRootDirectory(gTestPath).replace( - "chrome://mochitests/content/", - "https://example.org/" - ); - const kRoot3 = getRootDirectory(gTestPath); - - // This process will attempt to load the page that redirects to a different origin - let tab1 = await BrowserTestUtils.openNewForegroundTab({ - gBrowser, - url: kRoot1 + "dummy.html", - forceNewProcess: true, - }); - // This process will eventually receive the redirected channel. - let tab2 = await BrowserTestUtils.openNewForegroundTab({ - gBrowser, - url: kRoot2 + "dummy.html", - forceNewProcess: true, - }); - - let browser1 = gBrowser.getBrowserForTab(tab1); - let browser2 = gBrowser.getBrowserForTab(tab2); - - // This is for testing purposes only. - // This "process chooser" will direct the channel to be opened in the second - // tab, and thus in the second parent. - let processChooser = _createProcessChooser( - browser2.frameLoader.remoteTab, - "example.com", - "example.org" - ); - - info("Loading redirected URL"); - // Open the URL in the first process. We expect it to wind up in the second - // process. - - // Define the child listener in the new channel. - await ContentTask.spawn(browser2, null, async function(arg) { - function ChannelListener(childListener) { - this.childListener = childListener; - } - ChannelListener.prototype = { - onStartRequest(aRequest) { - info("onStartRequest"); - let channel = aRequest.QueryInterface(Ci.nsIChannel); - Assert.equal( - channel.URI.spec, - this.childListener.URI, - "Make sure the channel has the proper URI" - ); - Assert.equal( - channel.originalURI.spec, - this.childListener.originalURI, - "Make sure the originalURI is correct" - ); - }, - onStopRequest(aRequest, aStatusCode) { - info("onStopRequest"); - Assert.equal(aStatusCode, Cr.NS_OK, "Check the status code"); - Assert.equal( - this.gotData, - true, - "Check that the channel received data" - ); - if (this.childListener.onComplete) { - this.childListener.onComplete(); - } - this.childListener.resolve(); - }, - onDataAvailable(aRequest, aContext, aInputStream, aOffset, aCount) { - this.gotData = true; - info("onDataAvailable"); - }, - QueryInterface: ChromeUtils.generateQI([ - Ci.nsIStreamListener, - Ci.nsIRequestObserver, - ]), - }; - - function ChildListener(uri, originalURI, resolve) { - this.URI = uri; - this.originalURI = originalURI; - this.resolve = resolve; - } - ChildListener.prototype = { - // nsIChildProcessChannelListener - onChannelReady(aChildChannel, aIdentifier) { - Assert.equal(aIdentifier, 42, "Check the status code"); - info("onChannelReady"); - aChildChannel.completeRedirectSetup(new ChannelListener(this), null); - }, - // nsIFactory - createInstance(aOuter, aIID) { - if (aOuter) { - throw Cr.NS_ERROR_NO_AGGREGATION; - } - return this.QueryInterface(aIID); - }, - lockFactory() {}, - // nsISupports - QueryInterface: ChromeUtils.generateQI([ - Ci.nsIChildProcessChannelListener, - Ci.nsIFactory, - ]), - classID: Components.ID("{a6c142a9-eb38-4a09-a940-b71cdad479e1}"), - }; - - content.window.ChildListener = ChildListener; - }); - - // This promise instantiates a ChildListener and is resolved when the redirected - // channel is completed. - let loadedInProcess2Promise = ContentTask.spawn( - browser2, - { - URI: kRoot2 + "dummy.html", - originalURI: kRoot1 + "redirect.sjs?" + kRoot2 + "dummy.html", - }, - async function(arg) { - // We register the listener in process no. 2 - return new Promise(resolve => { - var childListener = new content.window.ChildListener( - arg.URI, - arg.originalURI, - resolve - ); - var registrar = Components.manager.QueryInterface( - Ci.nsIComponentRegistrar - ); - childListener.onComplete = () => { - registrar.unregisterFactory(childListener.classID, childListener); - }; - registrar.registerFactory( - childListener.classID, - "", - "@mozilla.org/network/childProcessChannelListener;1", - childListener - ); - }); - } - ); - - let browser1LoadHasStopped = BrowserTestUtils.browserStopped( - browser1, - undefined, - true - ); - - await BrowserTestUtils.loadURI( - browser1, - kRoot1 + "redirect.sjs?" + kRoot2 + "dummy.html" - ); - - // Check that the channel was delivered to process no. 2 - await loadedInProcess2Promise; - info("channel has loaded in second process"); - // This is to check that the old channel was cancelled. - await browser1LoadHasStopped; - - // check that a rejected promise also works. - processChooser = _createProcessChooser( - browser2.frameLoader.remoteTab, - "example.com", - "example.org", - true - ); - let browser1LoadHasStoppedAgain = BrowserTestUtils.browserStopped( - browser1, - undefined, - true - ); - await BrowserTestUtils.loadURI( - browser1, - kRoot1 + "redirect.sjs?" + kRoot2 + "dummy.html" - ); - await browser1LoadHasStoppedAgain; - info("this is done now"); - - BrowserTestUtils.removeTab(tab1); - BrowserTestUtils.removeTab(tab2); - - ok(true, "Got to the end of the test!"); -});