bug 1353296 - get rid of filter_upload_symbols. r=dustin

filter_upload_symbols is a relic of task configurations that were written
before we had a better handle on taskgraph generation. We should only be
uploading symbols for nightly builds anyway, so this is better served using
newer filtering methods.

upload-symbols tasks were specified to run on non-nightly build types in the
kind.yml, but those were filtered out in filter_upload_symbols. I believe
these were simply an artifact of the initial upload-symbols implementation
happening before nightly builds were running in Taskcluster.

MozReview-Commit-ID: Je1NytrVPT8

--HG--
extra : rebase_source : a961c17d329af848fa7bb64c5186135d37dd412f

taskcluster/ci/upload-symbols/kind.yml

@@ -12,23 +12,8 @@ transforms:
 kind-dependencies:
     - build
 
-only-for-build-platforms:
-    - linux64/opt
-    - linux64/debug
-    - linux64-nightly/opt
-    - linux-nightly/opt
-    - linux64-devedition-nightly/opt
-    - linux-devedition-nightly/opt
-    - android-aarch64-nightly/opt
-    - android-api-16/opt
-    - android-api-16-nightly/opt
-    - android-x86-nightly/opt
-    - macosx64-nightly/opt
-    - macosx64-devedition-nightly/opt
-    - win32-nightly/opt
-    - win64-nightly/opt
-    - win32-devedition-nightly/opt
-    - win64-devedition-nightly/opt
+only-for-attributes:
+    - nightly
 
 job-template:
     description: Upload Symbols

taskcluster/taskgraph/target_tasks.py

@@ -40,14 +40,6 @@ def filter_on_platforms(task, platforms):
     return (platform in platforms)
 
 
-def filter_upload_symbols(task, parameters):
-    # Filters out symbols when there are not part of a nightly or a release build
-    # TODO Remove this too specific filter (bug 1353296)
-    return '-upload-symbols' not in task.label or \
-        task.attributes.get('nightly') or \
-        parameters.get('project') in ('mozilla-beta', 'mozilla-release')
-
-
 def filter_beta_release_tasks(task, parameters, ignore_kinds=None, allow_l10n=False):
     if not standard_filter(task, parameters):
         return False
@@ -94,7 +86,7 @@ def filter_beta_release_tasks(task, parameters, ignore_kinds=None, allow_l10n=Fa
 def standard_filter(task, parameters):
     return all(
         filter_func(task, parameters) for filter_func in
-        (filter_out_nightly, filter_for_project, filter_upload_symbols)
+        (filter_out_nightly, filter_for_project)
     )