Bug 1381253 - Remove redundant control flow declarations rs=ehsan

MozReview-Commit-ID: FFxP4aMCbOL

--HG--
extra : amend_source : 3aec108430b11048f47ffe19d5da7ac5034770a9

dom/base/CustomElementRegistry.cpp

@@ -247,8 +247,6 @@ CustomElementRegistry::RegisterUnresolvedElement(Element* aElement, nsIAtom* aTy
   nsWeakPtr* elem = unresolved->AppendElement();
   *elem = do_GetWeakReference(aElement);
   aElement->AddStates(NS_EVENT_STATE_UNRESOLVED);
-
-  return;
 }
 
 void
@@ -773,7 +771,6 @@ CustomElementRegistry::Get(JSContext* aCx, const nsAString& aName,
   }
 
   aRetVal.setObject(*data->mConstructor);
-  return;
 }
 
 already_AddRefed<Promise>

dom/base/DOMException.cpp

@@ -114,8 +114,6 @@ NSResultToNameAndMessage(nsresult aNSResult,
   }
 
   NS_WARNING("Huh, someone is throwing non-DOM errors using the DOM module!");
-
-  return;
 }
 
 nsresult

dom/base/DocumentFragment.h

@@ -113,7 +113,6 @@ public:
   virtual void UnbindFromTree(bool aDeep, bool aNullParent) override
   {
     NS_ASSERTION(false, "Trying to unbind a fragment from a tree");
-    return;
   }
 
   virtual Element* GetNameSpaceElement() override

dom/base/Element.cpp

@@ -1305,7 +1305,6 @@ Element::SetAttribute(const nsAString& aName,
 
   aError = SetAttr(name->NamespaceID(), name->LocalName(), name->GetPrefix(),
                    aValue, true);
-  return;
 }
 
 void
@@ -2726,8 +2725,6 @@ Element::PreIdMaybeChange(int32_t aNamespaceID, nsIAtom* aName,
     return;
   }
   RemoveFromIdTable();
-
-  return;
 }
 
 void
@@ -2746,8 +2743,6 @@ Element::PostIdMaybeChange(int32_t aNamespaceID, nsIAtom* aName,
   } else {
     ClearHasID();
   }
-
-  return;
 }
 
 EventListenerManager*

dom/base/nsAttrValue.cpp

@@ -1330,7 +1330,6 @@ nsAttrValue::ParseAtomArray(const nsAString& aValue)
   }
 
   SetMiscAtomOrString(&aValue);
-  return;
 }
 
 void

dom/base/nsGlobalWindow.cpp

@@ -4900,7 +4900,6 @@ nsGlobalWindow::GetContentOuter(JSContext* aCx,
   }
 
   aRetval.set(nullptr);
-  return;
 }
 
 void

dom/canvas/WebGL2ContextQueries.cpp

@@ -208,7 +208,6 @@ WebGLContext::GetQuery(JSContext* cx, GLenum target, GLenum pname,
     }
 
     ErrorInvalidEnum("%s: Bad pname.", funcName);
-    return;
 }
 
 void

dom/canvas/WebGLTexelConversions.cpp

@@ -219,7 +219,6 @@ class WebGLImageConverter
         }
 
         mSuccess = true;
-        return;
     }
 
     template<WebGLTexelFormat SrcFormat,

dom/html/HTMLFieldSetElement.cpp

@@ -345,8 +345,6 @@ HTMLFieldSetElement::UpdateValidity(bool aElementValidity)
   if (mFieldSet) {
     mFieldSet->UpdateValidity(aElementValidity);
   }
-
-  return;
 }
 
 EventStates

dom/html/HTMLInputElement.cpp

@@ -3418,7 +3418,6 @@ HTMLInputElement::Focus(ErrorResult& aError)
     }
   }
 
-  return;
 }
 
 #if !defined(ANDROID) && !defined(XP_MACOSX)

dom/html/HTMLLinkElement.cpp

@@ -494,8 +494,6 @@ HTMLLinkElement::GetStyleSheetInfo(nsAString& aTitle,
   // If we get here we assume that we're loading a css file, so set the
   // type to 'text/css'
   aType.AssignLiteral("text/css");
-
-  return;
 }
 
 CORSMode

dom/html/nsHTMLDocument.cpp

@@ -296,10 +296,8 @@ nsHTMLDocument::TryHintCharset(nsIContentViewer* aCv,
         aCharsetSource = requestCharsetSource;
         aEncoding = WrapNotNull(requestCharset);
       }
-      return;
     }
   }
-  return;
 }
 
 
@@ -836,7 +834,6 @@ nsHTMLDocument::StopDocumentLoad()
 
   nsDocument::StopDocumentLoad();
   UnblockOnload(false);
-  return;
 }
 
 void

dom/jsurl/nsJSProtocolHandler.cpp

@@ -791,8 +791,6 @@ nsJSChannel::EvaluateScript()
     } else if (mIsAsync) {
         NotifyListener();
     }
-
-    return;
 }
 
 void

dom/media/MediaFormatReader.cpp

@@ -2533,7 +2533,6 @@ MediaFormatReader::SkipVideoDemuxToNextKeyFrame(TimeUnit aTimeThreshold)
            &MediaFormatReader::OnVideoSkipCompleted,
            &MediaFormatReader::OnVideoSkipFailed)
     ->Track(mSkipRequest);
-  return;
 }
 
 void

dom/media/MediaRecorder.cpp

@@ -1418,9 +1418,7 @@ MediaRecorder::NotifyError(nsresult aRv)
   rv = DispatchDOMEvent(nullptr, event, nullptr, nullptr);
   if (NS_FAILED(rv)) {
     NS_ERROR("Failed to dispatch the error event!!!");
-    return;
   }
-  return;
 }
 
 void

dom/media/gmp-plugin/gmp-test-output-protection.h

@@ -123,7 +123,6 @@ TestOuputProtectionAPIs()
 {
   RunOutputProtectionAPITests();
   FakeDecryptor::Message("OP tests completed");
-  return;
 }
 
 } // namespace gmptest

dom/media/mediasource/TrackBuffersManager.cpp

@@ -840,7 +840,6 @@ TrackBuffersManager::CreateDemuxerforMIMEType()
   }
 #endif
   NS_WARNING("Not supported (yet)");
-  return;
 }
 
 // We reset the demuxer by creating a new one and initializing it.

dom/media/webaudio/ScriptProcessorNode.h

@@ -103,14 +103,12 @@ public:
     if (aChannelCount != ChannelCount()) {
       aRv.Throw(NS_ERROR_DOM_NOT_SUPPORTED_ERR);
     }
-    return;
   }
   void SetChannelCountModeValue(ChannelCountMode aMode, ErrorResult& aRv) override
   {
     if (aMode != ChannelCountMode::Explicit) {
       aRv.Throw(NS_ERROR_DOM_NOT_SUPPORTED_ERR);
     }
-    return;
   }
 
   uint32_t BufferSize() const

dom/media/webrtc/MediaEngineDefault.cpp

@@ -58,14 +58,12 @@ void
 MediaEngineDefaultVideoSource::GetName(nsAString& aName) const
 {
   aName.AssignLiteral(u"Default Video Device");
-  return;
 }
 
 void
 MediaEngineDefaultVideoSource::GetUUID(nsACString& aUUID) const
 {
   aUUID.AssignLiteral("1041FCBD-3F12-4F7B-9E9B-1EC556DD5676");
-  return;
 }
 
 uint32_t
@@ -382,14 +380,12 @@ void
 MediaEngineDefaultAudioSource::GetName(nsAString& aName) const
 {
   aName.AssignLiteral(u"Default Audio Device");
-  return;
 }
 
 void
 MediaEngineDefaultAudioSource::GetUUID(nsACString& aUUID) const
 {
   aUUID.AssignLiteral("B7CBD7C1-53EF-42F9-8353-73F61C70C092");
-  return;
 }
 
 uint32_t
@@ -533,8 +529,6 @@ MediaEngineDefault::EnumerateVideoDevices(dom::MediaSourceEnum aMediaSource,
   RefPtr<MediaEngineVideoSource> newSource = new MediaEngineDefaultVideoSource();
   mVSources.AppendElement(newSource);
   aVSources->AppendElement(newSource);
-
-  return;
 }
 
 void
@@ -559,7 +553,6 @@ MediaEngineDefault::EnumerateAudioDevices(dom::MediaSourceEnum aMediaSource,
     mASources.AppendElement(newSource);
     aASources->AppendElement(newSource);
   }
-  return;
 }
 
 } // namespace mozilla

dom/media/webrtc/MediaEngineRemoteVideoSource.cpp

@@ -61,8 +61,6 @@ MediaEngineRemoteVideoSource::Init()
   SetUUID(uniqueId);
 
   mInitDone = true;
-
-  return;
 }
 
 void
@@ -99,7 +97,6 @@ MediaEngineRemoteVideoSource::Shutdown()
 
   MOZ_ASSERT(mState == kReleased);
   mInitDone = false;
-  return;
 }
 
 nsresult

dom/media/webrtc/MediaEngineWebRTCAudio.cpp

@@ -209,14 +209,12 @@ void
 MediaEngineWebRTCMicrophoneSource::GetName(nsAString& aName) const
 {
   aName.Assign(mDeviceName);
-  return;
 }
 
 void
 MediaEngineWebRTCMicrophoneSource::GetUUID(nsACString& aUUID) const
 {
   aUUID.Assign(mDeviceUUID);
-  return;
 }
 
 // GetBestFitnessDistance returns the best distance the capture device can offer
@@ -942,7 +940,6 @@ MediaEngineWebRTCMicrophoneSource::Process(int channel,
 
   uint32_t channels = isStereo ? 2 : 1;
   InsertInGraph<int16_t>(audio10ms, length, channels);
-  return;
 }
 
 void

dom/media/webspeech/recognition/SpeechGrammar.cpp

@@ -53,14 +53,12 @@ void
 SpeechGrammar::GetSrc(nsString& aRetVal, ErrorResult& aRv) const
 {
   aRetVal = mSrc;
-  return;
 }
 
 void
 SpeechGrammar::SetSrc(const nsAString& aArg, ErrorResult& aRv)
 {
   mSrc = aArg;
-  return;
 }
 
 float
@@ -74,7 +72,6 @@ void
 SpeechGrammar::SetWeight(float aArg, ErrorResult& aRv)
 {
   aRv.Throw(NS_ERROR_NOT_IMPLEMENTED);
-  return;
 }
 
 } // namespace dom

dom/media/webspeech/recognition/SpeechGrammarList.cpp

@@ -71,7 +71,6 @@ SpeechGrammarList::AddFromURI(const nsAString& aSrc,
                               ErrorResult& aRv)
 {
   aRv.Throw(NS_ERROR_NOT_IMPLEMENTED);
-  return;
 }
 
 void
@@ -82,7 +81,6 @@ SpeechGrammarList::AddFromString(const nsAString& aString,
   SpeechGrammar* speechGrammar = new SpeechGrammar(mParent);
   speechGrammar->SetSrc(aString, aRv);
   mItems.AppendElement(speechGrammar);
-  return;
 }
 
 already_AddRefed<SpeechGrammar>

dom/media/webspeech/recognition/SpeechRecognition.cpp

@@ -147,7 +147,6 @@ SpeechRecognition::SetState(FSMState state)
 {
   mCurrentState = state;
   SR_LOG("Transitioned to state %s", GetName(mCurrentState));
-  return;
 }
 
 JSObject*
@@ -375,8 +374,6 @@ SpeechRecognition::Transition(SpeechEvent* aEvent)
     case STATE_COUNT:
       MOZ_CRASH("Invalid state STATE_COUNT");
   }
-
-  return;
 }
 
 /*
@@ -559,8 +556,6 @@ SpeechRecognition::NotifyError(SpeechEvent* aEvent)
 
   bool defaultActionEnabled;
   this->DispatchEvent(aEvent->mError, &defaultActionEnabled);
-
-  return;
 }
 
 /**************************************
@@ -641,8 +636,6 @@ SpeechRecognition::ProcessTestEventRequest(nsISupports* aSubject, const nsAStrin
 
     // let the fake recognition service handle the request
   }
-
-  return;
 }
 
 already_AddRefed<SpeechGrammarList>
@@ -681,7 +674,6 @@ void
 SpeechRecognition::SetContinuous(bool aArg, ErrorResult& aRv)
 {
   aRv.Throw(NS_ERROR_NOT_IMPLEMENTED);
-  return;
 }
 
 bool
@@ -694,7 +686,6 @@ void
 SpeechRecognition::SetInterimResults(bool aArg)
 {
   mInterimResults = aArg;
-  return;
 }
 
 uint32_t
@@ -707,21 +698,18 @@ void
 SpeechRecognition::SetMaxAlternatives(uint32_t aArg)
 {
   mMaxAlternatives = aArg;
-  return;
 }
 
 void
 SpeechRecognition::GetServiceURI(nsString& aRetVal, ErrorResult& aRv) const
 {
   aRv.Throw(NS_ERROR_NOT_IMPLEMENTED);
-  return;
 }
 
 void
 SpeechRecognition::SetServiceURI(const nsAString& aArg, ErrorResult& aRv)
 {
   aRv.Throw(NS_ERROR_NOT_IMPLEMENTED);
-  return;
 }
 
 void
@@ -997,8 +985,6 @@ SpeechRecognition::FeedAudioData(already_AddRefed<SharedBuffer> aSamples,
   event->mProvider = aProvider;
   event->mTrackRate = aTrackRate;
   NS_DispatchToMainThread(event);
-
-  return;
 }
 
 const char*

dom/media/webspeech/synth/SpeechSynthesis.cpp

@@ -182,8 +182,6 @@ SpeechSynthesis::AdvanceQueue()
   if (mCurrentTask) {
     mCurrentTask->SetSpeechSynthesis(this);
   }
-
-  return;
 }
 
 void

dom/plugins/base/nsPluginStreamListenerPeer.cpp

@@ -658,7 +658,6 @@ nsPluginStreamListenerPeer::MakeByteRangeString(NPByteRange* aRangeList, nsACStr
 
   rangeRequest = string;
   *numRequests  = requestCnt;
-  return;
 }
 
 // XXX: Converting the channel within nsPluginStreamListenerPeer

dom/plugins/ipc/BrowserStreamParent.cpp

@@ -162,7 +162,6 @@ BrowserStreamParent::StreamAsFile(const char* fname)
   }
 
   Unused << SendNPP_StreamAsFile(nsCString(fname));
-  return;
 }
 
 } // namespace plugins

dom/plugins/ipc/PluginModuleChild.cpp

@@ -2403,7 +2403,6 @@ PluginModuleChild::NPN_ReleaseObject(NPObject* aNPObj)
         if (doe)
             doe->mDeleted = true;
     }
-    return;
 }
 
 void

dom/svg/SVGLength.cpp

@@ -213,7 +213,6 @@ GetUnitString(nsAString& unit, uint16_t unitType)
     return;
   }
   NS_NOTREACHED("Unknown unit type"); // Someone's using an SVGLength with an invalid unit?
-  return;
 }
 
 static uint16_t

dom/svg/SVGStyleElement.cpp

@@ -295,8 +295,6 @@ SVGStyleElement::GetStyleSheetInfo(nsAString& aTitle,
 
   *aIsScoped = HasAttr(kNameSpaceID_None, nsGkAtoms::scoped) &&
                OwnerDoc()->IsScopedStyleEnabled();
-
-  return;
 }
 
 CORSMode

dom/svg/nsSVGAngle.cpp

@@ -59,7 +59,6 @@ GetUnitString(nsAString& unit, uint16_t unitType)
   }
 
   NS_NOTREACHED("Unknown unit type");
-  return;
 }
 
 static uint16_t

dom/svg/nsSVGLength2.cpp

@@ -63,7 +63,6 @@ GetUnitString(nsAString& unit, uint16_t unitType)
   }
 
   NS_NOTREACHED("Unknown unit type");
-  return;
 }
 
 static uint16_t

dom/workers/WorkerPrivate.cpp

@@ -897,7 +897,6 @@ private:
           override
   {
     aWorkerPrivate->ModifyBusyCountFromWorker(false);
-    return;
   }
 
   virtual bool

dom/xbl/nsXBLContentSink.cpp

@@ -82,7 +82,6 @@ nsXBLContentSink::Init(nsIDocument* aDoc,
 void
 nsXBLContentSink::MaybeStartLayout(bool aIgnorePendingSheets)
 {
-  return;
 }
 
 nsresult

dom/xml/XMLStylesheetProcessingInstruction.cpp

@@ -178,8 +178,6 @@ XMLStylesheetProcessingInstruction::GetStyleSheetInfo(nsAString& aTitle,
   // If we get here we assume that we're loading a css file, so set the
   // type to 'text/css'
   aType.AssignLiteral("text/css");
-
-  return;
 }
 
 nsGenericDOMDataNode*

dom/xml/nsXMLFragmentContentSink.cpp

@@ -240,7 +240,6 @@ nsXMLFragmentContentSink::CloseElement(nsIContent* aContent)
 void
 nsXMLFragmentContentSink::MaybeStartLayout(bool aIgnorePendingSheets)
 {
-  return;
 }
 
 ////////////////////////////////////////////////////////////////////////

editor/libeditor/SelectionState.cpp

@@ -434,7 +434,6 @@ RangeUpdater::SelAdjInsertText(Text& aTextNode,
       item->mEndOffset += len;
     }
   }
-  return;
 }
 
 nsresult

extensions/universalchardet/src/base/JpCntx.cpp

@@ -134,8 +134,6 @@ void JapaneseContextAnalysis::HandleData(const char* aBuf, uint32_t aLen)
       mLastCharOrder = order;
     }
   }
-
-  return;
 }
 
 void JapaneseContextAnalysis::Reset()

extensions/universalchardet/src/base/nsUniversalDetector.cpp

@@ -236,5 +236,4 @@ void nsUniversalDetector::DataEnd()
   default:
     ;
   }
-  return;
 }

gfx/2d/DrawTargetRecording.cpp

@@ -75,7 +75,6 @@ EnsureSurfaceStoredRecording(DrawEventRecorderPrivate *aRecorder, SourceSurface
   userData->recorder = aRecorder;
   aSurface->AddUserData(reinterpret_cast<UserDataKey*>(aRecorder),
                         userData, &RecordingSourceSurfaceUserDataFunc);
-  return;
 }
 
 class SourceSurfaceRecording : public SourceSurface

gfx/2d/DrawTargetWrapAndRecord.cpp

@@ -75,7 +75,6 @@ EnsureSurfaceStored(DrawEventRecorderPrivate *aRecorder, SourceSurface *aSurface
   userData->recorder = aRecorder;
   aSurface->AddUserData(reinterpret_cast<UserDataKey*>(aRecorder),
                         userData, &WrapAndRecordSourceSurfaceUserDataFunc);
-  return;
 }
 
 class SourceSurfaceWrapAndRecord : public SourceSurface

gfx/2d/Path.cpp

@@ -442,8 +442,6 @@ FindInflectionPoints(const BezierControlPoints &aControlPoints,
       *aCount = 2;
     }
   }
-
-  return;
 }
 
 void

gfx/gl/GLContext.cpp

@@ -2503,7 +2503,6 @@ SplitByChar(const nsACString& str, const char delim, std::vector<nsCString>* con
         out->push_back(nsCString(substr));
 
         start = end + 1;
-        continue;
     }
 
     nsDependentCSubstring substr(str, start);

gfx/ipc/GPUProcessManager.cpp

@@ -942,7 +942,6 @@ GPUProcessManager::CreateContentVideoDecoderManager(base::ProcessId aOtherProces
   mGPUChild->SendNewContentVideoDecoderManager(Move(parentPipe));
 
   *aOutEndpoint = Move(childPipe);
-  return;
 }
 
 already_AddRefed<IAPZCTreeManager>

gfx/layers/composite/AsyncCompositionManager.cpp

@@ -572,8 +572,6 @@ AsyncCompositionManager::AlignFixedAndStickyLayers(Layer* aTransformedSubtreeRoo
           aPreviousTransformForRoot, newTransform, aFixedLayerMargins, aClipPartsCache);
     }
   }
-
-  return;
 }
 
 static void

gfx/layers/composite/LayerManagerComposite.cpp

@@ -1472,7 +1472,6 @@ LayerComposite::AddBlendModeEffect(EffectChain& aEffectChain)
   }
 
   aEffectChain.mSecondaryEffects[EffectTypes::BLEND_MODE] = new EffectBlendMode(blendMode);
-  return;
 }
 
 bool

gfx/layers/wr/WebRenderTextureHost.cpp

@@ -80,7 +80,6 @@ void
 WebRenderTextureHost::Unlock()
 {
   MOZ_ASSERT_UNREACHABLE("unexpected to be called");
-  return;
 }
 
 bool

gfx/src/X11Util.cpp

@@ -32,7 +32,6 @@ FindVisualAndDepth(Display* aDisplay, VisualID aVisualID,
     NS_ASSERTION(aVisualID == X11None, "VisualID not on Screen.");
     *aVisual = nullptr;
     *aDepth = 0;
-    return;
 }
 
 void

ipc/glue/CrossProcessSemaphore_posix.cpp

@@ -135,11 +135,9 @@ CrossProcessSemaphore::Wait(const Maybe<TimeDuration>& aWaitTime)
     ts.tv_nsec %= kNsPerSec;
 
     while ((ret = sem_timedwait(mSemaphore, &ts)) == -1 && errno == EINTR) {
-      continue;
     }
   } else {
     while ((ret = sem_wait(mSemaphore)) == -1 && errno == EINTR) {
-      continue;
     }
   }
   return ret == 0;

js/src/gc/Nursery.cpp

@@ -194,7 +194,6 @@ js::Nursery::enable()
 #endif
 
     MOZ_ALWAYS_TRUE(runtime()->gc.storeBuffer().enable());
-    return;
 }
 
 void

js/src/irregexp/RegExpEngine.h

@@ -900,7 +900,6 @@ class BackReferenceNode : public SeqRegExpNode
                                       RegExpCompiler* compiler,
                                       int characters_filled_in,
                                       bool not_at_start) {
-        return;
     }
     virtual bool FillInBMInfo(int offset,
                               int budget,

js/src/jit/shared/Lowering-shared-inl.h

@@ -319,8 +319,6 @@ LIRGeneratorShared::defineSinCos(LInstructionHelper<2, Ops, Temps> *lir, MDefini
     lir->setMir(mir);
     mir->setVirtualRegister(vreg);
     add(lir);
-
-    return;
 }
 
 // In LIR, we treat booleans and integers as the same low-level type (INTEGER).

js/src/jit/x86-shared/AtomicOperations-x86-shared.h

@@ -362,7 +362,6 @@ js::jit::RegionLock::acquire(void* addr)
     uint32_t one = 1;
     while (!__atomic_compare_exchange(&spinlock, &zero, &one, false, __ATOMIC_ACQUIRE, __ATOMIC_ACQUIRE)) {
         zero = 0;
-        continue;
     }
 # endif
 }

js/src/jit/x86-shared/CodeGenerator-x86-shared.cpp

@@ -363,7 +363,6 @@ CodeGeneratorX86Shared::visitWasmSelect(LWasmSelect* ins)
     }
 
     masm.bind(&done);
-    return;
 }
 
 void

js/src/vm/Debugger.cpp

@@ -4684,8 +4684,6 @@ class MOZ_STACK_CLASS Debugger::ScriptQuery
                 return;
             }
         }
-
-        return;
     }
 
     /*

js/src/vm/ForOfIterator.cpp

@@ -197,9 +197,6 @@ ForOfIterator::closeThrow()
 
     // Step 6.
     cx_->setPendingException(completionException);
-
-    // Steps 7-9 (skipped).
-    return;
 }
 
 bool

js/src/vm/Unicode.cpp

@@ -3225,5 +3225,4 @@ js::unicode::AppendUpperCaseSpecialCasing(char16_t ch, char16_t* elements, size_
     }
 
     MOZ_ASSERT_UNREACHABLE("Bad character input.");
-    return;
 }

js/src/wasm/WasmCode.cpp

@@ -188,8 +188,6 @@ SendCodeRangesToProfiler(const CodeSegment& cs, const Bytes& bytecode, const Met
             vtune::MarkWasm(vtune::GenerateUniqueMethodID(), name.begin(), (void*)start, size);
 #endif
     }
-
-    return;
 }
 
 /* static */ UniqueConstCodeSegment

layout/generic/ReflowInput.cpp

@@ -1240,7 +1240,6 @@ ReflowInput::CalculateBorderPaddingMargin(
   outside -= inside;
   *aInsideBoxSizing = inside;
   *aOutsideBoxSizing = outside;
-  return;
 }
 
 /**

layout/generic/nsFrameSelection.cpp

@@ -617,8 +617,6 @@ nsFrameSelection::SetCaretBidiLevel(nsBidiLevel aLevel)
   if (mShell && (caret = mShell->GetCaret())) {
     caret->SchedulePaint();
   }
-
-  return;
 }
 
 nsBidiLevel

layout/generic/nsTextFrame.cpp

@@ -4625,7 +4625,6 @@ nsContinuingTextFrame::AddInlineMinISize(gfxContext *aRenderingContext,
                                          InlineMinISizeData *aData)
 {
   // Do nothing, since the first-in-flow accounts for everything.
-  return;
 }
 
 /* virtual */ void
@@ -4633,7 +4632,6 @@ nsContinuingTextFrame::AddInlinePrefISize(gfxContext *aRenderingContext,
                                           InlinePrefISizeData *aData)
 {
   // Do nothing, since the first-in-flow accounts for everything.
-  return;
 }
 
 //----------------------------------------------------------------------

layout/inspector/inDOMUtils.cpp

@@ -584,7 +584,6 @@ static void GetColorsForProperty(const uint32_t aParserVariant,
     }
     InsertNoDuplicates(aArray, NS_LITERAL_STRING("currentColor"));
   }
-  return;
 }
 
 static void GetOtherValuesForProperty(const uint32_t aParserVariant,

layout/style/nsCSSRuleProcessor.cpp

@@ -3949,7 +3949,6 @@ nsCSSRuleProcessor::RefreshRuleCascade(nsPresContext* aPresContext)
       mRuleCascades = newCascade.forget();
     }
   }
-  return;
 }
 
 /* static */ bool

layout/tables/nsTableFrame.cpp

@@ -2735,7 +2735,6 @@ nsTableFrame::HomogenousInsertFrames(ChildListID     aListID,
   printf("=== TableFrame::InsertFrames\n");
   Dump(true, true, true);
 #endif
-  return;
 }
 
 void

layout/xul/nsXULTooltipListener.cpp

@@ -565,8 +565,6 @@ GetImmediateChild(nsIContent* aContent, nsIAtom *aTag, nsIContent** aResult)
       return;
     }
   }
-
-  return;
 }
 
 nsresult

media/mtransport/nricectx.cpp

@@ -1170,6 +1170,4 @@ void nr_ice_compute_codeword(char *buf, int len,char *codeword) {
 
     PL_Base64Encode(reinterpret_cast<char*>(&c), 3, codeword);
     codeword[4] = 0;
-
-    return;
 }

media/webrtc/signaling/src/common/browser_logging/WebRtcLog.cpp

@@ -196,7 +196,6 @@ void ConfigWebRtcLog(mozilla::LogLevel level, uint32_t trace_mask,
     // Capture the final choice for the trace setting.
     mozilla::Preferences::SetCString("media.webrtc.debug.log_file", aLogFile);
   }
-  return;
 }
 
 void StartWebRtcLog(uint32_t log_level)
@@ -226,7 +225,6 @@ void StartWebRtcLog(uint32_t log_level)
   }
 
   ConfigWebRtcLog(level, trace_mask, log_file, aec_log_dir, multi_log);
-  return;
 
 }
 
@@ -244,7 +242,6 @@ void EnableWebRtcLog()
   GetWebRtcLogPrefs(&trace_mask, &log_file, &aec_log_dir, &multi_log);
   mozilla::LogLevel level = CheckOverrides(&trace_mask, &log_file, &multi_log);
   ConfigWebRtcLog(level, trace_mask, log_file, aec_log_dir, multi_log);
-  return;
 }
 
 // Called when we destroy the singletons from PeerConnectionCtx or if the

media/webrtc/signaling/src/peerconnection/WebrtcGlobalInformation.cpp

@@ -530,7 +530,6 @@ WebrtcGlobalInformation::GetAllStats(
   }
 
   aRv = rv;
-  return;
 }
 
 static nsresult
@@ -659,7 +658,6 @@ WebrtcGlobalInformation::GetLogging(
   }
 
   aRv = rv;
-  return;
 }
 
 static int32_t sLastSetLevel = 0;
@@ -806,7 +804,6 @@ void
 WebrtcGlobalParent::ActorDestroy(ActorDestroyReason aWhy)
 {
   mShutdown = true;
-  return;
 }
 
 mozilla::ipc::IPCResult

mfbt/LinkedList.h

@@ -527,7 +527,6 @@ public:
   void clear()
   {
     while (popFirst()) {
-      continue;
     }
   }
 

mfbt/SplayTree.h

@@ -88,7 +88,6 @@ public:
     int cmp = Comparator::compare(*aValue, *last);
 
     finishInsertion(last, cmp, aValue);
-    return;
   }
 
   T* findOrInsert(const T& aValue);

mozglue/misc/TimeStamp_posix.cpp

@@ -192,8 +192,6 @@ TimeStamp::Startup()
        sResolutionSigDigs *= 10);
 
   gInitialized = true;
-
-  return;
 }
 
 void

netwerk/base/nsURLParsers.cpp

@@ -483,7 +483,7 @@ nsAuthURLParser::ParseAuthority(const char *auth, int32_t authLen,
     // search backwards for @
     const char *p = auth + authLen - 1;
     for (; (*p != '@') && (p > auth); --p) {
-      continue;
+        continue; 
     }
     if ( *p == '@' ) {
         // auth = <user-info@server-info>

netwerk/cookie/CookieServiceParent.cpp

@@ -54,7 +54,6 @@ CreateDummyChannel(nsIURI* aHostURI, OriginAttributes& aAttrs, nsIChannel** aCha
 
   pbChannel->SetPrivate(aAttrs.mPrivateBrowsingId > 0);
   dummyChannel.forget(aChannel);
-  return;
 }
 
 }

netwerk/protocol/ftp/FTPChannelParent.cpp

@@ -758,7 +758,6 @@ FTPChannelParent::DivertTo(nsIStreamListener *aListener)
     NewRunnableMethod("net::FTPChannelParent::StartDiversion",
                       this,
                       &FTPChannelParent::StartDiversion));
-  return;
 }
 
 void

netwerk/protocol/http/Http2Compression.cpp

@@ -1458,7 +1458,6 @@ Http2Compressor::ProcessHeader(const nvPair inputPair, bool noLocalIndex,
 
   LOG(("Compressor state after index"));
   DumpState();
-  return;
 }
 
 void

netwerk/protocol/http/Http2Stream.cpp

@@ -1157,7 +1157,6 @@ Http2Stream::SetAllHeadersReceived()
     MapStreamToHttpConnection();
     ClearTransactionsBlockedOnTunnel();
   }
-  return;
 }
 
 bool

netwerk/protocol/http/HttpChannelParent.cpp

@@ -1341,7 +1341,6 @@ HttpChannelParent::MaybeFlushPendingDiversion()
     DivertTo(mDivertListener);
   }
 
-  return;
 }
 
 void
@@ -1976,7 +1975,6 @@ HttpChannelParent::DivertTo(nsIStreamListener *aListener)
     NewRunnableMethod("net::HttpChannelParent::StartDiversion",
                       this,
                       &HttpChannelParent::StartDiversion));
-  return;
 }
 
 void

netwerk/protocol/http/TunnelUtils.cpp

@@ -982,7 +982,6 @@ SpdyConnectTransaction::ForcePlainText()
   MOZ_ASSERT(!mTunnelTransport, "call before mapstreamtohttpconnection");
 
   mForcePlainText = true;
-  return;
 }
 
 void

netwerk/protocol/http/nsAHttpConnection.h

@@ -68,7 +68,6 @@ public:
     virtual void TransactionHasDataToWrite(nsAHttpTransaction *)
     {
         // by default do nothing - only multiplexed protocols need to overload
-        return;
     }
 
     // This is the companion to *HasDataToWrite() for the case
@@ -76,7 +75,6 @@ public:
     virtual void TransactionHasDataToRecv(nsAHttpTransaction *)
     {
         // by default do nothing - only multiplexed protocols need to overload
-        return;
     }
 
     // called by the connection manager to close a transaction being processed

netwerk/protocol/http/nsHttpChannel.cpp

@@ -2844,8 +2844,6 @@ nsHttpChannel::HandleAsyncAPIRedirect()
                  static_cast<uint32_t>(rv), this));
         }
     }
-
-    return;
 }
 
 nsresult

netwerk/sctp/datachannel/DataChannel.cpp

@@ -605,7 +605,6 @@ DataChannelConnection::CompleteConnect(TransportFlow *flow, TransportLayer::Stat
   Dispatch(do_AddRef(new DataChannelOnMessageAvailable(
              DataChannelOnMessageAvailable::ON_CONNECTION,
              this)));
-  return;
 }
 
 // Process any pending Opens

netwerk/streamconv/converters/mozTXTToHTMLConv.cpp

@@ -57,8 +57,6 @@ mozTXTToHTMLConv::EscapeChar(const char16_t ch, nsString& aStringToAppendTo,
     default:
       aStringToAppendTo += ch;
     }
-
-    return;
 }
 
 // EscapeStr takes the passed in string and
@@ -387,7 +385,6 @@ mozTXTToHTMLConv::CalculateURLBoundaries(const char16_t * aInString, int32_t aIn
   nsAutoString temp2;
   ScanTXT(&aInString[descstart], pos - descstart, ~kURLs /*prevents loop*/ & whathasbeendone, temp2);
   replaceBefore = temp2.Length();
-  return;
 }
 
 bool mozTXTToHTMLConv::ShouldLinkify(const nsCString& aURL)

netwerk/streamconv/converters/nsUnknownDecoder.cpp

@@ -701,7 +701,6 @@ bool nsUnknownDecoder::LastDitchSniff(nsIRequest* aRequest)
   //
   uint32_t i;
   for (i = 0; i < testDataLen && IS_TEXT_CHAR(testData[i]); i++) {
-    continue;
   }
 
   if (i == testDataLen) {

parser/html/nsHtml5Parser.cpp

@@ -713,7 +713,6 @@ nsHtml5Parser::ParseUntilBlocked()
         return NS_OK;
       }
     }
-    continue;
   }
 }
 

parser/html/nsHtml5StreamParser.cpp

@@ -1506,7 +1506,6 @@ nsHtml5StreamParser::ParseAvailableData()
         return;
       }
     }
-    continue;
   }
 }
 

parser/html/nsHtml5Tokenizer.cpp

@@ -1806,7 +1806,6 @@ nsHtml5Tokenizer::stateLoop(int32_t state, char16_t c, int32_t pos, char16_t* bu
             NS_HTML5_BREAK(outer);
           }
           appendCharRefBuf(c);
-          continue;
         }
         outer_end: ;
         if (candidate == -1) {
@@ -4355,7 +4354,6 @@ nsHtml5Tokenizer::eof()
           if (hi < lo) {
             NS_HTML5_BREAK(outer);
           }
-          continue;
         }
         outer_end: ;
         if (candidate == -1) {
@@ -4435,7 +4433,6 @@ nsHtml5Tokenizer::eof()
   }
   eofloop_end: ;
   tokenHandler->eof();
-  return;
 }
 
 void 

parser/html/nsHtml5TreeBuilder.cpp

@@ -204,7 +204,6 @@ nsHtml5TreeBuilder::doctype(nsIAtom* name,
     return;
   }
   errStrayDoctype();
-  return;
 }
 
 void 
@@ -232,7 +231,6 @@ nsHtml5TreeBuilder::comment(char16_t* buf, int32_t start, int32_t length)
   }
   flushCharacters();
   appendComment(stack[currentPtr]->node, buf, start, length);
-  return;
 }
 
 void 
@@ -3343,7 +3341,6 @@ nsHtml5TreeBuilder::closeTheCell(int32_t eltPos)
   }
   clearTheListOfActiveFormattingElementsUpToTheLastMarker();
   mode = IN_ROW;
-  return;
 }
 
 int32_t 

parser/html/nsHtml5TreeBuilderCppSupplement.h

@@ -924,7 +924,6 @@ nsHtml5TreeBuilder::elementPopped(int32_t aNamespace, nsIAtom* aName, nsIContent
     // See comments in nsHtml5SpeculativeLoad.h about <picture> preloading
     mSpeculativeLoadQueue.AppendElement()->InitEndPicture();
   }
-  return;
 }
 
 void

security/manager/ssl/nsKeygenThread.cpp

@@ -253,6 +253,4 @@ void nsKeygenThread::Join()
 
   PR_JoinThread(threadHandle);
   threadHandle = nullptr;
-
-  return;
 }

toolkit/components/ctypes/tests/jsctypes-test.cpp

@@ -37,7 +37,6 @@ void
 test_void_t_cdecl()
 {
   // do nothing
-  return;
 }
 
 // The "AndUnderscore" bit here is an unfortunate hack: the first argument to

toolkit/components/diskspacewatcher/DiskSpaceWatcher.cpp

@@ -126,7 +126,6 @@ void DiskSpaceWatcher::UpdateState(bool aIsDiskFull, uint64_t aFreeSpace)
   observerService->NotifyObservers(subject,
                                    DISKSPACEWATCHER_OBSERVER_TOPIC,
                                    sIsDiskFull ? stateFull : stateFree);
-  return;
 }
 
 NS_GENERIC_FACTORY_SINGLETON_CONSTRUCTOR(DiskSpaceWatcher,

toolkit/components/perfmonitoring/nsPerformanceStats.cpp

@@ -1226,8 +1226,6 @@ nsPerformanceStatsService::CommitGroup(uint64_t iteration,
       return;
     }
   }
-
-  return;
 }
 
 nsresult

toolkit/components/telemetry/tests/modules-test.cpp

@@ -24,6 +24,5 @@
 
 void nothing()
 {
-  return;
 }
 

toolkit/components/url-classifier/LookupCache.cpp

@@ -281,8 +281,6 @@ LookupCache::GetCacheInfo(nsIUrlClassifierCacheInfo** aCache)
   }
 
   NS_ADDREF(*aCache = info);
-
-  return;
 }
 
 /* static */ bool

toolkit/components/url-classifier/nsUrlClassifierUtils.cpp

@@ -722,7 +722,6 @@ nsUrlClassifierUtils::ParseIPAddress(const nsACString & host,
       _retval.Append(canonical);
     }
   }
-  return;
 }
 
 void

uriloader/exthandler/nsExternalHelperAppService.cpp

@@ -1575,7 +1575,6 @@ nsExternalAppHandler::MaybeApplyDecodingForExtension(nsIRequest *aRequest)
   }
 
   encChannel->SetApplyConversion( applyConversion );
-  return;
 }
 
 NS_IMETHODIMP nsExternalAppHandler::OnStartRequest(nsIRequest *request, nsISupports * aCtxt)

widget/WidgetEventImpl.cpp

@@ -867,7 +867,6 @@ WidgetKeyboardEvent::GetAccessKeyCandidates(nsTArray<uint32_t>& aCandidates) con
       mCodeNameIndex == CODE_NAME_INDEX_Space && mCharCode != ' ') {
     aCandidates.AppendElement(' ');
   }
-  return;
 }
 
 /* static */ void

widget/gtkxtbin/gtk2xtbin.c

@@ -854,7 +854,5 @@ xt_add_focus_listener_tree ( Widget treeroot, XtPointer user_data)
       xt_add_focus_listener_tree( child, user_data);
   }
   XFree((void*)children);
-
-  return;
 }
 

xpcom/components/nsComponentManager.cpp

@@ -596,7 +596,6 @@ nsComponentManagerImpl::ManifestBinaryComponent(ManifestProcessingContext& aCx,
 {
   LogMessageWithContext(aCx.mFile, aLineNo,
                         "Binary XPCOM components are no longer supported.");
-  return;
 }
 
 static void

xpcom/tests/gtest/TestSTLWrappers.cpp

@@ -65,7 +65,6 @@ void ShouldAbort()
 
     fputs("TEST-FAIL | TestSTLWrappers.cpp | didn't abort()?\n",
           stderr);
-    return;
 }
 
 #ifdef XP_WIN