Bug 1345153 - Suppress valgrind warnings for PR_SetEnv in SetupCrashReporterDirectory. r=njn

MozReview-Commit-ID: 4vV2EHsgTVT

--HG--
extra : rebase_source : c5af8757174610879dd7234d9d699483cf235bdf

build/valgrind/cross-architecture.sup

@@ -34,6 +34,14 @@
    fun:_ZN13CrashReporter14SetupExtraDataEP7nsIFileRK10nsACString
    ...
 }
+{
+   PR_SetEnv requires its argument to be leaked, but does not appear on stacks. (See bug 1345153.)
+   Memcheck:Leak
+   fun:malloc
+   ...
+   fun:_ZN13CrashReporterL27SetupCrashReporterDirectoryEP7nsIFilePKcS3_PS1_
+   ...
+}
 {
    We purposely leak the StatisticsReporter object
    Memcheck:Leak

toolkit/crashreporter/nsExceptionHandler.cpp

@@ -1993,6 +1993,7 @@ SetupCrashReporterDirectory(nsIFile* aAppDataDirectory,
 #else
   XP_CHAR* str = new XP_CHAR[dirEnv.size() + 1];
   strncpy(str, dirEnv.c_str(), dirEnv.size() + 1);
+  // |PR_SetEnv| requires str to leak.
   PR_SetEnv(str);
 #endif