Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/storage. r=dom-workers-and-storage-reviewers,janv

Differential Revision: https://phabricator.services.mozilla.com/D62560

--HG--
extra : moz-landing-system : lando

dom/storage/LocalStorage.cpp

@@ -60,7 +60,7 @@ LocalStorage::LocalStorage(nsPIDOMWindowInner* aWindow,
   mCache->Preload();
 }
 
-LocalStorage::~LocalStorage() {}
+LocalStorage::~LocalStorage() = default;
 
 int64_t LocalStorage::GetOriginQuotaUsage() const {
   return mCache->GetOriginQuotaUsage(this);

dom/storage/LocalStorageCache.h

@@ -62,7 +62,7 @@ class LocalStorageCacheBridge {
   virtual void LoadWait() = 0;
 
  protected:
-  virtual ~LocalStorageCacheBridge() {}
+  virtual ~LocalStorageCacheBridge() = default;
 
   ThreadSafeAutoRefCnt mRefCnt;
   NS_DECL_OWNINGTHREAD
@@ -282,7 +282,7 @@ class StorageUsageBridge {
 
  protected:
   // Protected destructor, to discourage deletion outside of Release():
-  virtual ~StorageUsageBridge() {}
+  virtual ~StorageUsageBridge() = default;
 };
 
 class StorageUsage : public StorageUsageBridge {

dom/storage/PartitionedLocalStorage.cpp

@@ -25,7 +25,7 @@ PartitionedLocalStorage::PartitionedLocalStorage(
     nsIPrincipal* aStoragePrincipal, SessionStorageCache* aCache)
     : Storage(aWindow, aPrincipal, aStoragePrincipal), mCache(aCache) {}
 
-PartitionedLocalStorage::~PartitionedLocalStorage() {}
+PartitionedLocalStorage::~PartitionedLocalStorage() = default;
 
 int64_t PartitionedLocalStorage::GetOriginQuotaUsage() const {
   return mCache->GetOriginQuotaUsage(SessionStorageCache::eSessionSetType);

dom/storage/SessionStorage.cpp

@@ -42,7 +42,7 @@ SessionStorage::SessionStorage(nsPIDOMWindowInner* aWindow,
   MOZ_ASSERT(aCache);
 }
 
-SessionStorage::~SessionStorage() {}
+SessionStorage::~SessionStorage() = default;
 
 int64_t SessionStorage::GetOriginQuotaUsage() const {
   return mCache->GetOriginQuotaUsage(DATASET);

dom/storage/StorageDBThread.cpp

@@ -796,7 +796,7 @@ class OriginAttrsPatternMatchSQLFunction final : public mozIStorageFunction {
 
  private:
   OriginAttrsPatternMatchSQLFunction() = delete;
-  ~OriginAttrsPatternMatchSQLFunction() {}
+  ~OriginAttrsPatternMatchSQLFunction() = default;
 
   OriginAttributesPattern mPattern;
 };

dom/storage/StorageDBThread.h

@@ -280,7 +280,7 @@ class StorageDBThread final {
     Monitor& GetMonitor() { return mMonitor; }
 
    private:
-    virtual ~ThreadObserver() {}
+    virtual ~ThreadObserver() = default;
     bool mHasPendingEvents;
     // The monitor we drive the thread with
     Monitor mMonitor;
@@ -301,14 +301,14 @@ class StorageDBThread final {
     }
 
    private:
-    ~ShutdownRunnable() {}
+    ~ShutdownRunnable() = default;
 
     NS_DECL_NSIRUNNABLE
   };
 
  public:
   StorageDBThread();
-  virtual ~StorageDBThread() {}
+  virtual ~StorageDBThread() = default;
 
   static StorageDBThread* Get();
 

dom/storage/StorageDBUpdater.cpp

@@ -25,7 +25,7 @@ using namespace StorageUtils;
 namespace {
 
 class nsReverseStringSQLFunction final : public mozIStorageFunction {
-  ~nsReverseStringSQLFunction() {}
+  ~nsReverseStringSQLFunction() = default;
 
   NS_DECL_ISUPPORTS
   NS_DECL_MOZISTORAGEFUNCTION
@@ -148,7 +148,7 @@ class GetOriginParticular final : public mozIStorageFunction {
 
  private:
   GetOriginParticular() = delete;
-  ~GetOriginParticular() {}
+  ~GetOriginParticular() = default;
 
   EParticular mParticular;
 
@@ -189,10 +189,10 @@ GetOriginParticular::OnFunctionCall(mozIStorageValueArray* aFunctionArguments,
 
 class StripOriginAddonId final : public mozIStorageFunction {
  public:
-  explicit StripOriginAddonId() {}
+  explicit StripOriginAddonId() = default;
 
  private:
-  ~StripOriginAddonId() {}
+  ~StripOriginAddonId() = default;
 
   NS_DECL_ISUPPORTS
   NS_DECL_MOZISTORAGEFUNCTION

dom/storage/StorageIPC.cpp

@@ -132,7 +132,7 @@ StorageDBChild::StorageDBChild(LocalStorageManager* aManager)
   MOZ_ASSERT(!NextGenLocalStorageEnabled());
 }
 
-StorageDBChild::~StorageDBChild() {}
+StorageDBChild::~StorageDBChild() = default;
 
 // static
 StorageDBChild* StorageDBChild::Get() {

dom/storage/StorageIPC.h

@@ -276,7 +276,7 @@ class StorageDBParent final : public PBackgroundStorageParent {
           mOriginNoSuffix(aOriginNoSuffix),
           mLoaded(false),
           mLoadedCount(0) {}
-    virtual ~CacheParentBridge() {}
+    virtual ~CacheParentBridge() = default;
 
     // LocalStorageCacheBridge
     virtual const nsCString Origin() const override;
@@ -315,7 +315,7 @@ class StorageDBParent final : public PBackgroundStorageParent {
         : mOwningEventTarget(GetCurrentThreadSerialEventTarget()),
           mParent(aParentDB),
           mOriginScope(aOriginScope) {}
-    virtual ~UsageParentBridge() {}
+    virtual ~UsageParentBridge() = default;
 
     // StorageUsageBridge
     virtual const nsCString& OriginScope() override { return mOriginScope; }

dom/storage/StorageObserver.h

@@ -24,7 +24,7 @@ class StorageObserver;
 // content processes.
 class StorageObserverSink {
  public:
-  virtual ~StorageObserverSink() {}
+  virtual ~StorageObserverSink() = default;
 
  private:
   friend class StorageObserver;
@@ -53,7 +53,7 @@ class StorageObserver : public nsIObserver, public nsSupportsWeakReference {
   void NoteBackgroundThread(nsIEventTarget* aBackgroundThread);
 
  private:
-  virtual ~StorageObserver() {}
+  virtual ~StorageObserver() = default;
 
   nsresult GetOriginScope(const char16_t* aData, nsACString& aOriginScope);