mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1659430: Add "reftest-wait" to WPT increase-prev-sibling-height.html, to address intermittent failures. r=hiro 

This test has some JS that restyles an element, and the test implicitly expects
this JS to run before the screenshot is taken (otherwise the test fails).

However: before this patch, I don't think there's anything stopping the
test-harness from taking its screenshot earlier -- the screenshot can happen as
soon as the load event fires (and after any pending paints at that point are
flushed).  This may be before the test's requestAnimationFrame-triggered JS has
been run.

This patch addresses this issue by adding 'reftest-wait', which explicitly
requires the test harness to delay its screenshot until after the restyle has
occurred.

Differential Revision: https://phabricator.services.mozilla.com/D110493
This commit is contained in:
Daniel Holbert 2021-04-01 05:39:14 +00:00
Родитель 402802eb42
Коммит 7d8f2e48b1
2 изменённых файлов: 4 добавлений и 6 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

5
testing/web-platform/meta/css/css-multicol/increase-prev-sibling-height.html.ini
Просмотреть файл

@ -1,5 +0,0 @@
[increase-prev-sibling-height.html]
expected:
if (os == "linux") and debug and webrender and not fission: ["PASS", "FAIL"]
if (os == "mac") and debug and webrender: ["PASS", "FAIL"]
if (os == "win") and webrender: ["PASS", "FAIL"]

5
testing/web-platform/tests/css/css-multicol/increase-prev-sibling-height.html
Просмотреть файл

@ -1,4 +1,5 @@
<!DOCTYPE html>
<html class="reftest-wait">
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://www.w3.org/TR/css-multicol-1/">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1066640">
@ -11,7 +12,9 @@
<script>
requestAnimationFrame(()=>{
requestAnimationFrame(()=>{
elm.style.height = "2em";
elm.style.height = "2em";
document.documentElement.classList.remove("reftest-wait");
});
});
</script>
</html>