Bug 1719463 - Part 6: Remove the Library item from the pre-proton appMenu view. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D121806

browser/base/content/appmenu-viewcache.inc.xhtml

@@ -6,11 +6,6 @@
   <panelview id="appMenu-mainView" class="PanelUI-subView"
              descriptionheightworkaround="true">
     <vbox class="panel-subview-body">
-      <toolbarbutton id="appMenu-library-button"
-                     class="subviewbutton subviewbutton-iconic subviewbutton-nav"
-                     label="&places.library.title;"
-                     closemenu="none"
-                     oncommand="PanelUI.showSubView('appMenu-libraryView', this)"/>
       <toolbarbutton id="appMenu-logins-button"
                      class="subviewbutton subviewbutton-iconic"
                      label="&logins.label;"

browser/components/uitour/UITour.jsm

@@ -159,7 +159,6 @@ var UITour = {
     ],
     ["help", { query: "#appMenu-help-button" }],
     ["home", { query: "#home-button" }],
-    ["library", { query: "#appMenu-library-button" }],
     [
       "logins",
       {

browser/components/uitour/test/browser_UITour5.js

@@ -27,10 +27,10 @@ add_UITour_task(async function test_highlight_help_and_show_help_subview() {
   is(
     getShowHighlightTargetName(),
     "help",
-    "Should highlight the library button on the app menu"
+    "Should highlight the help button on the app menu"
   );
 
-  // Click the library button to show the subview
+  // Click the help button to show the subview
   let ViewShownPromise = new Promise(resolve => {
     appMenu.addEventListener("ViewShown", resolve, { once: true });
   });

browser/components/uitour/test/browser_UITour_availableTargets.js

@@ -16,7 +16,6 @@ function getExpectedTargets() {
     "backForward",
     "devtools",
     "help",
-    "library",
     "logins",
     "pageAction-bookmark",
     ...(hasPocket ? ["pocket"] : []),