diff --git a/dom/plugins/base/nsPluginHost.cpp b/dom/plugins/base/nsPluginHost.cpp index 14a12164a605..80fb6e38c7f8 100644 --- a/dom/plugins/base/nsPluginHost.cpp +++ b/dom/plugins/base/nsPluginHost.cpp @@ -2201,7 +2201,7 @@ nsresult nsPluginHost::ScanPluginsDirectory(nsIFile *pluginsDir, // Avoid adding different versions of the same plugin if they are running // in-process, otherwise we risk undefined behaviour. if (!nsNPAPIPlugin::RunPluginOOP(pluginTag)) { - if (nsPluginTag *duplicate = HaveSamePlugin(pluginTag)) { + if (HaveSamePlugin(pluginTag)) { continue; } } diff --git a/dom/plugins/ipc/PluginInstanceParent.cpp b/dom/plugins/ipc/PluginInstanceParent.cpp index 7a4b488ab62d..02e062caa5c5 100644 --- a/dom/plugins/ipc/PluginInstanceParent.cpp +++ b/dom/plugins/ipc/PluginInstanceParent.cpp @@ -12,7 +12,6 @@ #include "StreamNotifyParent.h" #include "npfunctions.h" #include "nsAutoPtr.h" -#include "mozilla/unused.h" #include "gfxASurface.h" #include "gfxContext.h" #include "gfxPlatform.h" diff --git a/dom/plugins/ipc/PluginInstanceParent.h b/dom/plugins/ipc/PluginInstanceParent.h index 859274468663..8df73d279552 100644 --- a/dom/plugins/ipc/PluginInstanceParent.h +++ b/dom/plugins/ipc/PluginInstanceParent.h @@ -28,6 +28,7 @@ class gfxXlibSurface; #endif #include "nsGUIEvent.h" +#include "mozilla/unused.h" namespace mozilla { namespace plugins { @@ -280,7 +281,7 @@ public: nsresult HandleGUIEvent(const nsGUIEvent& anEvent, bool* handled); #endif - void DidComposite() { SendNPP_DidComposite(); } + void DidComposite() { unused << SendNPP_DidComposite(); } private: // Create an appropriate platform surface for a background of size diff --git a/widget/cocoa/nsFilePicker.mm b/widget/cocoa/nsFilePicker.mm index 17de5812f3e7..5f02f021f173 100644 --- a/widget/cocoa/nsFilePicker.mm +++ b/widget/cocoa/nsFilePicker.mm @@ -521,8 +521,7 @@ nsFilePicker::GetFilterList() NSMutableString* filterString = [[[NSMutableString alloc] initWithString: [NSString stringWithCharacters:filterWide.get() length:filterWide.Length()]] autorelease]; - NSCharacterSet *set = [NSCharacterSet characterSetWithCharactersInString: - [NSString stringWithString:@". *"]]; + NSCharacterSet *set = [NSCharacterSet characterSetWithCharactersInString:@". *"]; NSRange range = [filterString rangeOfCharacterFromSet:set]; while (range.length) { [filterString replaceCharactersInRange:range withString:@""];