Bug 783409: Enable "layout.css.flexbox.enabled" pref. r=dbaron

layout/reftests/flexbox/reftest.list

@@ -1,31 +1,20 @@
-# Tests for flexbox pref "layout.css.flexbox.enabled"
-# (Note that it defaults to off for now)
-== flexbox-pref-1.xhtml flexbox-pref-1-disabled-ref.xhtml
+# Check that flexbox pref is default-enabled:
+== flexbox-pref-1.xhtml flexbox-pref-1-enabled-ref.xhtml
+
+# Check that manually setting the pref on/off w/ test-pref() works correctly:
 test-pref(layout.css.flexbox.enabled,false) == flexbox-pref-1.xhtml flexbox-pref-1-disabled-ref.xhtml
 test-pref(layout.css.flexbox.enabled,true) == flexbox-pref-1.xhtml flexbox-pref-1-enabled-ref.xhtml
 
-# Enable pref for remaining tests
-# (Most tests only need it in the testcase, but a few use it in the
-# reference case, so we'll just enable it using "pref()" to make
-# it available for both.)
-default-preferences pref(layout.css.flexbox.enabled,true)
-
 # Tests for cross-axis alignment (align-self / align-items properties)
 == flexbox-align-self-baseline-horiz-1.xhtml  flexbox-align-self-baseline-horiz-1-ref.xhtml
 fails == flexbox-align-self-baseline-horiz-2.xhtml  flexbox-align-self-baseline-horiz-2-ref.xhtml # bug 793456, and possibly others
 # This one fails on windows R (but not Ru, strangely). On Windows R, the
 # single-line <label> flex item has a different background size in test vs. ref
 random-if(winWidget) == flexbox-align-self-baseline-horiz-3.xhtml  flexbox-align-self-baseline-horiz-3-ref.xhtml # XXXdholbert investigate
-# XXXdholbert This test needs the flexbox pref to be enabled _at startup time_
-# (when we parse ua.css) in order to pass -- so it'll fail until we enable the
-# flexbox pref by default (bug 783409):
-fails == flexbox-align-self-baseline-horiz-4.xhtml flexbox-align-self-baseline-horiz-4-ref.xhtml
+== flexbox-align-self-baseline-horiz-4.xhtml flexbox-align-self-baseline-horiz-4-ref.xhtml
 
 == flexbox-align-self-horiz-1-block.xhtml  flexbox-align-self-horiz-1-ref.xhtml
-# XXXdholbert This test needs the flexbox pref to be enabled _at startup time_
-# (when we parse ua.css) in order to pass -- so it'll fail until we enable the
-# flexbox pref by default (bug 783409):
-fails == flexbox-align-self-horiz-1-table.xhtml  flexbox-align-self-horiz-1-ref.xhtml
+== flexbox-align-self-horiz-1-table.xhtml  flexbox-align-self-horiz-1-ref.xhtml
 == flexbox-align-self-horiz-2.xhtml  flexbox-align-self-horiz-2-ref.xhtml
 == flexbox-align-self-horiz-3.xhtml  flexbox-align-self-horiz-3-ref.xhtml
 == flexbox-align-self-horiz-4.xhtml  flexbox-align-self-horiz-4-ref.xhtml

layout/style/test/test_flexbox_align_self_auto.html

@@ -30,10 +30,9 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=696253
 
 SimpleTest.waitForExplicitFinish();
 
-ok(!SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
-   "expecting flexbox pref to be disabled by default");
+ok(SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
+   "expecting flexbox pref to be enabled by default");
 
-SpecialPowers.setBoolPref("layout.css.flexbox.enabled", true);
 document.getElementById("iframe").src = "file_flexbox_align_self_auto.html";
 
 function finish() {

layout/style/test/test_flexbox_child_display_values.html

@@ -30,10 +30,9 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=783415
 
 SimpleTest.waitForExplicitFinish();
 
-ok(!SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
-   "expecting flexbox pref to be disabled by default");
+ok(SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
+   "expecting flexbox pref to be enabled by default");
 
-SpecialPowers.setBoolPref("layout.css.flexbox.enabled", true);
 document.getElementById("iframe").src =
   "file_flexbox_child_display_values.xhtml";
 

layout/style/test/test_flexbox_flex_grow_and_shrink.html

@@ -30,10 +30,9 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=696253
 
 SimpleTest.waitForExplicitFinish();
 
-ok(!SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
-   "expecting flexbox pref to be disabled by default");
+ok(SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
+   "expecting flexbox pref to be enabled by default");
 
-SpecialPowers.setBoolPref("layout.css.flexbox.enabled", true);
 document.getElementById("iframe").src =
   "file_flexbox_flex_grow_and_shrink.html";
 

layout/style/test/test_flexbox_flex_shorthand.html

@@ -30,10 +30,9 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=696253
 
 SimpleTest.waitForExplicitFinish();
 
-ok(!SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
-   "expecting flexbox pref to be disabled by default");
+ok(SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
+   "expecting flexbox pref to be enabled by default");
 
-SpecialPowers.setBoolPref("layout.css.flexbox.enabled", true);
 document.getElementById("iframe").src = "file_flexbox_flex_shorthand.html";
 
 function finish() {

layout/style/test/test_flexbox_layout.html

@@ -30,10 +30,9 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=666041
 
 SimpleTest.waitForExplicitFinish();
 
-ok(!SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
-   "expecting flexbox pref to be disabled by default");
+ok(SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
+   "expecting flexbox pref to be enabled by default");
 
-SpecialPowers.setBoolPref("layout.css.flexbox.enabled", true);
 document.getElementById("iframe").src = "file_flexbox_layout.html";
 
 function finish() {

layout/style/test/test_flexbox_min_size_auto.html

@@ -30,10 +30,9 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=763689
 
 SimpleTest.waitForExplicitFinish();
 
-ok(!SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
-   "expecting flexbox pref to be disabled by default");
+ok(SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
+   "expecting flexbox pref to be enabled by default");
 
-SpecialPowers.setBoolPref("layout.css.flexbox.enabled", true);
 document.getElementById("iframe").src = "file_flexbox_min_size_auto.html";
 
 function finish() {

layout/style/test/test_flexbox_order.html

@@ -30,10 +30,9 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=666041
 
 SimpleTest.waitForExplicitFinish();
 
-ok(!SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
-   "expecting flexbox pref to be disabled by default");
+ok(SpecialPowers.getBoolPref("layout.css.flexbox.enabled"),
+   "expecting flexbox pref to be enabled by default");
 
-SpecialPowers.setBoolPref("layout.css.flexbox.enabled", true);
 document.getElementById("iframe").src = "file_flexbox_order.html";
 
 function finish() {

modules/libpref/src/init/all.js

@@ -1622,7 +1622,7 @@ pref("layout.css.devPixelsPerPx", "-1.0");
 pref("layout.css.supports-rule.enabled", true);
 
 // Is support for CSS Flexbox enabled?
-pref("layout.css.flexbox.enabled", false);
+pref("layout.css.flexbox.enabled", true);
 
 // Are sets of prefixed properties supported?
 pref("layout.css.prefixes.border-image", true);