From 806eded4d9bf29cdcafa5ac14907d0d09640e3ad Mon Sep 17 00:00:00 2001 From: Shawn Wilsher Date: Thu, 25 Sep 2008 13:50:41 -0400 Subject: [PATCH] Bug 456910 - Stop using exclusive locking in places This allows us to greatly reduce the number of fsyncs when upgrading to sqlite. The perf loss in no longer using this locking is not significant (10^-6 %). r=dietrich --- toolkit/components/places/src/nsNavHistory.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/toolkit/components/places/src/nsNavHistory.cpp b/toolkit/components/places/src/nsNavHistory.cpp index 901b7c31c8f6..66d2a027f400 100644 --- a/toolkit/components/places/src/nsNavHistory.cpp +++ b/toolkit/components/places/src/nsNavHistory.cpp @@ -794,12 +794,6 @@ nsNavHistory::InitDB(PRInt16 *aMadeChanges) rv = mDBConn->ExecuteSimpleSQL(cacheSizePragma); NS_ENSURE_SUCCESS(rv, rv); - // lock the db file - // http://www.sqlite.org/pragma.html#pragma_locking_mode - rv = mDBConn->ExecuteSimpleSQL( - NS_LITERAL_CSTRING("PRAGMA locking_mode = EXCLUSIVE")); - NS_ENSURE_SUCCESS(rv, rv); - // moz_places if (!tableExists) { *aMadeChanges = DB_MIGRATION_CREATED;