Bug 1635983 - Enable gecko-profiling perfherder data submission in raptor-browsertime r=perftest-reviewers,sparky

Differential Revision: https://phabricator.services.mozilla.com/D128528

taskcluster/docker/visual-metrics/run-visual-metrics.py

@@ -187,13 +187,17 @@ def append_result(log, suites, test_name, name, result, tags, extra_options):
         },
     )["subtests"]
 
+    should_alert = SHOULD_ALERT.get(name, False)
+    if "gecko-profile" in extra_options:
+        should_alert = False
+
     if name not in subtests:
         subtests[name] = {
             "name": name,
             "replicates": [result],
             "lowerIsBetter": True,
             "unit": "ms",
-            "shouldAlert": SHOULD_ALERT.get(name, False),
+            "shouldAlert": should_alert,
         }
     else:
         subtests[name]["replicates"].append(result)

testing/raptor/raptor/output.py

@@ -196,11 +196,17 @@ class PerftestOutput(object):
             )
         else:
             for suite in self.summarized_results["suites"]:
-                tname = suite["name"]
+                gecko_profiling_enabled = "gecko-profile" in suite.get(
+                    "extraOptions", []
+                )
+                if gecko_profiling_enabled:
+                    LOG.info("gecko profiling enabled")
+                    suite["shouldAlert"] = False
 
                 # as we do navigation, tname could end in .<alias>
                 # test_names doesn't have tname, so either add it to test_names,
                 # or strip it
+                tname = suite["name"]
                 parts = tname.split(".")
                 try:
                     tname = ".".join(parts[:-1])
@@ -234,15 +240,9 @@ class PerftestOutput(object):
         if self.summarized_results == {}:
             return success, 0
 
-        # when gecko_profiling, we don't want results ingested by Perfherder
-        extra_opts = self.summarized_results["suites"][0].get("extraOptions", [])
         test_type = self.summarized_results["suites"][0].get("type", "")
-
         output_perf_data = True
         not_posting = "- not posting regular test results for perfherder"
-        if "gecko-profile" in extra_opts:
-            LOG.info("gecko profiling enabled %s" % not_posting)
-            output_perf_data = False
         if test_type == "scenario":
             # if a resource-usage flag was supplied the perfherder data
             # will still be output from output_supporting_data