Bug 1372823 Part 4: Set-up observer for idle-daily in FormHistoryStartup.init not manifest. r=mak

This is so that we don't open a database connection without any of the machinery in place to close it.

toolkit/components/satchel/FormHistoryStartup.js

@@ -52,6 +52,7 @@ FormHistoryStartup.prototype = {
 
     // triggers needed service cleanup and db shutdown
     Services.obs.addObserver(this, "profile-before-change", true);
+    Services.obs.addObserver(this, "idle-daily", true);
     Services.obs.addObserver(this, "formhistory-expire-now", true);
 
     Services.ppmm.loadProcessScript("chrome://satchel/content/formSubmitListener.js", true);

toolkit/components/satchel/satchel.manifest

@@ -5,4 +5,3 @@ contract @mozilla.org/satchel/inputlist-autocomplete;1 {bf1e01d0-953e-11df-981c-
 component {3a0012eb-007f-4bb8-aa81-a07385f77a25} FormHistoryStartup.js
 contract @mozilla.org/satchel/form-history-startup;1 {3a0012eb-007f-4bb8-aa81-a07385f77a25}
 category profile-after-change formHistoryStartup @mozilla.org/satchel/form-history-startup;1
-category idle-daily formHistoryStartup @mozilla.org/satchel/form-history-startup;1