From 80d9b272adec52aa4f50726576b30868a7aa6b07 Mon Sep 17 00:00:00 2001 From: Karl Tomlinson Date: Sat, 12 Aug 2017 08:55:05 +1200 Subject: [PATCH] bug 1389641 adjust ConvolverNode buffer normalization gain calibration to match spec r=padenot This reduces the amplitude by about 0.7%. MozReview-Commit-ID: 7vTNg2oUXEf --HG-- extra : rebase_source : 4cff5189665396d427c7e6c842a9a002a1734ae5 --- dom/media/webaudio/blink/Reverb.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dom/media/webaudio/blink/Reverb.cpp b/dom/media/webaudio/blink/Reverb.cpp index 6a5c04c45cda..bbf143df3ed2 100644 --- a/dom/media/webaudio/blink/Reverb.cpp +++ b/dom/media/webaudio/blink/Reverb.cpp @@ -38,7 +38,7 @@ using namespace mozilla; namespace WebCore { // Empirical gain calibration tested across many impulse responses to ensure perceived volume is same as dry (unprocessed) signal -const float GainCalibration = -58; +const float GainCalibration = 0.00125; const float GainCalibrationSampleRate = 44100; // A minimum power value to when normalizing a silent (or very quiet) impulse response @@ -64,7 +64,7 @@ static float calculateNormalizationScale(ThreadSharedFloatArrayBufferList* respo float scale = 1 / power; - scale *= powf(10, GainCalibration * 0.05f); // calibrate to make perceived volume same as unprocessed + scale *= GainCalibration; // calibrate to make perceived volume same as unprocessed // Scale depends on sample-rate. if (sampleRate)