Bug 788598 - Logged out state has no login. r=jaws

browser/base/content/browser-social.js

@@ -28,8 +28,12 @@ let SocialUI = {
   },
 
   showProfile: function SocialUI_showProfile() {
-    if (Social.provider)
+    if (this.haveLoggedInUser())
       openUILinkIn(Social.provider.profile.profileURL, "tab");
+    else {
+      // XXX Bug 789585 will implement an API for provider-specified login pages.
+      openUILinkIn(Social.provider.origin, "tab");
+    }
   },
 
   observe: function SocialUI_observe(subject, topic, data) {

browser/base/content/browser.xul

@@ -669,13 +669,13 @@
                        class="toolbarbutton-1"
                        type="menu">
           <menupopup id="social-statusarea-popup">
-            <hbox id="social-statusarea-user" pack="left" align="center">
+            <hbox id="social-statusarea-user" pack="start" align="center"
+                  onclick="SocialUI.showProfile(); document.getElementById('social-statusarea-popup').hidePopup();">
               <image id="social-statusarea-user-portrait"/>
               <vbox>
-                <label id="social-statusarea-notloggedin"
-                       value="&social.notLoggedIn.label;"/>
-                <button id="social-statusarea-username"
-                        oncommand="SocialUI.showProfile(); document.getElementById('social-statusarea-popup').hidePopup();"/>
+                <button id="social-statusarea-notloggedin"
+                        class="link" label="&social.notLoggedIn.label;"/>
+                <button id="social-statusarea-username" class="link"/>
               </vbox>
             </hbox>
             <menuitem id="social-toggle-sidebar-menuitem"

browser/themes/gnomestripe/browser.css

@@ -2676,6 +2676,7 @@ html|*#gcli-output-frame {
   position: relative;
   font: message-box;
   font-size: 12px;
+  cursor: pointer;
 }
 
 #social-statusarea-user-portrait {
@@ -2685,17 +2686,16 @@ html|*#gcli-output-frame {
   margin: 10px;
 }
 
-#social-statusarea-username {
+#social-statusarea-user > vbox > .link {
   -moz-appearance: none;
   background: transparent;
   border: none;
   color: -moz-nativehyperlinktext;
-  cursor: pointer;
   min-width: 0;
   margin: 0 6px;
   list-style-image: none;
 }
-#social-statusarea-username:hover {
+#social-statusarea-user:hover > vbox > .link {
   text-decoration: underline;
 }
 

browser/themes/pinstripe/browser.css

@@ -4095,6 +4095,7 @@ html|*#gcli-output-frame {
   cursor: default;
   font-family: "lucida grande",tahoma,verdana,arial,sans-serif;
   font-size: 12px;
+  cursor: pointer;
 }
 
 #social-statusarea-user-portrait {
@@ -4103,16 +4104,15 @@ html|*#gcli-output-frame {
   margin: 10px;
 }
 
-#social-statusarea-username {
+#social-statusarea-user > vbox > .link {
   -moz-appearance: none;
   color: -moz-nativehyperlinktext;
-  cursor: pointer;
   min-width: 0;
   margin: 0 6px;
   list-style-image: none;
 }
 
-#social-statusarea-username:hover {
+#social-statusarea-user:hover > vbox > .link {
   text-decoration: underline;
 }
 

browser/themes/winstripe/browser.css

@@ -3353,6 +3353,7 @@ html|*#gcli-output-frame {
   position: relative;
   font: message-box;
   font-size: 12px;
+  cursor: pointer;
 }
 
 #social-statusarea-user-portrait {
@@ -3362,17 +3363,16 @@ html|*#gcli-output-frame {
   margin: 10px;
 }
 
-#social-statusarea-username {
+#social-statusarea-user > vbox > .link {
   -moz-appearance: none;
   background: transparent;
   border: none;
   color: -moz-nativehyperlinktext;
-  cursor: pointer;
   min-width: 0;
   margin: 0 6px;
   list-style-image: none;
 }
-#social-statusarea-username:hover {
+#social-statusarea-user:hover > vbox > .link {
   text-decoration: underline;
 }