add more comments about what's left to do, and why this is a little scary.

This commit is contained in:
sspitzer%netscape.com 1999-10-13 05:33:26 +00:00
Родитель 9f622a5a7d
Коммит 872b817711
1 изменённых файлов: 11 добавлений и 2 удалений

Просмотреть файл

@ -487,8 +487,12 @@ NS_IMETHODIMP nsMsgFolder::CreateFolderInDatasource(const char *uri, nsIMsgFolde
{ {
nsresult rv; nsresult rv;
// does this work with a non-top level folder // XXX TODO: fix this.
// imap://sspitzer@tintin/Sent works, but what about imap://sspitzer@tintin/Foo/Bar ? // imap://sspitzer@tintin/Sent works,
// but should do bad things with imap://sspitzer@tintin/Foo/Bar
// we are appending Foo/Bar to list of subfolders for tintin
// are we feeding the copy service some floating resource?
// do we end up with two Sent folder subfolders of tintin, after discovery?
NS_WITH_SERVICE(nsIRDFService, rdf, kRDFServiceCID, &rv); NS_WITH_SERVICE(nsIRDFService, rdf, kRDFServiceCID, &rv);
if(NS_FAILED(rv)) return rv; if(NS_FAILED(rv)) return rv;
@ -502,10 +506,15 @@ NS_IMETHODIMP nsMsgFolder::CreateFolderInDatasource(const char *uri, nsIMsgFolde
nsCOMPtr <nsISupports> supports = do_QueryInterface(folder); nsCOMPtr <nsISupports> supports = do_QueryInterface(folder);
NS_ASSERTION(supports, "couldn't get isupports for msg folder"); NS_ASSERTION(supports, "couldn't get isupports for msg folder");
// is this necessary?
// think about imap://sspitzer@tintin/Foo/Bar
// read comment above
#if 0
if (supports) if (supports)
mSubFolders->AppendElement(supports); mSubFolders->AppendElement(supports);
folder->SetParent(this); folder->SetParent(this);
#endif
*child = folder; *child = folder;
NS_IF_ADDREF(*child); NS_IF_ADDREF(*child);
return rv; return rv;