From 873a3e02c2a9cc0d833e0877edd6f23002514aeb Mon Sep 17 00:00:00 2001
From: Greg Tatum <gtatum@mozilla.com>
Date: Wed, 27 May 2020 22:07:08 +0000
Subject: [PATCH] Bug 1633855 - Re-work the experimental definitions for
 features; r=julienw

This commit changes up the definitions of the presets a bit. I promoted the
allocations work to non-experimental, as it's fairly well supported now in the UI.
Others I demoted to experimental if they were not supported in our current UI,
or flat out don't work.

Differential Revision: https://phabricator.services.mozilla.com/D76511
---
 .../client/performance-new/@types/perf.d.ts    |  2 ++
 devtools/client/performance-new/utils.js       | 18 ++++++++----------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/devtools/client/performance-new/@types/perf.d.ts b/devtools/client/performance-new/@types/perf.d.ts
index d97be870e05b..1304e7559e8a 100644
--- a/devtools/client/performance-new/@types/perf.d.ts
+++ b/devtools/client/performance-new/@types/perf.d.ts
@@ -476,6 +476,8 @@ export interface FeatureDescription {
   title: string,
   // This will give the user a hint that it's recommended on.
   recommended?: boolean,
+  // This will give the user a hint that it's an experimental feature.
+  experimental?: boolean,
   // This will give a reason if the feature is disabled.
   disabledReason?: string,
 }
diff --git a/devtools/client/performance-new/utils.js b/devtools/client/performance-new/utils.js
index fda8f12b0398..d157d13cbe50 100644
--- a/devtools/client/performance-new/utils.js
+++ b/devtools/client/performance-new/utils.js
@@ -321,12 +321,6 @@ const featureDescriptions = [
       "Record JavaScript stack information, and interleave it with native stacks.",
     recommended: true,
   },
-  {
-    name: "Responsiveness",
-    value: "responsiveness",
-    title: "Collect thread responsiveness information.",
-    recommended: true,
-  },
   {
     name: "Java",
     value: "java",
@@ -354,6 +348,7 @@ const featureDescriptions = [
     name: "Privacy",
     value: "privacy",
     title: "Remove some potentially user-identifiable information.",
+    experimental: true,
   },
   {
     name: "Sequential Styling",
@@ -364,11 +359,13 @@ const featureDescriptions = [
     name: "JIT Optimizations",
     value: "trackopts",
     title: "Track JIT optimizations in the JS engine.",
+    experimental: true,
   },
   {
     name: "TaskTracer",
     value: "tasktracer",
-    title: "Enable TaskTracer (Experimental.)",
+    title: "Enable TaskTracer",
+    experimental: true,
     disabledReason:
       "TaskTracer requires a custom build with the environment variable MOZ_TASK_TRACER set.",
   },
@@ -380,7 +377,8 @@ const featureDescriptions = [
   {
     name: "JSTracer",
     value: "jstracer",
-    title: "Trace JS engine (Experimental.)",
+    title: "Trace JS engine",
+    experimental: true,
     disabledReason:
       "JS Tracer is currently disabled due to crashes. See Bug 1565788.",
   },
@@ -397,12 +395,12 @@ const featureDescriptions = [
   {
     name: "JS Allocations",
     value: "jsallocations",
-    title: "Track JavaScript allocations (Experimental.)",
+    title: "Track JavaScript allocations",
   },
   {
     name: "Native Allocations",
     value: "nativeallocations",
-    title: "Track native allocations (Experimental.)",
+    title: "Track native allocations",
   },
 ];