From 87b3beffae1acd2fcfeacf3ed362bb64e75a1f05 Mon Sep 17 00:00:00 2001 From: Ting-Yu Lin Date: Thu, 2 May 2019 21:41:33 +0000 Subject: [PATCH] Bug 1548126 - Mark known existing reftests failures with column-span enabled. r=dholbert Due to the syntax limitation in failures.list, I cannot mark multicol-rule-004.xht as fails with column-span enabled and success with column-span disabled simultaneously. Luckily, we had another copy of it in testing/web-platform/tests/css/css-multicol/multicol-rule-004.xht, We can use it to test with column-span disabled for now. Differential Revision: https://phabricator.services.mozilla.com/D29419 --HG-- extra : moz-landing-system : lando --- layout/reftests/columns/reftest.list | 9 +++++++++ layout/reftests/w3c-css/failures.list | 2 ++ layout/reftests/w3c-css/received/reftest.list | 2 +- layout/reftests/w3c-css/submitted/contain/reftest.list | 9 +++++++++ 4 files changed, 21 insertions(+), 1 deletion(-) diff --git a/layout/reftests/columns/reftest.list b/layout/reftests/columns/reftest.list index a73b49c8a8f2..3faae5a9575e 100644 --- a/layout/reftests/columns/reftest.list +++ b/layout/reftests/columns/reftest.list @@ -42,3 +42,12 @@ fuzzy-if(browserIsRemote&&winWidget,0-142,0-276) == fieldset-columns-001.html fi == break-avoid-line-position-1.html break-avoid-line-position-1-ref.html pref(layout.css.column-span.enabled,true) == column-span-bidi-1.html column-span-bidi-1-ref.html pref(layout.css.column-span.enabled,true) == first-line-first-letter.html first-line-first-letter-ref.html + +# The following lines are duplicates of other lines from further up in this +# manifest. They're listed again here so we can re-run these tests with +# column-span enabled. These lines can be removed once the pref becomes +# default-enabled (Bug 1426010). +default-preferences pref(layout.css.column-span.enabled,true) +fails == min-width-2.html min-width-2-ref.html # Bug 1548100 +fails == column-balancing-nested-001.html column-balancing-nested-001-ref.html # Bug 1548118 +default-preferences diff --git a/layout/reftests/w3c-css/failures.list b/layout/reftests/w3c-css/failures.list index c9d91449de03..9f5a3df88536 100644 --- a/layout/reftests/w3c-css/failures.list +++ b/layout/reftests/w3c-css/failures.list @@ -258,6 +258,8 @@ fuzzy-if(OSX,0-11,0-20) css-multicol/multicol-rule-000.xht fuzzy(0-135,0-1584) css-multicol/multicol-rule-001.xht fails-if(!OSX) random-if(OSX) css-multicol/multicol-rule-002.xht css-multicol/multicol-rule-003.xht +# Bug 1548100 +pref(layout.css.column-span.enabled,true) fails css-multicol/multicol-rule-004.xht css-multicol/multicol-rule-color-001.xht fuzzy(0-106,0-354) css-multicol/multicol-rule-dashed-000.xht fuzzy(0-106,0-354) css-multicol/multicol-rule-dotted-000.xht diff --git a/layout/reftests/w3c-css/received/reftest.list b/layout/reftests/w3c-css/received/reftest.list index ac508339614b..5b012d714090 100644 --- a/layout/reftests/w3c-css/received/reftest.list +++ b/layout/reftests/w3c-css/received/reftest.list @@ -125,7 +125,7 @@ fuzzy-if(OSX,0-11,0-20) == css-multicol/multicol-rule-000.xht css-multicol/multi fuzzy(0-135,0-1584) == css-multicol/multicol-rule-001.xht css-multicol/multicol-rule-001-ref.xht fails-if(!OSX) random-if(OSX) == css-multicol/multicol-rule-002.xht css-multicol/multicol-rule-ref.xht == css-multicol/multicol-rule-003.xht css-multicol/multicol-rule-003-ref.xht -== css-multicol/multicol-rule-004.xht css-multicol/multicol-rule-004-ref.xht +pref(layout.css.column-span.enabled,true) fails == css-multicol/multicol-rule-004.xht css-multicol/multicol-rule-004-ref.xht == css-multicol/multicol-rule-color-001.xht css-multicol/multicol-rule-color-001-ref.xht == css-multicol/multicol-rule-color-inherit-001.xht css-multicol/multicol-rule-color-inherit-001-ref.xht == css-multicol/multicol-rule-color-inherit-002.xht css-multicol/multicol-rule-color-inherit-001-ref.xht diff --git a/layout/reftests/w3c-css/submitted/contain/reftest.list b/layout/reftests/w3c-css/submitted/contain/reftest.list index 69515be72671..b6f6aa9e4d10 100644 --- a/layout/reftests/w3c-css/submitted/contain/reftest.list +++ b/layout/reftests/w3c-css/submitted/contain/reftest.list @@ -49,3 +49,12 @@ fuzzy-if(webrender&&winWidget,0-24,0-2) == contain-size-inline-flex-001.html con == contain-layout-ignored-cases-no-principal-box-003.html contain-layout-ignored-cases-no-principal-box-003-ref.html == contain-layout-suppress-baseline-001.html contain-layout-suppress-baseline-001-ref.html fails == contain-layout-suppress-baseline-002.html contain-layout-suppress-baseline-002-ref.html # bug 1508441 + +# The following lines are duplicates of other lines from further up in this +# manifest. They're listed again here so we can re-run these tests with +# column-span enabled. These lines can be removed once the pref becomes +# default-enabled (Bug 1426010). +default-preferences pref(layout.css.column-span.enabled,true) +fails == contain-size-multicol-002.html contain-size-multicol-002-ref.html # Bug 1494100 +fails == contain-size-multicol-003.html contain-size-multicol-003-ref.html # Bug 1494100 +default-preferences